All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: linux-kernel@vger.kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers base/arch_topology: Remove 'struct sched_domain' forward declaration
Date: Fri, 7 Feb 2020 15:48:55 +0000	[thread overview]
Message-ID: <20200207154855.GA5529@bogus> (raw)
In-Reply-To: <20200207114913.3052-1-dietmar.eggemann@arm.com>

On Fri, Feb 07, 2020 at 12:49:13PM +0100, Dietmar Eggemann wrote:
> The sched domain pointer argument from topology_get_freq_scale() and
> topology_get_cpu_scale() got removed by commit 7673c8a4c75d
> ("sched/cpufreq: Remove arch_scale_freq_capacity()'s 'sd' parameter")
> and commit 8ec59c0f5f49 ("sched/topology: Remove unused 'sd' parameter
> from arch_scale_cpu_capacity()").
>
> So the 'struct sched_domain' forward declaration is no longer needed.
> Remove it.
>
> W/o the sched domain pointer argument the storage class and inline
> definition as well as the return type, function name and parameter list
> fit all into one line.

Looks simple and good to me. I don't want to ask you split the patch as
$subject indicates only one of the 2 changes in the patch. I am fine with
it as it but if anyone else shout for that, go for the split.

Either way,

Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>

You have not added Greg who generally picks up the patch. Can you repost
with him in cc and my reviewed-by so that he can pick it up.

--
Regards,
Sudeep

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Juri Lelli <juri.lelli@redhat.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] drivers base/arch_topology: Remove 'struct sched_domain' forward declaration
Date: Fri, 7 Feb 2020 15:48:55 +0000	[thread overview]
Message-ID: <20200207154855.GA5529@bogus> (raw)
In-Reply-To: <20200207114913.3052-1-dietmar.eggemann@arm.com>

On Fri, Feb 07, 2020 at 12:49:13PM +0100, Dietmar Eggemann wrote:
> The sched domain pointer argument from topology_get_freq_scale() and
> topology_get_cpu_scale() got removed by commit 7673c8a4c75d
> ("sched/cpufreq: Remove arch_scale_freq_capacity()'s 'sd' parameter")
> and commit 8ec59c0f5f49 ("sched/topology: Remove unused 'sd' parameter
> from arch_scale_cpu_capacity()").
>
> So the 'struct sched_domain' forward declaration is no longer needed.
> Remove it.
>
> W/o the sched domain pointer argument the storage class and inline
> definition as well as the return type, function name and parameter list
> fit all into one line.

Looks simple and good to me. I don't want to ask you split the patch as
$subject indicates only one of the 2 changes in the patch. I am fine with
it as it but if anyone else shout for that, go for the split.

Either way,

Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>

You have not added Greg who generally picks up the patch. Can you repost
with him in cc and my reviewed-by so that he can pick it up.

--
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-02-07 15:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 11:49 [PATCH] drivers base/arch_topology: Remove 'struct sched_domain' forward declaration Dietmar Eggemann
2020-02-07 11:49 ` Dietmar Eggemann
2020-02-07 15:48 ` Sudeep Holla [this message]
2020-02-07 15:48   ` Sudeep Holla
2020-02-10 15:20   ` Dietmar Eggemann
2020-02-10 15:20     ` Dietmar Eggemann
2020-02-10 15:24 Dietmar Eggemann
2020-02-10 15:24 ` Dietmar Eggemann
2020-02-10 16:02 ` Greg Kroah-Hartman
2020-02-10 16:02   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200207154855.GA5529@bogus \
    --to=sudeep.holla@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.