* [PATCH net 0/2] net: dsa: Make sure there is headroom for tag
@ 2020-02-13 13:50 Per, Forlin <per.forlin
2020-02-13 13:50 ` [PATCH net 1/2] net: dsa: tag_qca: " Per, Forlin <per.forlin
2020-02-13 13:51 ` [PATCH net 2/2] net: dsa: tag_ar9331: " Per, Forlin <per.forlin
0 siblings, 2 replies; 10+ messages in thread
From: Per, Forlin <per.forlin @ 2020-02-13 13:50 UTC (permalink / raw)
To: netdev, andrew, o.rempel, davem; +Cc: Per Forlin
From: Per Forlin <per.forlin@axis.com>
Re-posting patches with a cover letter.
I forgot to include a cover-letter in the first round.
Fix two tag drivers to make sure there is headroom for the tag data.
Per Forlin (2):
net: dsa: tag_qca: Make sure there is headroom for tag
net: dsa: tag_ar9331: Make sure there is headroom for tag
net/dsa/tag_ar9331.c | 2 +-
net/dsa/tag_qca.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH net 1/2] net: dsa: tag_qca: Make sure there is headroom for tag
2020-02-13 13:50 [PATCH net 0/2] net: dsa: Make sure there is headroom for tag Per, Forlin <per.forlin
@ 2020-02-13 13:50 ` Per, Forlin <per.forlin
2020-02-13 14:01 ` Andrew Lunn
2020-02-13 13:51 ` [PATCH net 2/2] net: dsa: tag_ar9331: " Per, Forlin <per.forlin
1 sibling, 1 reply; 10+ messages in thread
From: Per, Forlin <per.forlin @ 2020-02-13 13:50 UTC (permalink / raw)
To: netdev, andrew, o.rempel, davem; +Cc: Per Forlin, Per Forlin
From: Per Forlin <per.forlin@axis.com>
Passing tag size to skb_cow_head will make sure
there is enough headroom for the tag data.
This change does not introduce any overhead in case there
is already available headroom for tag.
Signed-off-by: Per Forlin <perfn@axis.com>
---
net/dsa/tag_qca.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c
index c8a128c9e5e0..70db7c909f74 100644
--- a/net/dsa/tag_qca.c
+++ b/net/dsa/tag_qca.c
@@ -33,7 +33,7 @@ static struct sk_buff *qca_tag_xmit(struct sk_buff *skb, struct net_device *dev)
struct dsa_port *dp = dsa_slave_to_port(dev);
u16 *phdr, hdr;
- if (skb_cow_head(skb, 0) < 0)
+ if (skb_cow_head(skb, QCA_HDR_LEN) < 0)
return NULL;
skb_push(skb, QCA_HDR_LEN);
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH net 1/2] net: dsa: tag_qca: Make sure there is headroom for tag
2020-02-13 13:50 ` [PATCH net 1/2] net: dsa: tag_qca: " Per, Forlin <per.forlin
@ 2020-02-13 14:01 ` Andrew Lunn
2020-02-13 15:08 ` Per Förlin
0 siblings, 1 reply; 10+ messages in thread
From: Andrew Lunn @ 2020-02-13 14:01 UTC (permalink / raw)
To: Per, Forlin; +Cc: netdev, o.rempel, davem, Per Forlin, Per Forlin
On Thu, Feb 13, 2020 at 02:50:59PM +0100, Per@axis.com wrote:
> From: Per Forlin <per.forlin@axis.com>
>
> Passing tag size to skb_cow_head will make sure
> there is enough headroom for the tag data.
> This change does not introduce any overhead in case there
> is already available headroom for tag.
>
> Signed-off-by: Per Forlin <perfn@axis.com>
Hi Per
If these are for net, you need a Fixes: tag.
Also, you should add the Reivewed-by: tags i gave for these patches.
Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH net 1/2] net: dsa: tag_qca: Make sure there is headroom for tag
2020-02-13 14:01 ` Andrew Lunn
@ 2020-02-13 15:08 ` Per Förlin
0 siblings, 0 replies; 10+ messages in thread
From: Per Förlin @ 2020-02-13 15:08 UTC (permalink / raw)
To: Andrew Lunn; +Cc: netdev, o.rempel, davem
> > This change does not introduce any overhead in case there
> > is already available headroom for tag.
> >
> > Signed-off-by: Per Forlin <perfn@axis.com>
> Hi Per
> If these are for net, you need a Fixes: tag.
> Also, you should add the Reivewed-by: tags i gave for these patches.
Yes, I should add this too.
I will post a new series after the weekend with the received Reviewed-by and Tested-by as well.
BR
Per
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH net 2/2] net: dsa: tag_ar9331: Make sure there is headroom for tag
2020-02-13 13:50 [PATCH net 0/2] net: dsa: Make sure there is headroom for tag Per, Forlin <per.forlin
2020-02-13 13:50 ` [PATCH net 1/2] net: dsa: tag_qca: " Per, Forlin <per.forlin
@ 2020-02-13 13:51 ` Per, Forlin <per.forlin
2020-02-13 13:59 ` Oleksij Rempel
2020-02-13 14:26 ` David Miller
1 sibling, 2 replies; 10+ messages in thread
From: Per, Forlin <per.forlin @ 2020-02-13 13:51 UTC (permalink / raw)
To: netdev, andrew, o.rempel, davem; +Cc: Per Forlin, Per Forlin
From: Per Forlin <per.forlin@axis.com>
Passing tag size to skb_cow_head will make sure
there is enough headroom for the tag data.
This change does not introduce any overhead in case there
is already available headroom for tag.
Signed-off-by: Per Forlin <perfn@axis.com>
---
net/dsa/tag_ar9331.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dsa/tag_ar9331.c b/net/dsa/tag_ar9331.c
index 466ffa92a474..55b00694cdba 100644
--- a/net/dsa/tag_ar9331.c
+++ b/net/dsa/tag_ar9331.c
@@ -31,7 +31,7 @@ static struct sk_buff *ar9331_tag_xmit(struct sk_buff *skb,
__le16 *phdr;
u16 hdr;
- if (skb_cow_head(skb, 0) < 0)
+ if (skb_cow_head(skb, AR9331_HDR_LEN) < 0)
return NULL;
phdr = skb_push(skb, AR9331_HDR_LEN);
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH net 2/2] net: dsa: tag_ar9331: Make sure there is headroom for tag
2020-02-13 13:51 ` [PATCH net 2/2] net: dsa: tag_ar9331: " Per, Forlin <per.forlin
@ 2020-02-13 13:59 ` Oleksij Rempel
2020-02-13 14:42 ` Per Förlin
2020-02-13 14:26 ` David Miller
1 sibling, 1 reply; 10+ messages in thread
From: Oleksij Rempel @ 2020-02-13 13:59 UTC (permalink / raw)
To: Per, "Forlin, netdev, andrew, davem; +Cc: Per Forlin, Per Forlin
Hi,
On 13.02.20 14:51, Per@axis.com wrote:
> From: Per Forlin <per.forlin@axis.com>
>
> Passing tag size to skb_cow_head will make sure
> there is enough headroom for the tag data.
> This change does not introduce any overhead in case there
> is already available headroom for tag.
>
> Signed-off-by: Per Forlin <perfn@axis.com>
Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
Are you using this driver?
> ---
> net/dsa/tag_ar9331.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/dsa/tag_ar9331.c b/net/dsa/tag_ar9331.c
> index 466ffa92a474..55b00694cdba 100644
> --- a/net/dsa/tag_ar9331.c
> +++ b/net/dsa/tag_ar9331.c
> @@ -31,7 +31,7 @@ static struct sk_buff *ar9331_tag_xmit(struct sk_buff *skb,
> __le16 *phdr;
> u16 hdr;
>
> - if (skb_cow_head(skb, 0) < 0)
> + if (skb_cow_head(skb, AR9331_HDR_LEN) < 0)
> return NULL;
>
> phdr = skb_push(skb, AR9331_HDR_LEN);
>
Kind regards,
Oleksij Rempel
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net 2/2] net: dsa: tag_ar9331: Make sure there is headroom for tag
2020-02-13 13:59 ` Oleksij Rempel
@ 2020-02-13 14:42 ` Per Förlin
0 siblings, 0 replies; 10+ messages in thread
From: Per Förlin @ 2020-02-13 14:42 UTC (permalink / raw)
To: Oleksij Rempel, netdev, andrew, davem
> >
> > Signed-off-by: Per Forlin <perfn@axis.com>
> Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Thank you!
> Are you using this driver?
Hi,
I'm not using this particular driver.
I'm using the tag_qca driver and this driver had the same typo.
Br
Per
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net 2/2] net: dsa: tag_ar9331: Make sure there is headroom for tag
2020-02-13 13:51 ` [PATCH net 2/2] net: dsa: tag_ar9331: " Per, Forlin <per.forlin
2020-02-13 13:59 ` Oleksij Rempel
@ 2020-02-13 14:26 ` David Miller
1 sibling, 0 replies; 10+ messages in thread
From: David Miller @ 2020-02-13 14:26 UTC (permalink / raw)
To: Per; +Cc: netdev, andrew, o.rempel, per.forlin, perfn
You need to fix your email setup if you want to post patches here.
You are providing multiple email addresses in your From: field and
almost every major email provider (including gmail) rejects emails
with that.
So nobody is seeing your postings until you fix this.
Thank you.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH net 0/2] net: dsa: Make sure there is headroom for tag
@ 2020-02-13 14:37 Per Forlin
2020-02-14 15:35 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: Per Forlin @ 2020-02-13 14:37 UTC (permalink / raw)
To: netdev, andrew, o.rempel, davem; +Cc: Per Forlin
Sorry for re-posting yet another time....
I manage to include multiple email-senders and forgot to include cover-letter.
Let's hope everyhthing is in order this time.
Fix two tag drivers to make sure there is headroom for the tag data.
Per Forlin (2):
net: dsa: tag_qca: Make sure there is headroom for tag
net: dsa: tag_ar9331: Make sure there is headroom for tag
net/dsa/tag_ar9331.c | 2 +-
net/dsa/tag_qca.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net 0/2] net: dsa: Make sure there is headroom for tag
2020-02-13 14:37 [PATCH net 0/2] net: dsa: " Per Forlin
@ 2020-02-14 15:35 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2020-02-14 15:35 UTC (permalink / raw)
To: per.forlin; +Cc: netdev, andrew, o.rempel
From: Per Forlin <per.forlin@axis.com>
Date: Thu, 13 Feb 2020 15:37:08 +0100
> Sorry for re-posting yet another time....
> I manage to include multiple email-senders and forgot to include cover-letter.
> Let's hope everyhthing is in order this time.
>
> Fix two tag drivers to make sure there is headroom for the tag data.
Series applied and queued up for -stable.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-02-14 15:35 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13 13:50 [PATCH net 0/2] net: dsa: Make sure there is headroom for tag Per, Forlin <per.forlin
2020-02-13 13:50 ` [PATCH net 1/2] net: dsa: tag_qca: " Per, Forlin <per.forlin
2020-02-13 14:01 ` Andrew Lunn
2020-02-13 15:08 ` Per Förlin
2020-02-13 13:51 ` [PATCH net 2/2] net: dsa: tag_ar9331: " Per, Forlin <per.forlin
2020-02-13 13:59 ` Oleksij Rempel
2020-02-13 14:42 ` Per Förlin
2020-02-13 14:26 ` David Miller
2020-02-13 14:37 [PATCH net 0/2] net: dsa: " Per Forlin
2020-02-14 15:35 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.