* [PATCH] swuashfs-tools: Enable on musl
@ 2020-02-14 7:03 Khem Raj
2020-02-14 14:35 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2020-02-14 7:03 UTC (permalink / raw)
To: openembedded-core
Upstream has a patch [1] to fix musl builds, Prior to this it would not
build on musl due to missing GNU extentions for fnmatch
[1] https://github.com/plougher/squashfs-tools/commit/4280e74de14070869787a9166242f9ce2dafd82e
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb | 3 ---
1 file changed, 3 deletions(-)
diff --git a/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb b/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb
index 4fd33f8048..9bcf026ce2 100644
--- a/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb
+++ b/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb
@@ -12,9 +12,6 @@ SRC_URI = "git://github.com/plougher/squashfs-tools.git;protocol=https \
S = "${WORKDIR}/git/squashfs-tools"
-# needs FNM_EXTMATCH
-COMPATIBLE_HOST_libc-musl = 'null'
-
EXTRA_OEMAKE = "${PACKAGECONFIG_CONFARGS}"
PACKAGECONFIG ??= "gzip xz lzo lz4 lzma xattr reproducible"
--
2.25.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] swuashfs-tools: Enable on musl
2020-02-14 7:03 [PATCH] swuashfs-tools: Enable on musl Khem Raj
@ 2020-02-14 14:35 ` Adrian Bunk
2020-02-14 14:42 ` Khem Raj
2020-02-14 14:49 ` Robert P. J. Day
0 siblings, 2 replies; 6+ messages in thread
From: Adrian Bunk @ 2020-02-14 14:35 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
On Thu, Feb 13, 2020 at 11:03:52PM -0800, Khem Raj wrote:
> Upstream has a patch [1] to fix musl builds, Prior to this it would not
> build on musl due to missing GNU extentions for fnmatch
>
> [1] https://github.com/plougher/squashfs-tools/commit/4280e74de14070869787a9166242f9ce2dafd82e
>...
I did already remove a similar bogus squashfs-tools change from OE,
with similar FNM_EXTMATCH "fixes" in ifupdown and elfutils
also resulting in the expected runtime misbehaviour.
I am not a fan of this musl way of fixing build failures by turning them
into runtime breakages.
cu
Adrian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] swuashfs-tools: Enable on musl
2020-02-14 14:35 ` Adrian Bunk
@ 2020-02-14 14:42 ` Khem Raj
2020-02-14 15:50 ` Adrian Bunk
2020-02-14 14:49 ` Robert P. J. Day
1 sibling, 1 reply; 6+ messages in thread
From: Khem Raj @ 2020-02-14 14:42 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Patches and discussions about the oe-core layer
On Fri, Feb 14, 2020 at 6:35 AM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Thu, Feb 13, 2020 at 11:03:52PM -0800, Khem Raj wrote:
> > Upstream has a patch [1] to fix musl builds, Prior to this it would not
> > build on musl due to missing GNU extentions for fnmatch
> >
> > [1] https://github.com/plougher/squashfs-tools/commit/4280e74de14070869787a9166242f9ce2dafd82e
> >...
>
> I did already remove a similar bogus squashfs-tools change from OE,
> with similar FNM_EXTMATCH "fixes" in ifupdown and elfutils
> also resulting in the expected runtime misbehaviour.
>
I think it would be better to use gnulib implementation for these
packages you point out
and those patches will be upstream worthy and make them portable
as well.
At least it is calling out bad elements.
> I am not a fan of this musl way of fixing build failures by turning them
> into runtime breakages.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] swuashfs-tools: Enable on musl
2020-02-14 14:42 ` Khem Raj
@ 2020-02-14 15:50 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2020-02-14 15:50 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On Fri, Feb 14, 2020 at 06:42:12AM -0800, Khem Raj wrote:
> On Fri, Feb 14, 2020 at 6:35 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > On Thu, Feb 13, 2020 at 11:03:52PM -0800, Khem Raj wrote:
> > > Upstream has a patch [1] to fix musl builds, Prior to this it would not
> > > build on musl due to missing GNU extentions for fnmatch
> > >
> > > [1] https://github.com/plougher/squashfs-tools/commit/4280e74de14070869787a9166242f9ce2dafd82e
> > >...
> >
> > I did already remove a similar bogus squashfs-tools change from OE,
> > with similar FNM_EXTMATCH "fixes" in ifupdown and elfutils
> > also resulting in the expected runtime misbehaviour.
>
> I think it would be better to use gnulib implementation for these
> packages you point out
> and those patches will be upstream worthy and make them portable
> as well.
Yes, this would be better since the resulting code would be working.
But looking at the gnulib sources someone made gl_FUNC_FNMATCH_GNU do
the wrong thing by "guessing yes" when cross-compiling for musl...
> At least it is calling out bad elements.
The only bad element is code that builds but silently does the wrong
thing. Everything else is visible for users early during product
development and can be mitigated.
cu
Adrian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] swuashfs-tools: Enable on musl
2020-02-14 14:35 ` Adrian Bunk
2020-02-14 14:42 ` Khem Raj
@ 2020-02-14 14:49 ` Robert P. J. Day
2020-02-14 15:37 ` Khem Raj
1 sibling, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2020-02-14 14:49 UTC (permalink / raw)
To: Adrian Bunk; +Cc: openembedded-core
"swuashfs"?
rday
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-14 15:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 7:03 [PATCH] swuashfs-tools: Enable on musl Khem Raj
2020-02-14 14:35 ` Adrian Bunk
2020-02-14 14:42 ` Khem Raj
2020-02-14 15:50 ` Adrian Bunk
2020-02-14 14:49 ` Robert P. J. Day
2020-02-14 15:37 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.