* Re: [PATCH] xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd
2020-02-18 11:33 [PATCH] xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd Francisco Iglesias
@ 2020-02-16 16:04 ` Edgar E. Iglesias
2020-02-20 15:02 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Edgar E. Iglesias @ 2020-02-16 16:04 UTC (permalink / raw)
To: Francisco Iglesias
Cc: peter.maydell, sai.pavan.boddu, alistair, qemu-devel, edgari,
clg, alistair23
On Tue, Feb 18, 2020 at 12:33:50PM +0100, Francisco Iglesias wrote:
> From: Francisco Iglesias <francisco.iglesias@xilinx.com>
>
> Correct the number of dummy cycles required by the FAST_READ_4 command (to
> be eight, one dummy byte).
>
> Fixes: ef06ca3946 ("xilinx_spips: Add support for RX discard and RX drain")
> Suggested-by: Cédric Le Goater <clg@kaod.org>
> Signed-off-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
> hw/ssi/xilinx_spips.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index 6c9ef59779..c57850a505 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -576,11 +576,11 @@ static int xilinx_spips_num_dummies(XilinxQSPIPS *qs, uint8_t command)
> case FAST_READ:
> case DOR:
> case QOR:
> + case FAST_READ_4:
> case DOR_4:
> case QOR_4:
> return 1;
> case DIOR:
> - case FAST_READ_4:
> case DIOR_4:
> return 2;
> case QIOR:
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd
@ 2020-02-18 11:33 Francisco Iglesias
2020-02-16 16:04 ` Edgar E. Iglesias
0 siblings, 1 reply; 3+ messages in thread
From: Francisco Iglesias @ 2020-02-18 11:33 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, sai.pavan.boddu, alistair, edgari, clg, alistair23
From: Francisco Iglesias <francisco.iglesias@xilinx.com>
Correct the number of dummy cycles required by the FAST_READ_4 command (to
be eight, one dummy byte).
Fixes: ef06ca3946 ("xilinx_spips: Add support for RX discard and RX drain")
Suggested-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Francisco Iglesias <frasse.iglesias@gmail.com>
---
hw/ssi/xilinx_spips.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
index 6c9ef59779..c57850a505 100644
--- a/hw/ssi/xilinx_spips.c
+++ b/hw/ssi/xilinx_spips.c
@@ -576,11 +576,11 @@ static int xilinx_spips_num_dummies(XilinxQSPIPS *qs, uint8_t command)
case FAST_READ:
case DOR:
case QOR:
+ case FAST_READ_4:
case DOR_4:
case QOR_4:
return 1;
case DIOR:
- case FAST_READ_4:
case DIOR_4:
return 2;
case QIOR:
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd
2020-02-16 16:04 ` Edgar E. Iglesias
@ 2020-02-20 15:02 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2020-02-20 15:02 UTC (permalink / raw)
To: Edgar E. Iglesias
Cc: Sai Pavan Boddu, Francisco Iglesias, Alistair Francis,
QEMU Developers, Edgar Iglesias, Cédric Le Goater,
Alistair Francis
On Wed, 19 Feb 2020 at 01:12, Edgar E. Iglesias
<edgar.iglesias@xilinx.com> wrote:
>
> On Tue, Feb 18, 2020 at 12:33:50PM +0100, Francisco Iglesias wrote:
> > From: Francisco Iglesias <francisco.iglesias@xilinx.com>
> >
> > Correct the number of dummy cycles required by the FAST_READ_4 command (to
> > be eight, one dummy byte).
> >
> > Fixes: ef06ca3946 ("xilinx_spips: Add support for RX discard and RX drain")
> > Suggested-by: Cédric Le Goater <clg@kaod.org>
> > Signed-off-by: Francisco Iglesias <frasse.iglesias@gmail.com>
>
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-20 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-18 11:33 [PATCH] xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd Francisco Iglesias
2020-02-16 16:04 ` Edgar E. Iglesias
2020-02-20 15:02 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.