From: Wambui Karuga <wambui.karugax@gmail.com> To: daniel@ffwll.ch, airlied@linux.ie, Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org Subject: [PATCH 13/21] drm/omapdrm: remove checks for return value of drm_debugfs functions. Date: Thu, 27 Feb 2020 15:02:24 +0300 [thread overview] Message-ID: <20200227120232.19413-14-wambui.karugax@gmail.com> (raw) In-Reply-To: <20200227120232.19413-1-wambui.karugax@gmail.com> Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), there is no need to ever check the return value for drm_debugfs_create_files(). Therefore remove the checks for the return value and subsequent error handling in omap_debugfs_init(). These changes also enables the changing of omap_debugfs_init() to return void. Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com> --- drivers/gpu/drm/omapdrm/omap_debugfs.c | 29 +++++++------------------- drivers/gpu/drm/omapdrm/omap_drv.h | 2 +- 2 files changed, 8 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_debugfs.c b/drivers/gpu/drm/omapdrm/omap_debugfs.c index 34dfb33145b4..b57fbe8a0ac2 100644 --- a/drivers/gpu/drm/omapdrm/omap_debugfs.c +++ b/drivers/gpu/drm/omapdrm/omap_debugfs.c @@ -80,31 +80,16 @@ static struct drm_info_list omap_dmm_debugfs_list[] = { {"tiler_map", tiler_map_show, 0}, }; -int omap_debugfs_init(struct drm_minor *minor) +void omap_debugfs_init(struct drm_minor *minor) { - struct drm_device *dev = minor->dev; - int ret; - - ret = drm_debugfs_create_files(omap_debugfs_list, - ARRAY_SIZE(omap_debugfs_list), - minor->debugfs_root, minor); - - if (ret) { - dev_err(dev->dev, "could not install omap_debugfs_list\n"); - return ret; - } + drm_debugfs_create_files(omap_debugfs_list, + ARRAY_SIZE(omap_debugfs_list), + minor->debugfs_root, minor); if (dmm_is_available()) - ret = drm_debugfs_create_files(omap_dmm_debugfs_list, - ARRAY_SIZE(omap_dmm_debugfs_list), - minor->debugfs_root, minor); - - if (ret) { - dev_err(dev->dev, "could not install omap_dmm_debugfs_list\n"); - return ret; - } - - return ret; + drm_debugfs_create_files(omap_dmm_debugfs_list, + ARRAY_SIZE(omap_dmm_debugfs_list), + minor->debugfs_root, minor); } #endif diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h index 7c4b66efcaa7..8a1fac680138 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.h +++ b/drivers/gpu/drm/omapdrm/omap_drv.h @@ -82,6 +82,6 @@ struct omap_drm_private { }; -int omap_debugfs_init(struct drm_minor *minor); +void omap_debugfs_init(struct drm_minor *minor); #endif /* __OMAPDRM_DRV_H__ */ -- 2.25.0
WARNING: multiple messages have this Message-ID (diff)
From: Wambui Karuga <wambui.karugax@gmail.com> To: daniel@ffwll.ch, airlied@linux.ie, Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 13/21] drm/omapdrm: remove checks for return value of drm_debugfs functions. Date: Thu, 27 Feb 2020 15:02:24 +0300 [thread overview] Message-ID: <20200227120232.19413-14-wambui.karugax@gmail.com> (raw) In-Reply-To: <20200227120232.19413-1-wambui.karugax@gmail.com> Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), there is no need to ever check the return value for drm_debugfs_create_files(). Therefore remove the checks for the return value and subsequent error handling in omap_debugfs_init(). These changes also enables the changing of omap_debugfs_init() to return void. Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com> --- drivers/gpu/drm/omapdrm/omap_debugfs.c | 29 +++++++------------------- drivers/gpu/drm/omapdrm/omap_drv.h | 2 +- 2 files changed, 8 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_debugfs.c b/drivers/gpu/drm/omapdrm/omap_debugfs.c index 34dfb33145b4..b57fbe8a0ac2 100644 --- a/drivers/gpu/drm/omapdrm/omap_debugfs.c +++ b/drivers/gpu/drm/omapdrm/omap_debugfs.c @@ -80,31 +80,16 @@ static struct drm_info_list omap_dmm_debugfs_list[] = { {"tiler_map", tiler_map_show, 0}, }; -int omap_debugfs_init(struct drm_minor *minor) +void omap_debugfs_init(struct drm_minor *minor) { - struct drm_device *dev = minor->dev; - int ret; - - ret = drm_debugfs_create_files(omap_debugfs_list, - ARRAY_SIZE(omap_debugfs_list), - minor->debugfs_root, minor); - - if (ret) { - dev_err(dev->dev, "could not install omap_debugfs_list\n"); - return ret; - } + drm_debugfs_create_files(omap_debugfs_list, + ARRAY_SIZE(omap_debugfs_list), + minor->debugfs_root, minor); if (dmm_is_available()) - ret = drm_debugfs_create_files(omap_dmm_debugfs_list, - ARRAY_SIZE(omap_dmm_debugfs_list), - minor->debugfs_root, minor); - - if (ret) { - dev_err(dev->dev, "could not install omap_dmm_debugfs_list\n"); - return ret; - } - - return ret; + drm_debugfs_create_files(omap_dmm_debugfs_list, + ARRAY_SIZE(omap_dmm_debugfs_list), + minor->debugfs_root, minor); } #endif diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h index 7c4b66efcaa7..8a1fac680138 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.h +++ b/drivers/gpu/drm/omapdrm/omap_drv.h @@ -82,6 +82,6 @@ struct omap_drm_private { }; -int omap_debugfs_init(struct drm_minor *minor); +void omap_debugfs_init(struct drm_minor *minor); #endif /* __OMAPDRM_DRV_H__ */ -- 2.25.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-27 12:03 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-27 12:02 [PATCH 00/21] drm: subsytem-wide debugfs functions refactor Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:02 ` [PATCH 01/21] drm/debugfs: remove checks for return value of drm_debugfs functions Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:02 ` [PATCH 02/21] drm: convert the drm_driver.debugfs_init() hook to return void Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:23 ` Greg KH 2020-02-27 12:23 ` Greg KH 2020-02-27 12:29 ` Wambui Karuga 2020-02-27 12:29 ` Wambui Karuga 2020-02-27 12:34 ` Greg KH 2020-02-27 12:34 ` Greg KH 2020-02-27 12:02 ` [PATCH 03/21] drm: convert drm_debugfs functions " Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:02 ` [PATCH 04/21] drm/vram-helper: make drm_vram_mm_debugfs_init() " Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-28 8:03 ` Thomas Zimmermann 2020-02-28 8:03 ` Thomas Zimmermann 2020-02-27 12:02 ` [PATCH 05/21] drm/vc4: remove check of return value of drm_debugfs functions Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:02 ` [PATCH 06/21] drm/arc: make arcpgu_debugfs_init return void Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 14:43 ` Alexey Brodkin 2020-02-27 14:43 ` Alexey Brodkin 2020-02-27 12:02 ` [PATCH 07/21] drm/arm: make hdlcd_debugfs_init() " Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 14:53 ` Liviu Dudau 2020-02-27 14:53 ` Liviu Dudau 2020-02-27 12:02 ` [PATCH 08/21] drm/etnaviv: remove check for return value of drm_debugfs function Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 13:36 ` Lucas Stach 2020-02-27 13:36 ` Lucas Stach 2020-02-27 12:02 ` [PATCH 09/21] drm/nouveau: remove checks for return value of debugfs functions Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga [not found] ` <20200227120232.19413-1-wambui.karugax-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-02-27 12:02 ` [PATCH 10/21] drm/tegra: remove checks for debugfs functions return value Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga [not found] ` <20200227120232.19413-11-wambui.karugax-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-03-11 14:37 ` Thierry Reding 2020-03-11 14:37 ` Thierry Reding 2020-03-11 14:37 ` Thierry Reding 2020-03-11 14:54 ` Wambui Karuga 2020-03-11 14:54 ` Wambui Karuga 2020-03-11 14:54 ` Wambui Karuga 2020-03-11 23:24 ` Thierry Reding 2020-03-11 23:24 ` Thierry Reding 2020-03-11 23:24 ` Thierry Reding 2020-03-16 8:33 ` Daniel Vetter 2020-03-16 8:33 ` Daniel Vetter 2020-02-27 12:02 ` [PATCH 11/21] drm/v3d: make v3d_debugfs_init return void Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:02 ` [PATCH 12/21] drm/msm: remove checks for return value of drm_debugfs functions Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 14:45 ` Daniel Vetter 2020-02-27 14:45 ` Daniel Vetter 2020-02-28 7:24 ` kbuild test robot 2020-02-28 7:24 ` kbuild test robot 2020-02-28 7:24 ` kbuild test robot 2020-02-27 12:02 ` Wambui Karuga [this message] 2020-02-27 12:02 ` [PATCH 13/21] drm/omapdrm: " Wambui Karuga 2020-02-27 12:02 ` [PATCH 14/21] drm/pl111: make pl111_debugfs_init return void Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:02 ` [PATCH 15/21] drm/sti: remove use drm_debugfs functions as return value Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 14:51 ` Daniel Vetter 2020-02-27 14:51 ` Daniel Vetter 2020-02-27 12:02 ` [PATCH 16/21] drm/i915: make *_debugfs_register() functions return void Wambui Karuga 2020-02-27 12:02 ` [Intel-gfx] " Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 13:08 ` Jani Nikula 2020-02-27 13:08 ` [Intel-gfx] " Jani Nikula 2020-02-27 13:08 ` Jani Nikula 2020-02-27 12:02 ` [PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:12 ` Jyri Sarha 2020-02-27 12:12 ` Jyri Sarha 2020-02-27 12:23 ` Wambui Karuga 2020-02-27 12:23 ` Wambui Karuga 2020-02-27 12:02 ` [PATCH 18/21] drm/virtio: make virtio_gpu_debugfs() return void Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:02 ` [PATCH 19/21] drm/mipi_dbi: make midi_dbi_debugfs_init() " Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:02 ` [PATCH 20/21] drm/qxl: have debugfs functions " Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 12:02 ` [PATCH 21/21] drm/arm: have malidp_debufs_init() " Wambui Karuga 2020-02-27 12:02 ` Wambui Karuga 2020-02-27 14:53 ` Liviu Dudau 2020-02-27 14:53 ` Liviu Dudau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200227120232.19413-14-wambui.karugax@gmail.com \ --to=wambui.karugax@gmail.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.