All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wambui Karuga <wambui.karugax@gmail.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: Wambui Karuga <wambui.karugax@gmail.com>,
	daniel@ffwll.ch, airlied@linux.ie,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions.
Date: Thu, 27 Feb 2020 15:23:31 +0300 (EAT)	[thread overview]
Message-ID: <alpine.LNX.2.21.99999.375.2002271516120.19554@wambui> (raw)
In-Reply-To: <614d42f2-881e-6e4e-f3c4-c247a86d9262@ti.com>



On Thu, 27 Feb 2020, Jyri Sarha wrote:

> On 27/02/2020 14:02, Wambui Karuga wrote:
>> Since 987d65d01356 (drm: debugfs: make
>> drm_debugfs_create_files() never fail), drm_debugfs_create_files() never
>> fails. Therefore, remove the check and error handling of the return
>> value of drm_debugfs_create_files() as it is not needed in
>> tilcdc_debugfs_init().
>>
>> Also remove local variables that are not used after the changes, and
>> declare tilcdc_debugfs_init() as void.
>>
>> Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
>
>
> Ok, so this is a part of a bigger series.
>
Yes, this was converted to a series after initial feedback. Thanks for 
your review

wambui karuga.
> Acked-by: Jyri Sarha <jsarha@ti.com>
>
> I assume the series will be merged as one without my involvement. Please
> let me know if that is not the case.
>
> BR,
> Jyri
>
>> ---
>>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 17 ++++-------------
>>  1 file changed, 4 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> index 0791a0200cc3..78c1877d13a8 100644
>> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> @@ -478,26 +478,17 @@ static struct drm_info_list tilcdc_debugfs_list[] = {
>>  		{ "mm",   tilcdc_mm_show,   0 },
>>  };
>>
>> -static int tilcdc_debugfs_init(struct drm_minor *minor)
>> +static void tilcdc_debugfs_init(struct drm_minor *minor)
>>  {
>> -	struct drm_device *dev = minor->dev;
>>  	struct tilcdc_module *mod;
>> -	int ret;
>>
>> -	ret = drm_debugfs_create_files(tilcdc_debugfs_list,
>> -			ARRAY_SIZE(tilcdc_debugfs_list),
>> -			minor->debugfs_root, minor);
>> +	drm_debugfs_create_files(tilcdc_debugfs_list,
>> +				 ARRAY_SIZE(tilcdc_debugfs_list),
>> +				 minor->debugfs_root, minor);
>>
>>  	list_for_each_entry(mod, &module_list, list)
>>  		if (mod->funcs->debugfs_init)
>>  			mod->funcs->debugfs_init(mod, minor);
>> -
>> -	if (ret) {
>> -		dev_err(dev->dev, "could not install tilcdc_debugfs_list\n");
>> -		return ret;
>> -	}
>> -
>> -	return ret;
>>  }
>>  #endif
>>
>>
>
>
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>

WARNING: multiple messages have this Message-ID (diff)
From: Wambui Karuga <wambui.karugax@gmail.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: airlied@linux.ie, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Wambui Karuga <wambui.karugax@gmail.com>
Subject: Re: [PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions.
Date: Thu, 27 Feb 2020 15:23:31 +0300 (EAT)	[thread overview]
Message-ID: <alpine.LNX.2.21.99999.375.2002271516120.19554@wambui> (raw)
In-Reply-To: <614d42f2-881e-6e4e-f3c4-c247a86d9262@ti.com>



On Thu, 27 Feb 2020, Jyri Sarha wrote:

> On 27/02/2020 14:02, Wambui Karuga wrote:
>> Since 987d65d01356 (drm: debugfs: make
>> drm_debugfs_create_files() never fail), drm_debugfs_create_files() never
>> fails. Therefore, remove the check and error handling of the return
>> value of drm_debugfs_create_files() as it is not needed in
>> tilcdc_debugfs_init().
>>
>> Also remove local variables that are not used after the changes, and
>> declare tilcdc_debugfs_init() as void.
>>
>> Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
>
>
> Ok, so this is a part of a bigger series.
>
Yes, this was converted to a series after initial feedback. Thanks for 
your review

wambui karuga.
> Acked-by: Jyri Sarha <jsarha@ti.com>
>
> I assume the series will be merged as one without my involvement. Please
> let me know if that is not the case.
>
> BR,
> Jyri
>
>> ---
>>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 17 ++++-------------
>>  1 file changed, 4 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> index 0791a0200cc3..78c1877d13a8 100644
>> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> @@ -478,26 +478,17 @@ static struct drm_info_list tilcdc_debugfs_list[] = {
>>  		{ "mm",   tilcdc_mm_show,   0 },
>>  };
>>
>> -static int tilcdc_debugfs_init(struct drm_minor *minor)
>> +static void tilcdc_debugfs_init(struct drm_minor *minor)
>>  {
>> -	struct drm_device *dev = minor->dev;
>>  	struct tilcdc_module *mod;
>> -	int ret;
>>
>> -	ret = drm_debugfs_create_files(tilcdc_debugfs_list,
>> -			ARRAY_SIZE(tilcdc_debugfs_list),
>> -			minor->debugfs_root, minor);
>> +	drm_debugfs_create_files(tilcdc_debugfs_list,
>> +				 ARRAY_SIZE(tilcdc_debugfs_list),
>> +				 minor->debugfs_root, minor);
>>
>>  	list_for_each_entry(mod, &module_list, list)
>>  		if (mod->funcs->debugfs_init)
>>  			mod->funcs->debugfs_init(mod, minor);
>> -
>> -	if (ret) {
>> -		dev_err(dev->dev, "could not install tilcdc_debugfs_list\n");
>> -		return ret;
>> -	}
>> -
>> -	return ret;
>>  }
>>  #endif
>>
>>
>
>
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-02-27 12:24 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 12:02 [PATCH 00/21] drm: subsytem-wide debugfs functions refactor Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 01/21] drm/debugfs: remove checks for return value of drm_debugfs functions Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 02/21] drm: convert the drm_driver.debugfs_init() hook to return void Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:23   ` Greg KH
2020-02-27 12:23     ` Greg KH
2020-02-27 12:29     ` Wambui Karuga
2020-02-27 12:29       ` Wambui Karuga
2020-02-27 12:34       ` Greg KH
2020-02-27 12:34         ` Greg KH
2020-02-27 12:02 ` [PATCH 03/21] drm: convert drm_debugfs functions " Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 04/21] drm/vram-helper: make drm_vram_mm_debugfs_init() " Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-28  8:03   ` Thomas Zimmermann
2020-02-28  8:03     ` Thomas Zimmermann
2020-02-27 12:02 ` [PATCH 05/21] drm/vc4: remove check of return value of drm_debugfs functions Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 06/21] drm/arc: make arcpgu_debugfs_init return void Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 14:43   ` Alexey Brodkin
2020-02-27 14:43     ` Alexey Brodkin
2020-02-27 12:02 ` [PATCH 07/21] drm/arm: make hdlcd_debugfs_init() " Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 14:53   ` Liviu Dudau
2020-02-27 14:53     ` Liviu Dudau
2020-02-27 12:02 ` [PATCH 08/21] drm/etnaviv: remove check for return value of drm_debugfs function Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 13:36   ` Lucas Stach
2020-02-27 13:36     ` Lucas Stach
2020-02-27 12:02 ` [PATCH 09/21] drm/nouveau: remove checks for return value of debugfs functions Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
     [not found] ` <20200227120232.19413-1-wambui.karugax-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-27 12:02   ` [PATCH 10/21] drm/tegra: remove checks for debugfs functions return value Wambui Karuga
2020-02-27 12:02     ` Wambui Karuga
2020-02-27 12:02     ` Wambui Karuga
     [not found]     ` <20200227120232.19413-11-wambui.karugax-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-11 14:37       ` Thierry Reding
2020-03-11 14:37         ` Thierry Reding
2020-03-11 14:37         ` Thierry Reding
2020-03-11 14:54         ` Wambui Karuga
2020-03-11 14:54           ` Wambui Karuga
2020-03-11 14:54           ` Wambui Karuga
2020-03-11 23:24           ` Thierry Reding
2020-03-11 23:24             ` Thierry Reding
2020-03-11 23:24             ` Thierry Reding
2020-03-16  8:33             ` Daniel Vetter
2020-03-16  8:33               ` Daniel Vetter
2020-02-27 12:02 ` [PATCH 11/21] drm/v3d: make v3d_debugfs_init return void Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 12/21] drm/msm: remove checks for return value of drm_debugfs functions Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 14:45   ` Daniel Vetter
2020-02-27 14:45     ` Daniel Vetter
2020-02-28  7:24   ` kbuild test robot
2020-02-28  7:24     ` kbuild test robot
2020-02-28  7:24     ` kbuild test robot
2020-02-27 12:02 ` [PATCH 13/21] drm/omapdrm: " Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 14/21] drm/pl111: make pl111_debugfs_init return void Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 15/21] drm/sti: remove use drm_debugfs functions as return value Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 14:51   ` Daniel Vetter
2020-02-27 14:51     ` Daniel Vetter
2020-02-27 12:02 ` [PATCH 16/21] drm/i915: make *_debugfs_register() functions return void Wambui Karuga
2020-02-27 12:02   ` [Intel-gfx] " Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 13:08   ` Jani Nikula
2020-02-27 13:08     ` [Intel-gfx] " Jani Nikula
2020-02-27 13:08     ` Jani Nikula
2020-02-27 12:02 ` [PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:12   ` Jyri Sarha
2020-02-27 12:12     ` Jyri Sarha
2020-02-27 12:23     ` Wambui Karuga [this message]
2020-02-27 12:23       ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 18/21] drm/virtio: make virtio_gpu_debugfs() return void Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 19/21] drm/mipi_dbi: make midi_dbi_debugfs_init() " Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 20/21] drm/qxl: have debugfs functions " Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 21/21] drm/arm: have malidp_debufs_init() " Wambui Karuga
2020-02-27 12:02   ` Wambui Karuga
2020-02-27 14:53   ` Liviu Dudau
2020-02-27 14:53     ` Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.21.99999.375.2002271516120.19554@wambui \
    --to=wambui.karugax@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jsarha@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.