From: Roman Gushchin <guro@fb.com>
To: Marco Ballesio <balejs@google.com>
Cc: <tj@kernel.org>, <cgroups@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lizefan@huawei.com>,
<hannes@cmpxchg.org>, <corbet@lwn.net>, <rjw@rjwysocki.net>,
<pavel@ucw.cz>, <len.brown@intel.com>,
<linux-doc@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<minchan@google.com>, <surenb@google.com>, <dancol@google.com>
Subject: Re: [PATCH] cgroup-v1: freezer: optionally killable freezer
Date: Mon, 2 Mar 2020 08:53:30 -0800 [thread overview]
Message-ID: <20200302165330.GA505299@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <20200301162003.GA186618@google.com>
On Sun, Mar 01, 2020 at 08:20:03AM -0800, Marco Ballesio wrote:
> On Sat, Feb 29, 2020 at 10:43:00AM -0800, Roman Gushchin wrote:
> > On Fri, Feb 28, 2020 at 04:51:31PM -0800, Marco Ballesio wrote:
> > > Hi all,
> > >
> > > did anyone have time to look into my proposal and, in case, are there
> > > any suggestions, ideas or comments about it?
> >
> > Hello, Marco!
> >
> > I'm sorry, somehow I missed the original letter.
> >
> > In general the cgroup v1 interface is considered frozen. Are there any particular
> > reasons why you want to extend the v1 freezer rather than use the v2 version of it?
> >
> > You don't even need to fully convert to cgroup v2 in order to do it, some v1
> > controllers can still be used.
> >
> > Thanks!
> >
> > Roman
>
> Hi Roman,
>
> When compared with backports of v2 features and their dependency chains, this
> patch would be easier to carry in Android common. The potential is to have
> killability for frozen processes on hw currently in use.
I see...
The implementation looks good to me, but I really not sure if adding new control files
to cgroup v1 is a good idea at this point. Are there any plans in the Android world
to move forward to cgroup v2? If not, why not?
If there are any specific issues/dependencies, let's discuss and resolve them.
Thanks!
Roman
WARNING: multiple messages have this Message-ID (diff)
From: Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>
To: Marco Ballesio <balejs-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
corbet-T1hC0tSOHrs@public.gmane.org,
rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org,
pavel-+ZI9xUNit7I@public.gmane.org,
len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
minchan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
dancol-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] cgroup-v1: freezer: optionally killable freezer
Date: Mon, 2 Mar 2020 08:53:30 -0800 [thread overview]
Message-ID: <20200302165330.GA505299@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <20200301162003.GA186618-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On Sun, Mar 01, 2020 at 08:20:03AM -0800, Marco Ballesio wrote:
> On Sat, Feb 29, 2020 at 10:43:00AM -0800, Roman Gushchin wrote:
> > On Fri, Feb 28, 2020 at 04:51:31PM -0800, Marco Ballesio wrote:
> > > Hi all,
> > >
> > > did anyone have time to look into my proposal and, in case, are there
> > > any suggestions, ideas or comments about it?
> >
> > Hello, Marco!
> >
> > I'm sorry, somehow I missed the original letter.
> >
> > In general the cgroup v1 interface is considered frozen. Are there any particular
> > reasons why you want to extend the v1 freezer rather than use the v2 version of it?
> >
> > You don't even need to fully convert to cgroup v2 in order to do it, some v1
> > controllers can still be used.
> >
> > Thanks!
> >
> > Roman
>
> Hi Roman,
>
> When compared with backports of v2 features and their dependency chains, this
> patch would be easier to carry in Android common. The potential is to have
> killability for frozen processes on hw currently in use.
I see...
The implementation looks good to me, but I really not sure if adding new control files
to cgroup v1 is a good idea at this point. Are there any plans in the Android world
to move forward to cgroup v2? If not, why not?
If there are any specific issues/dependencies, let's discuss and resolve them.
Thanks!
Roman
next prev parent reply other threads:[~2020-03-02 16:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 18:32 [PATCH] cgroup-v1: freezer: optionally killable freezer Marco Ballesio
2020-02-19 18:32 ` Marco Ballesio
2020-02-29 0:51 ` Marco Ballesio
2020-02-29 0:51 ` Marco Ballesio
2020-02-29 18:43 ` Roman Gushchin
2020-02-29 18:43 ` Roman Gushchin
2020-03-01 16:20 ` Marco Ballesio
2020-03-01 16:20 ` Marco Ballesio
2020-03-02 16:53 ` Roman Gushchin [this message]
2020-03-02 16:53 ` Roman Gushchin
2020-03-02 17:46 ` Suren Baghdasaryan
2020-03-02 18:27 ` Roman Gushchin
2020-03-02 18:27 ` Roman Gushchin
2020-03-03 13:48 ` Tejun Heo
2020-03-03 13:48 ` Tejun Heo
2020-03-11 17:46 ` Daniel Colascione
2020-03-20 20:10 ` Marco Ballesio
2020-03-24 18:26 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302165330.GA505299@carbon.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=balejs@google.com \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dancol@google.com \
--cc=hannes@cmpxchg.org \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=minchan@google.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=surenb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.