Re: [PATCH] cgroup-v1: freezer: optionally killable freezer

From: Roman Gushchin <guro@fb.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Marco Ballesio <balejs@google.com>, Tejun Heo <tj@kernel.org>,
	cgroups mailinglist <cgroups@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Li Zefan <lizefan@huawei.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Jonathan Corbet <corbet@lwn.net>, <rjw@rjwysocki.net>,
	<pavel@ucw.cz>, <len.brown@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	Minchan Kim <minchan@google.com>,
	Daniel Colascione <dancol@google.com>
Subject: Re: [PATCH] cgroup-v1: freezer: optionally killable freezer
Date: Mon, 2 Mar 2020 10:27:09 -0800	[thread overview]
Message-ID: <20200302182709.GA527458@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAJuCfpEk4gz9YKVuRBW4E-Up_LSGWCSpyJft4y+rOjyPSa08Zg@mail.gmail.com>

On Mon, Mar 02, 2020 at 09:46:36AM -0800, Suren Baghdasaryan wrote:
> On Mon, Mar 2, 2020 at 8:53 AM Roman Gushchin <guro@fb.com> wrote:
> >
> > On Sun, Mar 01, 2020 at 08:20:03AM -0800, Marco Ballesio wrote:
> > > On Sat, Feb 29, 2020 at 10:43:00AM -0800, Roman Gushchin wrote:
> > > > On Fri, Feb 28, 2020 at 04:51:31PM -0800, Marco Ballesio wrote:
> > > > > Hi all,
> > > > >
> > > > > did anyone have time to look into my proposal and, in case, are there
> > > > > any suggestions, ideas or comments about it?
> > > >
> > > > Hello, Marco!
> > > >
> > > > I'm sorry, somehow I missed the original letter.
> > > >
> > > > In general the cgroup v1 interface is considered frozen. Are there any particular
> > > > reasons why you want to extend the v1 freezer rather than use the v2 version of it?
> > > >
> > > > You don't even need to fully convert to cgroup v2 in order to do it, some v1
> > > > controllers can still be used.
> > > >
> > > > Thanks!
> > > >
> > > > Roman
> > >
> > > Hi Roman,
> > >
> > > When compared with backports of v2 features and their dependency chains, this
> > > patch would be easier to carry in Android common. The potential is to have
> > > killability for frozen processes on hw currently in use.
> >
> 
> Hi Roman,
> 
> > I see...
> >
> > The implementation looks good to me, but I really not sure if adding new control files
> > to cgroup v1 is a good idea at this point. Are there any plans in the Android world
> > to move forward to cgroup v2? If not, why not?
> 
> There are plans to prototype that and gradually move from cgroups v1
> to v2 at least for some cgroup controllers (the ones that can use
> unified hierarchy). Creating an additional per-process cgroup v2
> hierarchy only for freezer would be a high price to pay today. In the
> future when we migrate some controllers to v2 the price will be
> amortized and we will probably be able to do that.

I see... Thanks for the explanation, Suren!

Overall the idea of extending the frozen v1 interface looks dubious to me.
Especially if it's only required during the transition to v2.

But of course the decision is on maintainers.

Thanks!