* [PULL 0/2] virtiofs queue @ 2020-03-03 15:16 Dr. David Alan Gilbert (git) 2020-03-03 15:16 ` [PULL 1/2] virtiofsd: passthrough_ll: cleanup getxattr/listxattr Dr. David Alan Gilbert (git) ` (2 more replies) 0 siblings, 3 replies; 12+ messages in thread From: Dr. David Alan Gilbert (git) @ 2020-03-03 15:16 UTC (permalink / raw) To: qemu-devel From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> The following changes since commit 104933c4a973960dea605b06fcd5d0d478255d77: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2020-03-03 12:03:59 +0000) are available in the Git repository at: https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20200303 for you to fetch changes up to bdfd66788349acc43cd3f1298718ad491663cfcc: virtiofsd: Fix xattr operations (2020-03-03 15:13:24 +0000) ---------------------------------------------------------------- Virtiofsd pull 2020-03-03 xattr fixes from Misono. ---------------------------------------------------------------- Misono Tomohiro (2): virtiofsd: passthrough_ll: cleanup getxattr/listxattr virtiofsd: Fix xattr operations tools/virtiofsd/fuse_virtio.c | 13 ++++ tools/virtiofsd/passthrough_ll.c | 139 ++++++++++++++++++++------------------- tools/virtiofsd/seccomp.c | 6 ++ 3 files changed, 89 insertions(+), 69 deletions(-) ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PULL 1/2] virtiofsd: passthrough_ll: cleanup getxattr/listxattr 2020-03-03 15:16 [PULL 0/2] virtiofs queue Dr. David Alan Gilbert (git) @ 2020-03-03 15:16 ` Dr. David Alan Gilbert (git) 2020-03-03 15:16 ` [PULL 2/2] virtiofsd: Fix xattr operations Dr. David Alan Gilbert (git) 2020-03-03 17:23 ` [PULL 0/2] virtiofs queue Peter Maydell 2 siblings, 0 replies; 12+ messages in thread From: Dr. David Alan Gilbert (git) @ 2020-03-03 15:16 UTC (permalink / raw) To: qemu-devel From: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> This is a cleanup patch to simplify the following xattr fix and there is no functional changes. - Move memory allocation to head of the function - Unify fgetxattr/flistxattr call for both size == 0 and size != 0 case - Remove redundant lo_inode_put call in error path (Note: second call is ignored now since @inode is already NULL) Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> Message-Id: <20200227055927.24566-2-misono.tomohiro@jp.fujitsu.com> Acked-by: Vivek Goyal <vgoyal@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> --- tools/virtiofsd/passthrough_ll.c | 54 +++++++++++++------------------- 1 file changed, 22 insertions(+), 32 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index 02ff01fad0..4690a97947 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -2195,34 +2195,30 @@ static void lo_getxattr(fuse_req_t req, fuse_ino_t ino, const char *name, goto out; } + if (size) { + value = malloc(size); + if (!value) { + goto out_err; + } + } + sprintf(procname, "%i", inode->fd); fd = openat(lo->proc_self_fd, procname, O_RDONLY); if (fd < 0) { goto out_err; } + ret = fgetxattr(fd, name, value, size); + if (ret == -1) { + goto out_err; + } if (size) { - value = malloc(size); - if (!value) { - goto out_err; - } - - ret = fgetxattr(fd, name, value, size); - if (ret == -1) { - goto out_err; - } saverr = 0; if (ret == 0) { goto out; } - fuse_reply_buf(req, value, ret); } else { - ret = fgetxattr(fd, name, NULL, 0); - if (ret == -1) { - goto out_err; - } - fuse_reply_xattr(req, ret); } out_free: @@ -2238,7 +2234,6 @@ out_free: out_err: saverr = errno; out: - lo_inode_put(lo, &inode); fuse_reply_err(req, saverr); goto out_free; } @@ -2273,34 +2268,30 @@ static void lo_listxattr(fuse_req_t req, fuse_ino_t ino, size_t size) goto out; } + if (size) { + value = malloc(size); + if (!value) { + goto out_err; + } + } + sprintf(procname, "%i", inode->fd); fd = openat(lo->proc_self_fd, procname, O_RDONLY); if (fd < 0) { goto out_err; } + ret = flistxattr(fd, value, size); + if (ret == -1) { + goto out_err; + } if (size) { - value = malloc(size); - if (!value) { - goto out_err; - } - - ret = flistxattr(fd, value, size); - if (ret == -1) { - goto out_err; - } saverr = 0; if (ret == 0) { goto out; } - fuse_reply_buf(req, value, ret); } else { - ret = flistxattr(fd, NULL, 0); - if (ret == -1) { - goto out_err; - } - fuse_reply_xattr(req, ret); } out_free: @@ -2316,7 +2307,6 @@ out_free: out_err: saverr = errno; out: - lo_inode_put(lo, &inode); fuse_reply_err(req, saverr); goto out_free; } -- 2.24.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PULL 2/2] virtiofsd: Fix xattr operations 2020-03-03 15:16 [PULL 0/2] virtiofs queue Dr. David Alan Gilbert (git) 2020-03-03 15:16 ` [PULL 1/2] virtiofsd: passthrough_ll: cleanup getxattr/listxattr Dr. David Alan Gilbert (git) @ 2020-03-03 15:16 ` Dr. David Alan Gilbert (git) 2020-03-03 17:23 ` [PULL 0/2] virtiofs queue Peter Maydell 2 siblings, 0 replies; 12+ messages in thread From: Dr. David Alan Gilbert (git) @ 2020-03-03 15:16 UTC (permalink / raw) To: qemu-devel From: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> Current virtiofsd has problems about xattr operations and they does not work properly for directory/symlink/special file. The fundamental cause is that virtiofsd uses openat() + f...xattr() systemcalls for xattr operation but we should not open symlink/special file in the daemon. Therefore the function is restricted. Fix this problem by: 1. during setup of each thread, call unshare(CLONE_FS) 2. in xattr operations (i.e. lo_getxattr), if inode is not a regular file or directory, use fchdir(proc_loot_fd) + ...xattr() + fchdir(root.fd) instead of openat() + f...xattr() (Note: for a regular file/directory openat() + f...xattr() is still used for performance reason) With this patch, xfstests generic/062 passes on virtiofs. This fix is suggested by Miklos Szeredi and Stefan Hajnoczi. The original discussion can be found here: https://www.redhat.com/archives/virtio-fs/2019-October/msg00046.html Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> Message-Id: <20200227055927.24566-3-misono.tomohiro@jp.fujitsu.com> Acked-by: Vivek Goyal <vgoyal@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> --- tools/virtiofsd/fuse_virtio.c | 13 ++++ tools/virtiofsd/passthrough_ll.c | 105 +++++++++++++++++-------------- tools/virtiofsd/seccomp.c | 6 ++ 3 files changed, 77 insertions(+), 47 deletions(-) diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index dd1c605dbf..3b6d16a041 100644 --- a/tools/virtiofsd/fuse_virtio.c +++ b/tools/virtiofsd/fuse_virtio.c @@ -426,6 +426,8 @@ err: return ret; } +static __thread bool clone_fs_called; + /* Process one FVRequest in a thread pool */ static void fv_queue_worker(gpointer data, gpointer user_data) { @@ -441,6 +443,17 @@ static void fv_queue_worker(gpointer data, gpointer user_data) assert(se->bufsize > sizeof(struct fuse_in_header)); + if (!clone_fs_called) { + int ret; + + /* unshare FS for xattr operation */ + ret = unshare(CLONE_FS); + /* should not fail */ + assert(ret == 0); + + clone_fs_called = true; + } + /* * An element contains one request and the space to send our response * They're spread over multiple descriptors in a scatter/gather set diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index 4690a97947..4f259aac70 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -123,7 +123,7 @@ struct lo_inode { pthread_mutex_t plock_mutex; GHashTable *posix_locks; /* protected by lo_inode->plock_mutex */ - bool is_symlink; + mode_t filetype; }; struct lo_cred { @@ -695,7 +695,7 @@ static int utimensat_empty(struct lo_data *lo, struct lo_inode *inode, struct lo_inode *parent; char path[PATH_MAX]; - if (inode->is_symlink) { + if (S_ISLNK(inode->filetype)) { res = utimensat(inode->fd, "", tv, AT_EMPTY_PATH); if (res == -1 && errno == EINVAL) { /* Sorry, no race free way to set times on symlink. */ @@ -928,7 +928,8 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent, const char *name, goto out_err; } - inode->is_symlink = S_ISLNK(e->attr.st_mode); + /* cache only filetype */ + inode->filetype = (e->attr.st_mode & S_IFMT); /* * One for the caller and one for nlookup (released in @@ -1135,7 +1136,7 @@ static int linkat_empty_nofollow(struct lo_data *lo, struct lo_inode *inode, struct lo_inode *parent; char path[PATH_MAX]; - if (inode->is_symlink) { + if (S_ISLNK(inode->filetype)) { res = linkat(inode->fd, "", dfd, name, AT_EMPTY_PATH); if (res == -1 && (errno == ENOENT || errno == EINVAL)) { /* Sorry, no race free way to hard-link a symlink. */ @@ -2189,12 +2190,6 @@ static void lo_getxattr(fuse_req_t req, fuse_ino_t ino, const char *name, fuse_log(FUSE_LOG_DEBUG, "lo_getxattr(ino=%" PRIu64 ", name=%s size=%zd)\n", ino, name, size); - if (inode->is_symlink) { - /* Sorry, no race free way to getxattr on symlink. */ - saverr = EPERM; - goto out; - } - if (size) { value = malloc(size); if (!value) { @@ -2203,12 +2198,25 @@ static void lo_getxattr(fuse_req_t req, fuse_ino_t ino, const char *name, } sprintf(procname, "%i", inode->fd); - fd = openat(lo->proc_self_fd, procname, O_RDONLY); - if (fd < 0) { - goto out_err; + /* + * It is not safe to open() non-regular/non-dir files in file server + * unless O_PATH is used, so use that method for regular files/dir + * only (as it seems giving less performance overhead). + * Otherwise, call fchdir() to avoid open(). + */ + if (S_ISREG(inode->filetype) || S_ISDIR(inode->filetype)) { + fd = openat(lo->proc_self_fd, procname, O_RDONLY); + if (fd < 0) { + goto out_err; + } + ret = fgetxattr(fd, name, value, size); + } else { + /* fchdir should not fail here */ + assert(fchdir(lo->proc_self_fd) == 0); + ret = getxattr(procname, name, value, size); + assert(fchdir(lo->root.fd) == 0); } - ret = fgetxattr(fd, name, value, size); if (ret == -1) { goto out_err; } @@ -2262,12 +2270,6 @@ static void lo_listxattr(fuse_req_t req, fuse_ino_t ino, size_t size) fuse_log(FUSE_LOG_DEBUG, "lo_listxattr(ino=%" PRIu64 ", size=%zd)\n", ino, size); - if (inode->is_symlink) { - /* Sorry, no race free way to listxattr on symlink. */ - saverr = EPERM; - goto out; - } - if (size) { value = malloc(size); if (!value) { @@ -2276,12 +2278,19 @@ static void lo_listxattr(fuse_req_t req, fuse_ino_t ino, size_t size) } sprintf(procname, "%i", inode->fd); - fd = openat(lo->proc_self_fd, procname, O_RDONLY); - if (fd < 0) { - goto out_err; + if (S_ISREG(inode->filetype) || S_ISDIR(inode->filetype)) { + fd = openat(lo->proc_self_fd, procname, O_RDONLY); + if (fd < 0) { + goto out_err; + } + ret = flistxattr(fd, value, size); + } else { + /* fchdir should not fail here */ + assert(fchdir(lo->proc_self_fd) == 0); + ret = listxattr(procname, value, size); + assert(fchdir(lo->root.fd) == 0); } - ret = flistxattr(fd, value, size); if (ret == -1) { goto out_err; } @@ -2335,20 +2344,21 @@ static void lo_setxattr(fuse_req_t req, fuse_ino_t ino, const char *name, fuse_log(FUSE_LOG_DEBUG, "lo_setxattr(ino=%" PRIu64 ", name=%s value=%s size=%zd)\n", ino, name, value, size); - if (inode->is_symlink) { - /* Sorry, no race free way to setxattr on symlink. */ - saverr = EPERM; - goto out; - } - sprintf(procname, "%i", inode->fd); - fd = openat(lo->proc_self_fd, procname, O_RDWR); - if (fd < 0) { - saverr = errno; - goto out; + if (S_ISREG(inode->filetype) || S_ISDIR(inode->filetype)) { + fd = openat(lo->proc_self_fd, procname, O_RDONLY); + if (fd < 0) { + saverr = errno; + goto out; + } + ret = fsetxattr(fd, name, value, size, flags); + } else { + /* fchdir should not fail here */ + assert(fchdir(lo->proc_self_fd) == 0); + ret = setxattr(procname, name, value, size, flags); + assert(fchdir(lo->root.fd) == 0); } - ret = fsetxattr(fd, name, value, size, flags); saverr = ret == -1 ? errno : 0; out: @@ -2383,20 +2393,21 @@ static void lo_removexattr(fuse_req_t req, fuse_ino_t ino, const char *name) fuse_log(FUSE_LOG_DEBUG, "lo_removexattr(ino=%" PRIu64 ", name=%s)\n", ino, name); - if (inode->is_symlink) { - /* Sorry, no race free way to setxattr on symlink. */ - saverr = EPERM; - goto out; - } - sprintf(procname, "%i", inode->fd); - fd = openat(lo->proc_self_fd, procname, O_RDWR); - if (fd < 0) { - saverr = errno; - goto out; + if (S_ISREG(inode->filetype) || S_ISDIR(inode->filetype)) { + fd = openat(lo->proc_self_fd, procname, O_RDONLY); + if (fd < 0) { + saverr = errno; + goto out; + } + ret = fremovexattr(fd, name); + } else { + /* fchdir should not fail here */ + assert(fchdir(lo->proc_self_fd) == 0); + ret = removexattr(procname, name); + assert(fchdir(lo->root.fd) == 0); } - ret = fremovexattr(fd, name); saverr = ret == -1 ? errno : 0; out: @@ -2796,7 +2807,7 @@ static void setup_root(struct lo_data *lo, struct lo_inode *root) exit(1); } - root->is_symlink = false; + root->filetype = S_IFDIR; root->fd = fd; root->key.ino = stat.st_ino; root->key.dev = stat.st_dev; diff --git a/tools/virtiofsd/seccomp.c b/tools/virtiofsd/seccomp.c index 2d9d4a7ec0..bd9e7b083c 100644 --- a/tools/virtiofsd/seccomp.c +++ b/tools/virtiofsd/seccomp.c @@ -41,6 +41,7 @@ static const int syscall_whitelist[] = { SCMP_SYS(exit), SCMP_SYS(exit_group), SCMP_SYS(fallocate), + SCMP_SYS(fchdir), SCMP_SYS(fchmodat), SCMP_SYS(fchownat), SCMP_SYS(fcntl), @@ -62,7 +63,9 @@ static const int syscall_whitelist[] = { SCMP_SYS(getpid), SCMP_SYS(gettid), SCMP_SYS(gettimeofday), + SCMP_SYS(getxattr), SCMP_SYS(linkat), + SCMP_SYS(listxattr), SCMP_SYS(lseek), SCMP_SYS(madvise), SCMP_SYS(mkdirat), @@ -85,6 +88,7 @@ static const int syscall_whitelist[] = { SCMP_SYS(recvmsg), SCMP_SYS(renameat), SCMP_SYS(renameat2), + SCMP_SYS(removexattr), SCMP_SYS(rt_sigaction), SCMP_SYS(rt_sigprocmask), SCMP_SYS(rt_sigreturn), @@ -98,10 +102,12 @@ static const int syscall_whitelist[] = { SCMP_SYS(setresuid32), #endif SCMP_SYS(set_robust_list), + SCMP_SYS(setxattr), SCMP_SYS(symlinkat), SCMP_SYS(time), /* Rarely needed, except on static builds */ SCMP_SYS(tgkill), SCMP_SYS(unlinkat), + SCMP_SYS(unshare), SCMP_SYS(utimensat), SCMP_SYS(write), SCMP_SYS(writev), -- 2.24.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue 2020-03-03 15:16 [PULL 0/2] virtiofs queue Dr. David Alan Gilbert (git) 2020-03-03 15:16 ` [PULL 1/2] virtiofsd: passthrough_ll: cleanup getxattr/listxattr Dr. David Alan Gilbert (git) 2020-03-03 15:16 ` [PULL 2/2] virtiofsd: Fix xattr operations Dr. David Alan Gilbert (git) @ 2020-03-03 17:23 ` Peter Maydell 2 siblings, 0 replies; 12+ messages in thread From: Peter Maydell @ 2020-03-03 17:23 UTC (permalink / raw) To: Dr. David Alan Gilbert (git); +Cc: QEMU Developers On Tue, 3 Mar 2020 at 15:17, Dr. David Alan Gilbert (git) <dgilbert@redhat.com> wrote: > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > The following changes since commit 104933c4a973960dea605b06fcd5d0d478255d77: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2020-03-03 12:03:59 +0000) > > are available in the Git repository at: > > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20200303 > > for you to fetch changes up to bdfd66788349acc43cd3f1298718ad491663cfcc: > > virtiofsd: Fix xattr operations (2020-03-03 15:13:24 +0000) > > ---------------------------------------------------------------- > Virtiofsd pull 2020-03-03 > > xattr fixes from Misono. > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PULL 0/2] virtiofs queue @ 2021-09-16 13:52 Dr. David Alan Gilbert (git) 2021-09-16 15:01 ` Peter Maydell 2021-09-20 8:50 ` Peter Maydell 0 siblings, 2 replies; 12+ messages in thread From: Dr. David Alan Gilbert (git) @ 2021-09-16 13:52 UTC (permalink / raw) To: qemu-devel, vgoyal, slp, thuth; +Cc: stefanha From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894: Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100) are available in the Git repository at: https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916 for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d: virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100) ---------------------------------------------------------------- virtiofsd pull 2021-08-16 Two minor fixes; one for performance, the other seccomp on s390x. Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> ---------------------------------------------------------------- Sergio Lopez (1): virtiofsd: Reverse req_list before processing it Thomas Huth (1): tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist tools/virtiofsd/fuse_virtio.c | 1 + tools/virtiofsd/passthrough_seccomp.c | 1 + 2 files changed, 2 insertions(+) ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue 2021-09-16 13:52 Dr. David Alan Gilbert (git) @ 2021-09-16 15:01 ` Peter Maydell 2021-09-16 15:33 ` Dr. David Alan Gilbert 2021-09-20 8:50 ` Peter Maydell 1 sibling, 1 reply; 12+ messages in thread From: Peter Maydell @ 2021-09-16 15:01 UTC (permalink / raw) To: Dr. David Alan Gilbert (git) Cc: Stefan Hajnoczi, Thomas Huth, Sergio Lopez, QEMU Developers, vgoyal On Thu, 16 Sept 2021 at 14:58, Dr. David Alan Gilbert (git) <dgilbert@redhat.com> wrote: > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894: > > Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100) > > are available in the Git repository at: > > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916 > > for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d: > > virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100) > gpg says your key has expired; what keyserver can I download an updated key from? thanks -- PMM ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue 2021-09-16 15:01 ` Peter Maydell @ 2021-09-16 15:33 ` Dr. David Alan Gilbert 2021-09-16 15:57 ` Peter Maydell 0 siblings, 1 reply; 12+ messages in thread From: Dr. David Alan Gilbert @ 2021-09-16 15:33 UTC (permalink / raw) To: Peter Maydell Cc: Stefan Hajnoczi, Thomas Huth, Sergio Lopez, QEMU Developers, vgoyal * Peter Maydell (peter.maydell@linaro.org) wrote: > On Thu, 16 Sept 2021 at 14:58, Dr. David Alan Gilbert (git) > <dgilbert@redhat.com> wrote: > > > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > > > The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894: > > > > Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100) > > > > are available in the Git repository at: > > > > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916 > > > > for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d: > > > > virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100) > > > > gpg says your key has expired; what keyserver can I download an > updated key from? I pushed an updated one to pgp.mit.edu just before I sent the pull; I can see it there (although it's a bit slow to respond). Dave > thanks > -- PMM > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue 2021-09-16 15:33 ` Dr. David Alan Gilbert @ 2021-09-16 15:57 ` Peter Maydell 2021-09-16 16:09 ` Dr. David Alan Gilbert 0 siblings, 1 reply; 12+ messages in thread From: Peter Maydell @ 2021-09-16 15:57 UTC (permalink / raw) To: Dr. David Alan Gilbert Cc: Stefan Hajnoczi, Thomas Huth, Sergio Lopez, QEMU Developers, vgoyal On Thu, 16 Sept 2021 at 16:33, Dr. David Alan Gilbert <dgilbert@redhat.com> wrote: > > * Peter Maydell (peter.maydell@linaro.org) wrote: > > On Thu, 16 Sept 2021 at 14:58, Dr. David Alan Gilbert (git) > > <dgilbert@redhat.com> wrote: > > > > > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > > > > > The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894: > > > > > > Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100) > > > > > > are available in the Git repository at: > > > > > > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916 > > > > > > for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d: > > > > > > virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100) > > > > > > > gpg says your key has expired; what keyserver can I download an > > updated key from? > > I pushed an updated one to pgp.mit.edu just before I sent the pull; > I can see it there (although it's a bit slow to respond). It doesn't seem to respond for me; a recv-keys just hangs. I recommend keys.openpgp.org or keyserver.ubuntu.com. -- PMM ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue 2021-09-16 15:57 ` Peter Maydell @ 2021-09-16 16:09 ` Dr. David Alan Gilbert 0 siblings, 0 replies; 12+ messages in thread From: Dr. David Alan Gilbert @ 2021-09-16 16:09 UTC (permalink / raw) To: Peter Maydell Cc: Stefan Hajnoczi, Thomas Huth, Sergio Lopez, QEMU Developers, vgoyal * Peter Maydell (peter.maydell@linaro.org) wrote: > On Thu, 16 Sept 2021 at 16:33, Dr. David Alan Gilbert > <dgilbert@redhat.com> wrote: > > > > * Peter Maydell (peter.maydell@linaro.org) wrote: > > > On Thu, 16 Sept 2021 at 14:58, Dr. David Alan Gilbert (git) > > > <dgilbert@redhat.com> wrote: > > > > > > > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > > > > > > > The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894: > > > > > > > > Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100) > > > > > > > > are available in the Git repository at: > > > > > > > > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916 > > > > > > > > for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d: > > > > > > > > virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100) > > > > > > > > > > gpg says your key has expired; what keyserver can I download an > > > updated key from? > > > > I pushed an updated one to pgp.mit.edu just before I sent the pull; > > I can see it there (although it's a bit slow to respond). > > It doesn't seem to respond for me; a recv-keys just hangs. > I recommend keys.openpgp.org or keyserver.ubuntu.com. I've just pushed them to both of those. Dave > -- PMM > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue 2021-09-16 13:52 Dr. David Alan Gilbert (git) 2021-09-16 15:01 ` Peter Maydell @ 2021-09-20 8:50 ` Peter Maydell 1 sibling, 0 replies; 12+ messages in thread From: Peter Maydell @ 2021-09-20 8:50 UTC (permalink / raw) To: Dr. David Alan Gilbert (git) Cc: Stefan Hajnoczi, Thomas Huth, Sergio Lopez, QEMU Developers, vgoyal On Thu, 16 Sept 2021 at 14:58, Dr. David Alan Gilbert (git) <dgilbert@redhat.com> wrote: > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894: > > Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100) > > are available in the Git repository at: > > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916 > > for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d: > > virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100) > > ---------------------------------------------------------------- > virtiofsd pull 2021-08-16 > > Two minor fixes; one for performance, the other seccomp > on s390x. > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.2 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PULL 0/2] virtiofs queue @ 2019-12-13 11:58 Dr. David Alan Gilbert (git) 2019-12-13 18:12 ` Peter Maydell 0 siblings, 1 reply; 12+ messages in thread From: Dr. David Alan Gilbert (git) @ 2019-12-13 11:58 UTC (permalink / raw) To: qemu-devel; +Cc: marcandre.lureau, stefanha, mst From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> The following changes since commit b0ca999a43a22b38158a222233d3f5881648bb4f: Update version for v4.2.0 release (2019-12-12 16:45:57 +0000) are available in the Git repository at: git://github.com/dagrh/qemu.git tags/pull-virtiofs-20191213a for you to fetch changes up to 366844f3d1329c6423dd752891a28ccb3ee8fddd: virtio-fs: fix MSI-X nvectors calculation (2019-12-13 10:53:57 +0000) ---------------------------------------------------------------- virtiofs pull 2019-12-13: Minor fixes and cleanups Cleanup from Marc-André and MSI-X fix from Stefan. ---------------------------------------------------------------- Marc-André Lureau (1): vhost-user-fs: remove "vhostfd" property Stefan Hajnoczi (1): virtio-fs: fix MSI-X nvectors calculation hw/virtio/vhost-user-fs-pci.c | 3 ++- hw/virtio/vhost-user-fs.c | 1 - include/hw/virtio/vhost-user-fs.h | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue 2019-12-13 11:58 Dr. David Alan Gilbert (git) @ 2019-12-13 18:12 ` Peter Maydell 0 siblings, 0 replies; 12+ messages in thread From: Peter Maydell @ 2019-12-13 18:12 UTC (permalink / raw) To: Dr. David Alan Gilbert (git) Cc: Marc-André Lureau, QEMU Developers, Stefan Hajnoczi, Michael S. Tsirkin On Fri, 13 Dec 2019 at 11:59, Dr. David Alan Gilbert (git) <dgilbert@redhat.com> wrote: > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > The following changes since commit b0ca999a43a22b38158a222233d3f5881648bb4f: > > Update version for v4.2.0 release (2019-12-12 16:45:57 +0000) > > are available in the Git repository at: > > git://github.com/dagrh/qemu.git tags/pull-virtiofs-20191213a > > for you to fetch changes up to 366844f3d1329c6423dd752891a28ccb3ee8fddd: > > virtio-fs: fix MSI-X nvectors calculation (2019-12-13 10:53:57 +0000) > > ---------------------------------------------------------------- > virtiofs pull 2019-12-13: Minor fixes and cleanups > > Cleanup from Marc-André and MSI-X fix from Stefan. Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-09-20 8:52 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-03 15:16 [PULL 0/2] virtiofs queue Dr. David Alan Gilbert (git) 2020-03-03 15:16 ` [PULL 1/2] virtiofsd: passthrough_ll: cleanup getxattr/listxattr Dr. David Alan Gilbert (git) 2020-03-03 15:16 ` [PULL 2/2] virtiofsd: Fix xattr operations Dr. David Alan Gilbert (git) 2020-03-03 17:23 ` [PULL 0/2] virtiofs queue Peter Maydell -- strict thread matches above, loose matches on Subject: below -- 2021-09-16 13:52 Dr. David Alan Gilbert (git) 2021-09-16 15:01 ` Peter Maydell 2021-09-16 15:33 ` Dr. David Alan Gilbert 2021-09-16 15:57 ` Peter Maydell 2021-09-16 16:09 ` Dr. David Alan Gilbert 2021-09-20 8:50 ` Peter Maydell 2019-12-13 11:58 Dr. David Alan Gilbert (git) 2019-12-13 18:12 ` Peter Maydell
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.