* [PULL 0/2] virtiofs queue
@ 2019-12-13 11:58 Dr. David Alan Gilbert (git)
2019-12-13 11:58 ` [PULL 1/2] vhost-user-fs: remove "vhostfd" property Dr. David Alan Gilbert (git)
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2019-12-13 11:58 UTC (permalink / raw)
To: qemu-devel; +Cc: marcandre.lureau, stefanha, mst
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
The following changes since commit b0ca999a43a22b38158a222233d3f5881648bb4f:
Update version for v4.2.0 release (2019-12-12 16:45:57 +0000)
are available in the Git repository at:
git://github.com/dagrh/qemu.git tags/pull-virtiofs-20191213a
for you to fetch changes up to 366844f3d1329c6423dd752891a28ccb3ee8fddd:
virtio-fs: fix MSI-X nvectors calculation (2019-12-13 10:53:57 +0000)
----------------------------------------------------------------
virtiofs pull 2019-12-13: Minor fixes and cleanups
Cleanup from Marc-André and MSI-X fix from Stefan.
----------------------------------------------------------------
Marc-André Lureau (1):
vhost-user-fs: remove "vhostfd" property
Stefan Hajnoczi (1):
virtio-fs: fix MSI-X nvectors calculation
hw/virtio/vhost-user-fs-pci.c | 3 ++-
hw/virtio/vhost-user-fs.c | 1 -
include/hw/virtio/vhost-user-fs.h | 1 -
3 files changed, 2 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PULL 1/2] vhost-user-fs: remove "vhostfd" property
2019-12-13 11:58 [PULL 0/2] virtiofs queue Dr. David Alan Gilbert (git)
@ 2019-12-13 11:58 ` Dr. David Alan Gilbert (git)
2019-12-13 11:58 ` [PULL 2/2] virtio-fs: fix MSI-X nvectors calculation Dr. David Alan Gilbert (git)
2019-12-13 18:12 ` [PULL 0/2] virtiofs queue Peter Maydell
2 siblings, 0 replies; 12+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2019-12-13 11:58 UTC (permalink / raw)
To: qemu-devel; +Cc: marcandre.lureau, stefanha, mst
From: Marc-André Lureau <marcandre.lureau@redhat.com>
The property doesn't make much sense for a vhost-user device.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20191116112016.14872-1-marcandre.lureau@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
hw/virtio/vhost-user-fs.c | 1 -
include/hw/virtio/vhost-user-fs.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c
index f0df7f4746..ca0b7fc9de 100644
--- a/hw/virtio/vhost-user-fs.c
+++ b/hw/virtio/vhost-user-fs.c
@@ -263,7 +263,6 @@ static Property vuf_properties[] = {
DEFINE_PROP_UINT16("num-request-queues", VHostUserFS,
conf.num_request_queues, 1),
DEFINE_PROP_UINT16("queue-size", VHostUserFS, conf.queue_size, 128),
- DEFINE_PROP_STRING("vhostfd", VHostUserFS, conf.vhostfd),
DEFINE_PROP_END_OF_LIST(),
};
diff --git a/include/hw/virtio/vhost-user-fs.h b/include/hw/virtio/vhost-user-fs.h
index 539885b458..9ff1bdb7cf 100644
--- a/include/hw/virtio/vhost-user-fs.h
+++ b/include/hw/virtio/vhost-user-fs.h
@@ -28,7 +28,6 @@ typedef struct {
char *tag;
uint16_t num_request_queues;
uint16_t queue_size;
- char *vhostfd;
} VHostUserFSConf;
typedef struct {
--
2.23.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PULL 2/2] virtio-fs: fix MSI-X nvectors calculation
2019-12-13 11:58 [PULL 0/2] virtiofs queue Dr. David Alan Gilbert (git)
2019-12-13 11:58 ` [PULL 1/2] vhost-user-fs: remove "vhostfd" property Dr. David Alan Gilbert (git)
@ 2019-12-13 11:58 ` Dr. David Alan Gilbert (git)
2019-12-13 18:12 ` [PULL 0/2] virtiofs queue Peter Maydell
2 siblings, 0 replies; 12+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2019-12-13 11:58 UTC (permalink / raw)
To: qemu-devel; +Cc: marcandre.lureau, stefanha, mst
From: Stefan Hajnoczi <stefanha@redhat.com>
The following MSI-X vectors are required:
* VIRTIO Configuration Change
* hiprio virtqueue
* requests virtqueues
Fix the calculation to reserve enough MSI-X vectors. Otherwise guest
drivers fall back to a sub-optional configuration where all virtqueues
share a single vector.
This change does not break live migration compatibility since
vhost-user-fs-pci devices are not migratable yet.
Reported-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20191209110759.35227-1-stefanha@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
hw/virtio/vhost-user-fs-pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-user-fs-pci.c b/hw/virtio/vhost-user-fs-pci.c
index 933a3f265b..e3a649d4a6 100644
--- a/hw/virtio/vhost-user-fs-pci.c
+++ b/hw/virtio/vhost-user-fs-pci.c
@@ -40,7 +40,8 @@ static void vhost_user_fs_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
DeviceState *vdev = DEVICE(&dev->vdev);
if (vpci_dev->nvectors == DEV_NVECTORS_UNSPECIFIED) {
- vpci_dev->nvectors = dev->vdev.conf.num_request_queues + 1;
+ /* Also reserve config change and hiprio queue vectors */
+ vpci_dev->nvectors = dev->vdev.conf.num_request_queues + 2;
}
qdev_set_parent_bus(vdev, BUS(&vpci_dev->bus));
--
2.23.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue
2019-12-13 11:58 [PULL 0/2] virtiofs queue Dr. David Alan Gilbert (git)
2019-12-13 11:58 ` [PULL 1/2] vhost-user-fs: remove "vhostfd" property Dr. David Alan Gilbert (git)
2019-12-13 11:58 ` [PULL 2/2] virtio-fs: fix MSI-X nvectors calculation Dr. David Alan Gilbert (git)
@ 2019-12-13 18:12 ` Peter Maydell
2 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2019-12-13 18:12 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git)
Cc: Marc-André Lureau, QEMU Developers, Stefan Hajnoczi,
Michael S. Tsirkin
On Fri, 13 Dec 2019 at 11:59, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit b0ca999a43a22b38158a222233d3f5881648bb4f:
>
> Update version for v4.2.0 release (2019-12-12 16:45:57 +0000)
>
> are available in the Git repository at:
>
> git://github.com/dagrh/qemu.git tags/pull-virtiofs-20191213a
>
> for you to fetch changes up to 366844f3d1329c6423dd752891a28ccb3ee8fddd:
>
> virtio-fs: fix MSI-X nvectors calculation (2019-12-13 10:53:57 +0000)
>
> ----------------------------------------------------------------
> virtiofs pull 2019-12-13: Minor fixes and cleanups
>
> Cleanup from Marc-André and MSI-X fix from Stefan.
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PULL 0/2] virtiofs queue
@ 2020-03-03 15:16 Dr. David Alan Gilbert (git)
2020-03-03 17:23 ` Peter Maydell
0 siblings, 1 reply; 12+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2020-03-03 15:16 UTC (permalink / raw)
To: qemu-devel
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
The following changes since commit 104933c4a973960dea605b06fcd5d0d478255d77:
Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2020-03-03 12:03:59 +0000)
are available in the Git repository at:
https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20200303
for you to fetch changes up to bdfd66788349acc43cd3f1298718ad491663cfcc:
virtiofsd: Fix xattr operations (2020-03-03 15:13:24 +0000)
----------------------------------------------------------------
Virtiofsd pull 2020-03-03
xattr fixes from Misono.
----------------------------------------------------------------
Misono Tomohiro (2):
virtiofsd: passthrough_ll: cleanup getxattr/listxattr
virtiofsd: Fix xattr operations
tools/virtiofsd/fuse_virtio.c | 13 ++++
tools/virtiofsd/passthrough_ll.c | 139 ++++++++++++++++++++-------------------
tools/virtiofsd/seccomp.c | 6 ++
3 files changed, 89 insertions(+), 69 deletions(-)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue
2020-03-03 15:16 Dr. David Alan Gilbert (git)
@ 2020-03-03 17:23 ` Peter Maydell
0 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2020-03-03 17:23 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: QEMU Developers
On Tue, 3 Mar 2020 at 15:17, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit 104933c4a973960dea605b06fcd5d0d478255d77:
>
> Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2020-03-03 12:03:59 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20200303
>
> for you to fetch changes up to bdfd66788349acc43cd3f1298718ad491663cfcc:
>
> virtiofsd: Fix xattr operations (2020-03-03 15:13:24 +0000)
>
> ----------------------------------------------------------------
> Virtiofsd pull 2020-03-03
>
> xattr fixes from Misono.
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PULL 0/2] virtiofs queue
@ 2021-09-16 13:52 Dr. David Alan Gilbert (git)
2021-09-16 15:01 ` Peter Maydell
2021-09-20 8:50 ` Peter Maydell
0 siblings, 2 replies; 12+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2021-09-16 13:52 UTC (permalink / raw)
To: qemu-devel, vgoyal, slp, thuth; +Cc: stefanha
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894:
Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100)
are available in the Git repository at:
https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916
for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d:
virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100)
----------------------------------------------------------------
virtiofsd pull 2021-08-16
Two minor fixes; one for performance, the other seccomp
on s390x.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
----------------------------------------------------------------
Sergio Lopez (1):
virtiofsd: Reverse req_list before processing it
Thomas Huth (1):
tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist
tools/virtiofsd/fuse_virtio.c | 1 +
tools/virtiofsd/passthrough_seccomp.c | 1 +
2 files changed, 2 insertions(+)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue
2021-09-16 13:52 Dr. David Alan Gilbert (git)
@ 2021-09-16 15:01 ` Peter Maydell
2021-09-16 15:33 ` Dr. David Alan Gilbert
2021-09-20 8:50 ` Peter Maydell
1 sibling, 1 reply; 12+ messages in thread
From: Peter Maydell @ 2021-09-16 15:01 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git)
Cc: Stefan Hajnoczi, Thomas Huth, Sergio Lopez, QEMU Developers, vgoyal
On Thu, 16 Sept 2021 at 14:58, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894:
>
> Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916
>
> for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d:
>
> virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100)
>
gpg says your key has expired; what keyserver can I download an
updated key from?
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue
2021-09-16 15:01 ` Peter Maydell
@ 2021-09-16 15:33 ` Dr. David Alan Gilbert
2021-09-16 15:57 ` Peter Maydell
0 siblings, 1 reply; 12+ messages in thread
From: Dr. David Alan Gilbert @ 2021-09-16 15:33 UTC (permalink / raw)
To: Peter Maydell
Cc: Stefan Hajnoczi, Thomas Huth, Sergio Lopez, QEMU Developers, vgoyal
* Peter Maydell (peter.maydell@linaro.org) wrote:
> On Thu, 16 Sept 2021 at 14:58, Dr. David Alan Gilbert (git)
> <dgilbert@redhat.com> wrote:
> >
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894:
> >
> > Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100)
> >
> > are available in the Git repository at:
> >
> > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916
> >
> > for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d:
> >
> > virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100)
> >
>
> gpg says your key has expired; what keyserver can I download an
> updated key from?
I pushed an updated one to pgp.mit.edu just before I sent the pull;
I can see it there (although it's a bit slow to respond).
Dave
> thanks
> -- PMM
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue
2021-09-16 15:33 ` Dr. David Alan Gilbert
@ 2021-09-16 15:57 ` Peter Maydell
2021-09-16 16:09 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 12+ messages in thread
From: Peter Maydell @ 2021-09-16 15:57 UTC (permalink / raw)
To: Dr. David Alan Gilbert
Cc: Stefan Hajnoczi, Thomas Huth, Sergio Lopez, QEMU Developers, vgoyal
On Thu, 16 Sept 2021 at 16:33, Dr. David Alan Gilbert
<dgilbert@redhat.com> wrote:
>
> * Peter Maydell (peter.maydell@linaro.org) wrote:
> > On Thu, 16 Sept 2021 at 14:58, Dr. David Alan Gilbert (git)
> > <dgilbert@redhat.com> wrote:
> > >
> > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > >
> > > The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894:
> > >
> > > Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100)
> > >
> > > are available in the Git repository at:
> > >
> > > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916
> > >
> > > for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d:
> > >
> > > virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100)
> > >
> >
> > gpg says your key has expired; what keyserver can I download an
> > updated key from?
>
> I pushed an updated one to pgp.mit.edu just before I sent the pull;
> I can see it there (although it's a bit slow to respond).
It doesn't seem to respond for me; a recv-keys just hangs.
I recommend keys.openpgp.org or keyserver.ubuntu.com.
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue
2021-09-16 15:57 ` Peter Maydell
@ 2021-09-16 16:09 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 12+ messages in thread
From: Dr. David Alan Gilbert @ 2021-09-16 16:09 UTC (permalink / raw)
To: Peter Maydell
Cc: Stefan Hajnoczi, Thomas Huth, Sergio Lopez, QEMU Developers, vgoyal
* Peter Maydell (peter.maydell@linaro.org) wrote:
> On Thu, 16 Sept 2021 at 16:33, Dr. David Alan Gilbert
> <dgilbert@redhat.com> wrote:
> >
> > * Peter Maydell (peter.maydell@linaro.org) wrote:
> > > On Thu, 16 Sept 2021 at 14:58, Dr. David Alan Gilbert (git)
> > > <dgilbert@redhat.com> wrote:
> > > >
> > > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > > >
> > > > The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894:
> > > >
> > > > Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916
> > > >
> > > > for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d:
> > > >
> > > > virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100)
> > > >
> > >
> > > gpg says your key has expired; what keyserver can I download an
> > > updated key from?
> >
> > I pushed an updated one to pgp.mit.edu just before I sent the pull;
> > I can see it there (although it's a bit slow to respond).
>
> It doesn't seem to respond for me; a recv-keys just hangs.
> I recommend keys.openpgp.org or keyserver.ubuntu.com.
I've just pushed them to both of those.
Dave
> -- PMM
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PULL 0/2] virtiofs queue
2021-09-16 13:52 Dr. David Alan Gilbert (git)
2021-09-16 15:01 ` Peter Maydell
@ 2021-09-20 8:50 ` Peter Maydell
1 sibling, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2021-09-20 8:50 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git)
Cc: Stefan Hajnoczi, Thomas Huth, Sergio Lopez, QEMU Developers, vgoyal
On Thu, 16 Sept 2021 at 14:58, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit 57b6f58c1d0df757c9311496c32d502925056894:
>
> Merge remote-tracking branch 'remotes/hreitz/tags/pull-block-2021-09-15' into staging (2021-09-15 18:55:59 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210916
>
> for you to fetch changes up to 046d91c83caac29e2ba26c63fd7d685a57463f6d:
>
> virtiofsd: Reverse req_list before processing it (2021-09-16 14:50:48 +0100)
>
> ----------------------------------------------------------------
> virtiofsd pull 2021-08-16
>
> Two minor fixes; one for performance, the other seccomp
> on s390x.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/6.2
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-09-20 8:52 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 11:58 [PULL 0/2] virtiofs queue Dr. David Alan Gilbert (git)
2019-12-13 11:58 ` [PULL 1/2] vhost-user-fs: remove "vhostfd" property Dr. David Alan Gilbert (git)
2019-12-13 11:58 ` [PULL 2/2] virtio-fs: fix MSI-X nvectors calculation Dr. David Alan Gilbert (git)
2019-12-13 18:12 ` [PULL 0/2] virtiofs queue Peter Maydell
2020-03-03 15:16 Dr. David Alan Gilbert (git)
2020-03-03 17:23 ` Peter Maydell
2021-09-16 13:52 Dr. David Alan Gilbert (git)
2021-09-16 15:01 ` Peter Maydell
2021-09-16 15:33 ` Dr. David Alan Gilbert
2021-09-16 15:57 ` Peter Maydell
2021-09-16 16:09 ` Dr. David Alan Gilbert
2021-09-20 8:50 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.