* [PATCH] check: Inform about missing ranges @ 2020-03-08 16:56 Arkadiusz Drabczyk [not found] ` <20200308165643.19281-1-arkadiusz-42WfZ8EewN5g9hUCZPvPmw@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Arkadiusz Drabczyk @ 2020-03-08 16:56 UTC (permalink / raw) To: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA In check_unit_address_vs_reg() warning message already says 'reg _or_ ranges' when reg or ranges are present but unit name is missing. Add this message for compatibility to say "reg _or_ ranges" when unit name is present but neither reg nor ranges are present. Signed-off-by: Arkadiusz Drabczyk <arkadiusz-42WfZ8EewN5g9hUCZPvPmw@public.gmane.org> --- checks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks.c b/checks.c index 8acbc05..4b3c486 100644 --- a/checks.c +++ b/checks.c @@ -352,7 +352,7 @@ static void check_unit_address_vs_reg(struct check *c, struct dt_info *dti, FAIL(c, dti, node, "node has a reg or ranges property, but no unit name"); } else { if (unitname[0]) - FAIL(c, dti, node, "node has a unit name, but no reg property"); + FAIL(c, dti, node, "node has a unit name, but no reg or ranges property"); } } WARNING(unit_address_vs_reg, check_unit_address_vs_reg, NULL); -- 2.9.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
[parent not found: <20200308165643.19281-1-arkadiusz-42WfZ8EewN5g9hUCZPvPmw@public.gmane.org>]
* Re: [PATCH] check: Inform about missing ranges [not found] ` <20200308165643.19281-1-arkadiusz-42WfZ8EewN5g9hUCZPvPmw@public.gmane.org> @ 2020-03-10 0:44 ` David Gibson 0 siblings, 0 replies; 2+ messages in thread From: David Gibson @ 2020-03-10 0:44 UTC (permalink / raw) To: Arkadiusz Drabczyk; +Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 1292 bytes --] On Sun, Mar 08, 2020 at 05:56:43PM +0100, Arkadiusz Drabczyk wrote: > In check_unit_address_vs_reg() warning message already says 'reg _or_ > ranges' when reg or ranges are present but unit name is missing. Add > this message for compatibility to say "reg _or_ ranges" when unit name > is present but neither reg nor ranges are present. > > Signed-off-by: Arkadiusz Drabczyk <arkadiusz-42WfZ8EewN5g9hUCZPvPmw@public.gmane.org> Applied, thanks. > --- > checks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/checks.c b/checks.c > index 8acbc05..4b3c486 100644 > --- a/checks.c > +++ b/checks.c > @@ -352,7 +352,7 @@ static void check_unit_address_vs_reg(struct check *c, struct dt_info *dti, > FAIL(c, dti, node, "node has a reg or ranges property, but no unit name"); > } else { > if (unitname[0]) > - FAIL(c, dti, node, "node has a unit name, but no reg property"); > + FAIL(c, dti, node, "node has a unit name, but no reg or ranges property"); > } > } > WARNING(unit_address_vs_reg, check_unit_address_vs_reg, NULL); -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-10 0:44 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-08 16:56 [PATCH] check: Inform about missing ranges Arkadiusz Drabczyk [not found] ` <20200308165643.19281-1-arkadiusz-42WfZ8EewN5g9hUCZPvPmw@public.gmane.org> 2020-03-10 0:44 ` David Gibson
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.