* [PATCH] staging: rtl8192u: r8192U_wx: use pr_warn instead() of printk()
@ 2020-03-10 20:32 Lourdes Pedrajas
2020-03-10 20:42 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Lourdes Pedrajas @ 2020-03-10 20:32 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
printk() is deprecated, use pr_warn() instead. Change suggested by
checkpatch.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 0118edb0b9ab..09ab68865934 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
hwkey); /* KeyContent */
} else {
- printk("wrong type in WEP, not WEP40 and WEP104\n");
+ pr_warn("wrong type in WEP, not WEP40 and WEP104\n");
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8192u: r8192U_wx: use pr_warn instead() of printk()
2020-03-10 20:32 [PATCH] staging: rtl8192u: r8192U_wx: use pr_warn instead() of printk() Lourdes Pedrajas
@ 2020-03-10 20:42 ` Julia Lawall
2020-03-10 21:34 ` Lourdes Pedrajas
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-03-10 20:42 UTC (permalink / raw)
To: Lourdes Pedrajas; +Cc: outreachy-kernel, gregkh
On Tue, 10 Mar 2020, Lourdes Pedrajas wrote:
> printk() is deprecated, use pr_warn() instead. Change suggested by
> checkpatch.
>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> index 0118edb0b9ab..09ab68865934 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
> hwkey); /* KeyContent */
>
> } else {
> - printk("wrong type in WEP, not WEP40 and WEP104\n");
> + pr_warn("wrong type in WEP, not WEP40 and WEP104\n");
There is a specific message printing function for network device drivers.
To find out what it is, you can probably go to drivers/net and do a git
grep for warn, or something like that.
julia
> }
>
> }
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200310203251.2961-1-lu%40pplo.net.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8192u: r8192U_wx: use pr_warn instead() of printk()
2020-03-10 20:42 ` [Outreachy kernel] " Julia Lawall
@ 2020-03-10 21:34 ` Lourdes Pedrajas
0 siblings, 0 replies; 3+ messages in thread
From: Lourdes Pedrajas @ 2020-03-10 21:34 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel, gregkh
On Tue, Mar 10, 2020 at 09:42:50PM +0100, Julia Lawall wrote:
>
>
> On Tue, 10 Mar 2020, Lourdes Pedrajas wrote:
>
> > printk() is deprecated, use pr_warn() instead. Change suggested by
> > checkpatch.
> >
> > Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> > ---
> > drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> > index 0118edb0b9ab..09ab68865934 100644
> > --- a/drivers/staging/rtl8192u/r8192U_wx.c
> > +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> > @@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
> > hwkey); /* KeyContent */
> >
> > } else {
> > - printk("wrong type in WEP, not WEP40 and WEP104\n");
> > + pr_warn("wrong type in WEP, not WEP40 and WEP104\n");
>
> There is a specific message printing function for network device drivers.
>
> To find out what it is, you can probably go to drivers/net and do a git
> grep for warn, or something like that.
>
> julia
>
I agree, thank you for the hint!
Lourdes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-10 21:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-10 20:32 [PATCH] staging: rtl8192u: r8192U_wx: use pr_warn instead() of printk() Lourdes Pedrajas
2020-03-10 20:42 ` [Outreachy kernel] " Julia Lawall
2020-03-10 21:34 ` Lourdes Pedrajas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.