* [PATCH] remove unnecessary newline for brace
@ 2020-03-11 12:52 Enrique Vargas
2020-03-11 13:04 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Enrique Vargas @ 2020-03-11 12:52 UTC (permalink / raw)
To: Chas Williams, linux-iio, Greg KH
put brace at the end of line following coding conventions
Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
drivers/atm/adummy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
index 8157925af824..6eeaa1b21f3b 100644
--- a/drivers/atm/adummy.c
+++ b/drivers/atm/adummy.c
@@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
return 0;
}
-static const struct atmdev_ops adummy_ops =
-{
+static const struct atmdev_ops adummy_ops = {
.open = adummy_open,
.close = adummy_close,
.send = adummy_send,
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] remove unnecessary newline for brace
2020-03-11 12:52 [PATCH] remove unnecessary newline for brace Enrique Vargas
@ 2020-03-11 13:04 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2020-03-11 13:04 UTC (permalink / raw)
To: Enrique Vargas; +Cc: Chas Williams, linux-iio
On Wed, Mar 11, 2020 at 06:52:22AM -0600, Enrique Vargas wrote:
> put brace at the end of line following coding conventions
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/atm/adummy.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
> index 8157925af824..6eeaa1b21f3b 100644
> --- a/drivers/atm/adummy.c
> +++ b/drivers/atm/adummy.c
> @@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
> return 0;
> }
>
> -static const struct atmdev_ops adummy_ops =
> -{
> +static const struct atmdev_ops adummy_ops = {
> .open = adummy_open,
> .close = adummy_close,
> .send = adummy_send,
> --
> 2.17.1
>
$ ./scripts/get_maintainer.pl --file drivers/atm/adummy.c
Chas Williams <3chas3@gmail.com> (maintainer:ATM)
linux-atm-general@lists.sourceforge.net (moderated list:ATM)
netdev@vger.kernel.org (open list:ATM)
linux-kernel@vger.kernel.org (open list)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] remove unnecessary newline for brace
2020-03-11 13:05 ` Greg KH
@ 2020-03-11 13:37 ` Enrique Vargas
0 siblings, 0 replies; 5+ messages in thread
From: Enrique Vargas @ 2020-03-11 13:37 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
Sorry, I will pickup a driver from drivers/staging
For the mailing list I misunderstood this comment in the tutorial: ....However, for IIO drivers, please also include linux-iio@vger.kernel.org....
On 3/11/20 7:05 AM, Greg KH wrote:
> On Wed, Mar 11, 2020 at 06:55:07AM -0600, Enrique Vargas wrote:
>> put brace at the end of line following coding conventions
>>
>> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
>> ---
>> drivers/atm/adummy.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
>> index 8157925af824..6eeaa1b21f3b 100644
>> --- a/drivers/atm/adummy.c
>> +++ b/drivers/atm/adummy.c
>> @@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
>> return 0;
>> }
>>
>> -static const struct atmdev_ops adummy_ops =
>> -{
>> +static const struct atmdev_ops adummy_ops = {
>> .open = adummy_open,
>> .close = adummy_close,
>> .send = adummy_send,
>> --
>> 2.17.1
>>
> This is an outreachy application patch? You need to do work in
> drivers/staging/ only. Also, the iio mailing list is not the correct
> one at all.
>
> greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] remove unnecessary newline for brace
2020-03-11 12:55 Enrique Vargas
@ 2020-03-11 13:05 ` Greg KH
2020-03-11 13:37 ` Enrique Vargas
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2020-03-11 13:05 UTC (permalink / raw)
To: Enrique Vargas; +Cc: Chas Williams, linux-iio, outreachy-kernel
On Wed, Mar 11, 2020 at 06:55:07AM -0600, Enrique Vargas wrote:
> put brace at the end of line following coding conventions
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/atm/adummy.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
> index 8157925af824..6eeaa1b21f3b 100644
> --- a/drivers/atm/adummy.c
> +++ b/drivers/atm/adummy.c
> @@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
> return 0;
> }
>
> -static const struct atmdev_ops adummy_ops =
> -{
> +static const struct atmdev_ops adummy_ops = {
> .open = adummy_open,
> .close = adummy_close,
> .send = adummy_send,
> --
> 2.17.1
>
This is an outreachy application patch? You need to do work in
drivers/staging/ only. Also, the iio mailing list is not the correct
one at all.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] remove unnecessary newline for brace
@ 2020-03-11 12:55 Enrique Vargas
2020-03-11 13:05 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Enrique Vargas @ 2020-03-11 12:55 UTC (permalink / raw)
To: Chas Williams, linux-iio, Greg KH, outreachy-kernel
put brace at the end of line following coding conventions
Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
drivers/atm/adummy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
index 8157925af824..6eeaa1b21f3b 100644
--- a/drivers/atm/adummy.c
+++ b/drivers/atm/adummy.c
@@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
return 0;
}
-static const struct atmdev_ops adummy_ops =
-{
+static const struct atmdev_ops adummy_ops = {
.open = adummy_open,
.close = adummy_close,
.send = adummy_send,
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-11 13:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 12:52 [PATCH] remove unnecessary newline for brace Enrique Vargas
2020-03-11 13:04 ` Greg KH
2020-03-11 12:55 Enrique Vargas
2020-03-11 13:05 ` Greg KH
2020-03-11 13:37 ` Enrique Vargas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.