* [PATCH] remove unnecessary newline for brace
@ 2020-03-11 12:55 Enrique Vargas
2020-03-11 12:56 ` [Outreachy kernel] " Julia Lawall
2020-03-11 13:05 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Enrique Vargas @ 2020-03-11 12:55 UTC (permalink / raw)
To: Chas Williams, linux-iio, Greg KH, outreachy-kernel
put brace at the end of line following coding conventions
Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
drivers/atm/adummy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
index 8157925af824..6eeaa1b21f3b 100644
--- a/drivers/atm/adummy.c
+++ b/drivers/atm/adummy.c
@@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
return 0;
}
-static const struct atmdev_ops adummy_ops =
-{
+static const struct atmdev_ops adummy_ops = {
.open = adummy_open,
.close = adummy_close,
.send = adummy_send,
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] remove unnecessary newline for brace
2020-03-11 12:55 [PATCH] remove unnecessary newline for brace Enrique Vargas
@ 2020-03-11 12:56 ` Julia Lawall
2020-03-11 13:05 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2020-03-11 12:56 UTC (permalink / raw)
To: Enrique Vargas; +Cc: Chas Williams, linux-iio, Greg KH, outreachy-kernel
The subject line should give information about what part of the kernel is
being changed. See other patches or the tutorial for examples.
On Wed, 11 Mar 2020, Enrique Vargas wrote:
> put brace at the end of line following coding conventions
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/atm/adummy.c | 3 +--
Is there a reason why you are working on drivers/atm? Normally for the
application period you should only do cleanups on drivers/staging.
julia
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
> index 8157925af824..6eeaa1b21f3b 100644
> --- a/drivers/atm/adummy.c
> +++ b/drivers/atm/adummy.c
> @@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
> return 0;
> }
>
> -static const struct atmdev_ops adummy_ops =
> -{
> +static const struct atmdev_ops adummy_ops = {
> .open = adummy_open,
> .close = adummy_close,
> .send = adummy_send,
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200311125507.GA9347%40evX1.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] remove unnecessary newline for brace
2020-03-11 12:55 [PATCH] remove unnecessary newline for brace Enrique Vargas
2020-03-11 12:56 ` [Outreachy kernel] " Julia Lawall
@ 2020-03-11 13:05 ` Greg KH
2020-03-11 13:37 ` Enrique Vargas
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2020-03-11 13:05 UTC (permalink / raw)
To: Enrique Vargas; +Cc: Chas Williams, linux-iio, outreachy-kernel
On Wed, Mar 11, 2020 at 06:55:07AM -0600, Enrique Vargas wrote:
> put brace at the end of line following coding conventions
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/atm/adummy.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
> index 8157925af824..6eeaa1b21f3b 100644
> --- a/drivers/atm/adummy.c
> +++ b/drivers/atm/adummy.c
> @@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
> return 0;
> }
>
> -static const struct atmdev_ops adummy_ops =
> -{
> +static const struct atmdev_ops adummy_ops = {
> .open = adummy_open,
> .close = adummy_close,
> .send = adummy_send,
> --
> 2.17.1
>
This is an outreachy application patch? You need to do work in
drivers/staging/ only. Also, the iio mailing list is not the correct
one at all.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] remove unnecessary newline for brace
2020-03-11 13:05 ` Greg KH
@ 2020-03-11 13:37 ` Enrique Vargas
0 siblings, 0 replies; 6+ messages in thread
From: Enrique Vargas @ 2020-03-11 13:37 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
Sorry, I will pickup a driver from drivers/staging
For the mailing list I misunderstood this comment in the tutorial: ....However, for IIO drivers, please also include linux-iio@vger.kernel.org....
On 3/11/20 7:05 AM, Greg KH wrote:
> On Wed, Mar 11, 2020 at 06:55:07AM -0600, Enrique Vargas wrote:
>> put brace at the end of line following coding conventions
>>
>> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
>> ---
>> drivers/atm/adummy.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
>> index 8157925af824..6eeaa1b21f3b 100644
>> --- a/drivers/atm/adummy.c
>> +++ b/drivers/atm/adummy.c
>> @@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
>> return 0;
>> }
>>
>> -static const struct atmdev_ops adummy_ops =
>> -{
>> +static const struct atmdev_ops adummy_ops = {
>> .open = adummy_open,
>> .close = adummy_close,
>> .send = adummy_send,
>> --
>> 2.17.1
>>
> This is an outreachy application patch? You need to do work in
> drivers/staging/ only. Also, the iio mailing list is not the correct
> one at all.
>
> greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] remove unnecessary newline for brace
2020-03-11 12:52 Enrique Vargas
@ 2020-03-11 13:04 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2020-03-11 13:04 UTC (permalink / raw)
To: Enrique Vargas; +Cc: Chas Williams, linux-iio
On Wed, Mar 11, 2020 at 06:52:22AM -0600, Enrique Vargas wrote:
> put brace at the end of line following coding conventions
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/atm/adummy.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
> index 8157925af824..6eeaa1b21f3b 100644
> --- a/drivers/atm/adummy.c
> +++ b/drivers/atm/adummy.c
> @@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
> return 0;
> }
>
> -static const struct atmdev_ops adummy_ops =
> -{
> +static const struct atmdev_ops adummy_ops = {
> .open = adummy_open,
> .close = adummy_close,
> .send = adummy_send,
> --
> 2.17.1
>
$ ./scripts/get_maintainer.pl --file drivers/atm/adummy.c
Chas Williams <3chas3@gmail.com> (maintainer:ATM)
linux-atm-general@lists.sourceforge.net (moderated list:ATM)
netdev@vger.kernel.org (open list:ATM)
linux-kernel@vger.kernel.org (open list)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] remove unnecessary newline for brace
@ 2020-03-11 12:52 Enrique Vargas
2020-03-11 13:04 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Enrique Vargas @ 2020-03-11 12:52 UTC (permalink / raw)
To: Chas Williams, linux-iio, Greg KH
put brace at the end of line following coding conventions
Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
drivers/atm/adummy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
index 8157925af824..6eeaa1b21f3b 100644
--- a/drivers/atm/adummy.c
+++ b/drivers/atm/adummy.c
@@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
return 0;
}
-static const struct atmdev_ops adummy_ops =
-{
+static const struct atmdev_ops adummy_ops = {
.open = adummy_open,
.close = adummy_close,
.send = adummy_send,
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-11 13:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 12:55 [PATCH] remove unnecessary newline for brace Enrique Vargas
2020-03-11 12:56 ` [Outreachy kernel] " Julia Lawall
2020-03-11 13:05 ` Greg KH
2020-03-11 13:37 ` Enrique Vargas
-- strict thread matches above, loose matches on Subject: below --
2020-03-11 12:52 Enrique Vargas
2020-03-11 13:04 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.