* [PATCH] staging: sm750fb: makefile variable longline fix
@ 2020-03-11 13:11 R Veera Kumar
2020-03-11 16:58 ` [Outreachy kernel] " Stefano Brivio
0 siblings, 1 reply; 4+ messages in thread
From: R Veera Kumar @ 2020-03-11 13:11 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Sudip Mukherjee, Teddy Wang, outreachy-kernel
A simple makefile variable longline definition fix
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
drivers/staging/sm750fb/Makefile | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/Makefile b/drivers/staging/sm750fb/Makefile
index 1cf3849cef23..6f832916ba65 100644
--- a/drivers/staging/sm750fb/Makefile
+++ b/drivers/staging/sm750fb/Makefile
@@ -1,5 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_FB_SM750) += sm750fb.o
-sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o
-sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o
+sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o
+sm750fb-objs += ddk750_chip.o ddk750_power.o ddk750_mode.o
+sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o
+sm750fb-objs += ddk750_dvi.o ddk750_hwi2c.o
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: sm750fb: makefile variable longline fix
2020-03-11 13:11 [PATCH] staging: sm750fb: makefile variable longline fix R Veera Kumar
@ 2020-03-11 16:58 ` Stefano Brivio
2020-03-12 1:14 ` Veera
0 siblings, 1 reply; 4+ messages in thread
From: Stefano Brivio @ 2020-03-11 16:58 UTC (permalink / raw)
To: R Veera Kumar
Cc: Greg Kroah-Hartman, Sudip Mukherjee, Teddy Wang, outreachy-kernel
Hi Veera,
Thanks, this mostly looks good, in general. A few notes:
- the commit title is typically in an imperative form, that is, for
example, "[...]: Fix long line in Makefile variable"
Also,
On Wed, 11 Mar 2020 18:41:02 +0530
R Veera Kumar <vkor@vkten.in> wrote:
> A simple makefile variable longline definition fix
It would be nice to also mention if you used a tool to find this.
>
> Signed-off-by: R Veera Kumar <vkor@vkten.in>
> ---
> drivers/staging/sm750fb/Makefile | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/Makefile b/drivers/staging/sm750fb/Makefile
> index 1cf3849cef23..6f832916ba65 100644
> --- a/drivers/staging/sm750fb/Makefile
> +++ b/drivers/staging/sm750fb/Makefile
> @@ -1,5 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0
> obj-$(CONFIG_FB_SM750) += sm750fb.o
>
> -sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o
> -sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o
> +sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o
> +sm750fb-objs += ddk750_chip.o ddk750_power.o ddk750_mode.o
> +sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o
> +sm750fb-objs += ddk750_dvi.o ddk750_hwi2c.o
...and while this fixes the long lines for sure, a more common way is
to use backslashes at the end of the lines. Compare it with other
similar cases: you don't need to do something like:
drivers/staging/wfx/Makefile
but what's done for example in:
drivers/staging/comedi/Makefile
looks appropriate here (using 3 or 4 lines I guess).
If you send another version of this patch, don't forget to indicate
that under "---", see recent discussions on the outreachy-kernel list
for examples.
--
Stefano
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: sm750fb: makefile variable longline fix
2020-03-11 16:58 ` [Outreachy kernel] " Stefano Brivio
@ 2020-03-12 1:14 ` Veera
2020-03-12 10:42 ` Stefano Brivio
0 siblings, 1 reply; 4+ messages in thread
From: Veera @ 2020-03-12 1:14 UTC (permalink / raw)
To: Stefano Brivio
Cc: Greg Kroah-Hartman, Sudip Mukherjee, Teddy Wang, outreachy-kernel
On Wed, Mar 11, 2020 at 05:58:39PM +0100, Stefano Brivio wrote:
> Hi Veera,
>
> Thanks, this mostly looks good, in general. A few notes:
>
> - the commit title is typically in an imperative form, that is, for
> example, "[...]: Fix long line in Makefile variable"
>
> Also,
>
> On Wed, 11 Mar 2020 18:41:02 +0530
> R Veera Kumar <vkor@vkten.in> wrote:
>
> > A simple makefile variable longline definition fix
>
> It would be nice to also mention if you used a tool to find this.
>
> >
> > Signed-off-by: R Veera Kumar <vkor@vkten.in>
> > ---
> > drivers/staging/sm750fb/Makefile | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/Makefile b/drivers/staging/sm750fb/Makefile
> > index 1cf3849cef23..6f832916ba65 100644
> > --- a/drivers/staging/sm750fb/Makefile
> > +++ b/drivers/staging/sm750fb/Makefile
> > @@ -1,5 +1,7 @@
> > # SPDX-License-Identifier: GPL-2.0
> > obj-$(CONFIG_FB_SM750) += sm750fb.o
> >
> > -sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o
> > -sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o
> > +sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o
> > +sm750fb-objs += ddk750_chip.o ddk750_power.o ddk750_mode.o
> > +sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o
> > +sm750fb-objs += ddk750_dvi.o ddk750_hwi2c.o
>
> ...and while this fixes the long lines for sure, a more common way is
> to use backslashes at the end of the lines. Compare it with other
> similar cases: you don't need to do something like:
> drivers/staging/wfx/Makefile
>
> but what's done for example in:
> drivers/staging/comedi/Makefile
>
Yes. I knew it. But thought preserving maintainer style may be right.
> looks appropriate here (using 3 or 4 lines I guess).
>
> If you send another version of this patch, don't forget to indicate
> that under "---", see recent discussions on the outreachy-kernel list
> for examples.
>
I note
> Stefano
>
Regards,
Veera
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: sm750fb: makefile variable longline fix
2020-03-12 1:14 ` Veera
@ 2020-03-12 10:42 ` Stefano Brivio
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Brivio @ 2020-03-12 10:42 UTC (permalink / raw)
To: Veera; +Cc: Greg Kroah-Hartman, Sudip Mukherjee, Teddy Wang, outreachy-kernel
On Thu, 12 Mar 2020 06:44:46 +0530
Veera <vkor@vkten.in> wrote:
> On Wed, Mar 11, 2020 at 05:58:39PM +0100, Stefano Brivio wrote:
> >
> > On Wed, 11 Mar 2020 18:41:02 +0530
> > R Veera Kumar <vkor@vkten.in> wrote:
> >
> > > -sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o
> > > -sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o
> > > +sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o
> > > +sm750fb-objs += ddk750_chip.o ddk750_power.o ddk750_mode.o
> > > +sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o
> > > +sm750fb-objs += ddk750_dvi.o ddk750_hwi2c.o
> >
> > ...and while this fixes the long lines for sure, a more common way is
> > to use backslashes at the end of the lines. Compare it with other
> > similar cases: you don't need to do something like:
> > drivers/staging/wfx/Makefile
> >
> > but what's done for example in:
> > drivers/staging/comedi/Makefile
> >
>
> Yes. I knew it. But thought preserving maintainer style may be right.
As a general rule, absolutely, but I wonder if we can even define a
"style" here at all. It's also the single occurrence of this, in this
file, and for this driver altogether.
--
Stefano
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-12 10:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 13:11 [PATCH] staging: sm750fb: makefile variable longline fix R Veera Kumar
2020-03-11 16:58 ` [Outreachy kernel] " Stefano Brivio
2020-03-12 1:14 ` Veera
2020-03-12 10:42 ` Stefano Brivio
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.