All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: "Leonard Crestez" <leonard.crestez@nxp.com>,
	"MyungJoo Ham" <myungjoo.ham@samsung.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Matthias Kaehlcke" <mka@chromium.org>,
	"Adam Ford" <aford173@gmail.com>,
	"Artur Świgoń" <a.swigon@samsung.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Viresh Kumar" <vireshk@kernel.org>,
	linux-imx@nxp.com, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PM / devfreq: Fix handling dev_pm_qos_remove_request result
Date: Thu, 12 Mar 2020 09:31:30 +0300	[thread overview]
Message-ID: <20200312061800.GE11583@kadam> (raw)
In-Reply-To: <780efc9c-a85f-ef9f-e64f-68e5edce4cd3@samsung.com>

On Thu, Mar 12, 2020 at 12:30:42PM +0900, Chanwoo Choi wrote:
> On 3/12/20 12:15 PM, Leonard Crestez wrote:
> > The dev_pm_qos_remove_request function can return 1 if
> > "aggregated constraint value has changed" so only negative values should
> > be reported as errors.
> > 
> > Fixes: 27dbc542f651 ("PM / devfreq: Use PM QoS for sysfs min/max_freq")
> > 
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>

Since you're resending anyway, could you remove the blank line after the
Fixes tag?  All the tags go together at the end.  (The blank line does
not matter at all to anyone, purely aesthetic).

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: linux-pm@vger.kernel.org, "Viresh Kumar" <vireshk@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Artur Świgoń" <a.swigon@samsung.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Matthias Kaehlcke" <mka@chromium.org>,
	"MyungJoo Ham" <myungjoo.ham@samsung.com>,
	"Leonard Crestez" <leonard.crestez@nxp.com>,
	"Adam Ford" <aford173@gmail.com>,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com
Subject: Re: [PATCH] PM / devfreq: Fix handling dev_pm_qos_remove_request result
Date: Thu, 12 Mar 2020 09:31:30 +0300	[thread overview]
Message-ID: <20200312061800.GE11583@kadam> (raw)
In-Reply-To: <780efc9c-a85f-ef9f-e64f-68e5edce4cd3@samsung.com>

On Thu, Mar 12, 2020 at 12:30:42PM +0900, Chanwoo Choi wrote:
> On 3/12/20 12:15 PM, Leonard Crestez wrote:
> > The dev_pm_qos_remove_request function can return 1 if
> > "aggregated constraint value has changed" so only negative values should
> > be reported as errors.
> > 
> > Fixes: 27dbc542f651 ("PM / devfreq: Use PM QoS for sysfs min/max_freq")
> > 
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>

Since you're resending anyway, could you remove the blank line after the
Fixes tag?  All the tags go together at the end.  (The blank line does
not matter at all to anyone, purely aesthetic).

regards,
dan carpenter


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-03-12  6:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200312031520epcas1p3ae8085a7d85da5b41776136f61ad40a3@epcas1p3.samsung.com>
2020-03-12  3:15 ` [PATCH] PM / devfreq: Fix handling dev_pm_qos_remove_request result Leonard Crestez
2020-03-12  3:15   ` Leonard Crestez
2020-03-12  3:30   ` Chanwoo Choi
2020-03-12  3:30     ` Chanwoo Choi
2020-03-12  6:31     ` Dan Carpenter [this message]
2020-03-12  6:31       ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200312061800.GE11583@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=a.swigon@samsung.com \
    --cc=aford173@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=rjw@rjwysocki.net \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.