From: Srikar Dronamraju <srikar@linux.vnet.ibm.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>, linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>, Michael Ellerman <mpe@ellerman.id.au>, Sachin Sant <sachinp@linux.vnet.ibm.com>, Michal Hocko <mhocko@kernel.org>, Christopher Lameter <cl@linux.com>, linuxppc-dev@lists.ozlabs.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Kirill Tkhai <ktkhai@virtuozzo.com>, Vlastimil Babka <vbabka@suse.cz>, Bharata B Rao <bharata@linux.ibm.com> Subject: [PATCH 3/4] mm: Implement reset_numa_mem Date: Tue, 17 Mar 2020 18:47:52 +0530 [thread overview] Message-ID: <20200317131753.4074-4-srikar@linux.vnet.ibm.com> (raw) In-Reply-To: <20200317131753.4074-1-srikar@linux.vnet.ibm.com> For a memoryless or offline nodes, node_numa_mem refers to a N_MEMORY fallback node. Currently kernel has an API set_numa_mem that sets node_numa_mem for memoryless node. However this API cannot be used for offline nodes. Hence all offline nodes will have their node_numa_mem set to 0. However systems can themselves have node 0 as offline i.e memoryless and cpuless at this time. In such cases, node_to_mem_node() fails to provide a N_MEMORY fallback node. Mitigate this by having a new API that sets the default node_numa_mem for offline nodes to be first_memory_node. Cc: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org Cc: Mel Gorman <mgorman@suse.de> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Sachin Sant <sachinp@linux.vnet.ibm.com> Cc: Michal Hocko <mhocko@kernel.org> Cc: Christopher Lameter <cl@linux.com> Cc: linuxppc-dev@lists.ozlabs.org Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Kirill Tkhai <ktkhai@virtuozzo.com> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Cc: Bharata B Rao <bharata@linux.ibm.com> Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com> Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> --- include/asm-generic/topology.h | 3 +++ include/linux/topology.h | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/include/asm-generic/topology.h b/include/asm-generic/topology.h index 238873739550..e803ee7850e6 100644 --- a/include/asm-generic/topology.h +++ b/include/asm-generic/topology.h @@ -68,6 +68,9 @@ #ifndef set_numa_mem #define set_numa_mem(node) #endif +#ifndef reset_numa_mem +#define reset_numa_mem(node) +#endif #ifndef set_cpu_numa_mem #define set_cpu_numa_mem(cpu, node) #endif diff --git a/include/linux/topology.h b/include/linux/topology.h index eb2fe6edd73c..bebda80038bf 100644 --- a/include/linux/topology.h +++ b/include/linux/topology.h @@ -147,6 +147,13 @@ static inline int node_to_mem_node(int node) } #endif +#ifndef reset_numa_mem +static inline void reset_numa_mem(int node) +{ + _node_numa_mem_[node] = first_memory_node; +} +#endif + #ifndef numa_mem_id /* Returns the number of the nearest Node with memory */ static inline int numa_mem_id(void) -- 2.18.1
WARNING: multiple messages have this Message-ID (diff)
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: Sachin Sant <sachinp@linux.vnet.ibm.com>, Srikar Dronamraju <srikar@linux.vnet.ibm.com>, Michal Hocko <mhocko@kernel.org>, linux-mm@kvack.org, Kirill Tkhai <ktkhai@virtuozzo.com>, Mel Gorman <mgorman@suse.de>, Christopher Lameter <cl@linux.com>, Bharata B Rao <bharata@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Vlastimil Babka <vbabka@suse.cz> Subject: [PATCH 3/4] mm: Implement reset_numa_mem Date: Tue, 17 Mar 2020 18:47:52 +0530 [thread overview] Message-ID: <20200317131753.4074-4-srikar@linux.vnet.ibm.com> (raw) In-Reply-To: <20200317131753.4074-1-srikar@linux.vnet.ibm.com> For a memoryless or offline nodes, node_numa_mem refers to a N_MEMORY fallback node. Currently kernel has an API set_numa_mem that sets node_numa_mem for memoryless node. However this API cannot be used for offline nodes. Hence all offline nodes will have their node_numa_mem set to 0. However systems can themselves have node 0 as offline i.e memoryless and cpuless at this time. In such cases, node_to_mem_node() fails to provide a N_MEMORY fallback node. Mitigate this by having a new API that sets the default node_numa_mem for offline nodes to be first_memory_node. Cc: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org Cc: Mel Gorman <mgorman@suse.de> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Sachin Sant <sachinp@linux.vnet.ibm.com> Cc: Michal Hocko <mhocko@kernel.org> Cc: Christopher Lameter <cl@linux.com> Cc: linuxppc-dev@lists.ozlabs.org Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Kirill Tkhai <ktkhai@virtuozzo.com> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Cc: Bharata B Rao <bharata@linux.ibm.com> Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com> Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> --- include/asm-generic/topology.h | 3 +++ include/linux/topology.h | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/include/asm-generic/topology.h b/include/asm-generic/topology.h index 238873739550..e803ee7850e6 100644 --- a/include/asm-generic/topology.h +++ b/include/asm-generic/topology.h @@ -68,6 +68,9 @@ #ifndef set_numa_mem #define set_numa_mem(node) #endif +#ifndef reset_numa_mem +#define reset_numa_mem(node) +#endif #ifndef set_cpu_numa_mem #define set_cpu_numa_mem(cpu, node) #endif diff --git a/include/linux/topology.h b/include/linux/topology.h index eb2fe6edd73c..bebda80038bf 100644 --- a/include/linux/topology.h +++ b/include/linux/topology.h @@ -147,6 +147,13 @@ static inline int node_to_mem_node(int node) } #endif +#ifndef reset_numa_mem +static inline void reset_numa_mem(int node) +{ + _node_numa_mem_[node] = first_memory_node; +} +#endif + #ifndef numa_mem_id /* Returns the number of the nearest Node with memory */ static inline int numa_mem_id(void) -- 2.18.1
next prev parent reply other threads:[~2020-03-17 13:20 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-18 10:45 [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9 Sachin Sant 2020-02-18 10:50 ` Kirill Tkhai 2020-02-18 10:50 ` Kirill Tkhai 2020-02-18 11:01 ` Kirill Tkhai 2020-02-18 11:01 ` Kirill Tkhai 2020-02-18 11:35 ` Kirill Tkhai 2020-02-18 11:35 ` Kirill Tkhai 2020-02-18 11:40 ` Sachin Sant 2020-02-18 11:55 ` Michal Hocko 2020-02-18 11:55 ` Michal Hocko 2020-02-18 14:00 ` Sachin Sant 2020-02-18 14:00 ` Sachin Sant 2020-02-18 14:26 ` Michal Hocko 2020-02-18 14:26 ` Michal Hocko 2020-02-18 15:11 ` Sachin Sant 2020-02-18 15:11 ` Sachin Sant 2020-02-18 15:24 ` Michal Hocko 2020-02-18 15:24 ` Michal Hocko 2020-02-22 3:38 ` Christopher Lameter 2020-02-22 3:38 ` Christopher Lameter 2020-02-24 8:58 ` Michal Hocko 2020-02-24 8:58 ` Michal Hocko 2020-02-26 18:25 ` Christopher Lameter 2020-02-26 18:25 ` Christopher Lameter 2020-02-26 18:41 ` Michal Hocko 2020-02-26 18:41 ` Michal Hocko 2020-02-26 18:44 ` Christopher Lameter 2020-02-26 18:44 ` Christopher Lameter 2020-02-26 19:01 ` Michal Hocko 2020-02-26 19:01 ` Michal Hocko 2020-02-26 20:31 ` David Rientjes 2020-02-26 20:31 ` David Rientjes 2020-02-26 20:52 ` Michal Hocko 2020-02-26 20:52 ` Michal Hocko 2020-02-26 21:45 ` Vlastimil Babka 2020-02-26 21:45 ` Vlastimil Babka 2020-02-26 22:29 ` Vlastimil Babka 2020-02-26 22:29 ` Vlastimil Babka 2020-02-27 12:12 ` Michal Hocko 2020-02-27 12:12 ` Michal Hocko 2020-02-27 16:00 ` Sachin Sant 2020-02-27 16:00 ` Sachin Sant 2020-02-27 16:16 ` Vlastimil Babka 2020-02-27 18:26 ` Michal Hocko 2020-02-27 18:26 ` Michal Hocko 2020-03-10 15:01 ` Michal Hocko 2020-03-10 15:01 ` Michal Hocko 2020-03-12 12:18 ` Michael Ellerman 2020-03-12 12:18 ` Michael Ellerman 2020-03-12 16:51 ` Sachin Sant 2020-03-12 16:51 ` Sachin Sant 2020-03-13 10:48 ` Michael Ellerman 2020-03-13 10:48 ` Michael Ellerman 2020-03-13 11:12 ` Srikar Dronamraju 2020-03-13 11:12 ` Srikar Dronamraju 2020-03-13 11:35 ` Vlastimil Babka 2020-03-13 11:35 ` Vlastimil Babka 2020-03-14 8:10 ` Sachin Sant 2020-02-27 12:02 ` Michal Hocko 2020-02-27 12:02 ` Michal Hocko 2020-02-18 11:38 ` Sachin Sant 2020-02-18 11:53 ` Kirill Tkhai 2020-03-17 13:17 ` [PATCH 0/4] Fix kmalloc_node on offline nodes Srikar Dronamraju 2020-03-17 13:17 ` Srikar Dronamraju 2020-03-17 13:17 ` [PATCH 1/4] mm: Check for node_online in node_present_pages Srikar Dronamraju 2020-03-17 13:17 ` Srikar Dronamraju 2020-03-17 13:37 ` Srikar Dronamraju 2020-03-17 13:37 ` Srikar Dronamraju 2020-03-17 13:17 ` [PATCH 2/4] mm/slub: Use mem_node to allocate a new slab Srikar Dronamraju 2020-03-17 13:17 ` Srikar Dronamraju 2020-03-17 13:34 ` Vlastimil Babka 2020-03-17 13:34 ` Vlastimil Babka 2020-03-17 13:45 ` Srikar Dronamraju 2020-03-17 13:45 ` Srikar Dronamraju 2020-03-17 13:53 ` Vlastimil Babka 2020-03-17 13:53 ` Vlastimil Babka 2020-03-17 14:51 ` Srikar Dronamraju 2020-03-17 14:51 ` Srikar Dronamraju 2020-03-17 15:29 ` Vlastimil Babka 2020-03-17 15:29 ` Vlastimil Babka 2020-03-18 7:29 ` Srikar Dronamraju 2020-03-18 7:29 ` Srikar Dronamraju 2020-03-17 16:41 ` Srikar Dronamraju 2020-03-17 16:41 ` Srikar Dronamraju 2020-03-17 13:17 ` Srikar Dronamraju [this message] 2020-03-17 13:17 ` [PATCH 3/4] mm: Implement reset_numa_mem Srikar Dronamraju 2020-03-17 13:17 ` [PATCH 4/4] powerpc/numa: Set fallback nodes for offline nodes Srikar Dronamraju 2020-03-17 13:17 ` Srikar Dronamraju 2020-03-17 14:22 ` Bharata B Rao 2020-03-17 14:22 ` Bharata B Rao 2020-03-17 14:29 ` Srikar Dronamraju 2020-03-17 14:29 ` Srikar Dronamraju
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200317131753.4074-4-srikar@linux.vnet.ibm.com \ --to=srikar@linux.vnet.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=bharata@linux.ibm.com \ --cc=cl@linux.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=ktkhai@virtuozzo.com \ --cc=linux-mm@kvack.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mgorman@suse.de \ --cc=mhocko@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=sachinp@linux.vnet.ibm.com \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.