From: "Theodore Ts'o" <tytso@mit.edu> To: Ext4 Developers List <linux-ext4@vger.kernel.org>, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org Cc: "Theodore Ts'o" <tytso@mit.edu> Subject: [PATCH 2/2] writeback, xfs: call dirty_inode() with I_DIRTY_TIME_EXPIRED when appropriate Date: Thu, 19 Mar 2020 22:52:55 -0400 [thread overview] Message-ID: <20200320025255.1705972-2-tytso@mit.edu> (raw) In-Reply-To: <20200320025255.1705972-1-tytso@mit.edu> Use the flag I_DIRTY_TIME_EXPIRED passed to dirty_inode() to signal to the file system that it is time to flush the inode's timestamps to stable storage. Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- fs/fs-writeback.c | 2 +- fs/xfs/xfs_super.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 867454997c9d..32101349ba97 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -1506,7 +1506,7 @@ __writeback_single_inode(struct inode *inode, struct writeback_control *wbc) /* This was a lazytime expiration; we need to tell the file system */ if (dirty & I_DIRTY_TIME_EXPIRED && inode->i_sb->s_op->dirty_inode) - inode->i_sb->s_op->dirty_inode(inode, I_DIRTY_SYNC); + inode->i_sb->s_op->dirty_inode(inode, I_DIRTY_TIME_EXPIRED); /* Don't write the inode if only I_DIRTY_PAGES was set */ if (dirty & ~I_DIRTY_PAGES) { int err = write_inode(inode, wbc); diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 2094386af8ac..f27b9b205f81 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -622,7 +622,8 @@ xfs_fs_dirty_inode( if (!(inode->i_sb->s_flags & SB_LAZYTIME)) return; - if (flag != I_DIRTY_SYNC || !(inode->i_state & I_DIRTY_TIME)) + if ((flag != I_DIRTY_SYNC && flag != I_DIRTY_TIME_EXPIRED) || + !(inode->i_state & I_DIRTY_TIME)) return; if (xfs_trans_alloc(mp, &M_RES(mp)->tr_fsyncts, 0, 0, 0, &tp)) -- 2.24.1
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu> To: Ext4 Developers List <linux-ext4@vger.kernel.org>, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org Cc: Theodore Ts'o <tytso@mit.edu> Subject: [f2fs-dev] [PATCH 2/2] writeback, xfs: call dirty_inode() with I_DIRTY_TIME_EXPIRED when appropriate Date: Thu, 19 Mar 2020 22:52:55 -0400 [thread overview] Message-ID: <20200320025255.1705972-2-tytso@mit.edu> (raw) In-Reply-To: <20200320025255.1705972-1-tytso@mit.edu> Use the flag I_DIRTY_TIME_EXPIRED passed to dirty_inode() to signal to the file system that it is time to flush the inode's timestamps to stable storage. Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- fs/fs-writeback.c | 2 +- fs/xfs/xfs_super.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 867454997c9d..32101349ba97 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -1506,7 +1506,7 @@ __writeback_single_inode(struct inode *inode, struct writeback_control *wbc) /* This was a lazytime expiration; we need to tell the file system */ if (dirty & I_DIRTY_TIME_EXPIRED && inode->i_sb->s_op->dirty_inode) - inode->i_sb->s_op->dirty_inode(inode, I_DIRTY_SYNC); + inode->i_sb->s_op->dirty_inode(inode, I_DIRTY_TIME_EXPIRED); /* Don't write the inode if only I_DIRTY_PAGES was set */ if (dirty & ~I_DIRTY_PAGES) { int err = write_inode(inode, wbc); diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 2094386af8ac..f27b9b205f81 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -622,7 +622,8 @@ xfs_fs_dirty_inode( if (!(inode->i_sb->s_flags & SB_LAZYTIME)) return; - if (flag != I_DIRTY_SYNC || !(inode->i_state & I_DIRTY_TIME)) + if ((flag != I_DIRTY_SYNC && flag != I_DIRTY_TIME_EXPIRED) || + !(inode->i_state & I_DIRTY_TIME)) return; if (xfs_trans_alloc(mp, &M_RES(mp)->tr_fsyncts, 0, 0, 0, &tp)) -- 2.24.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-03-20 2:53 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-06 0:45 lazytime causing inodes to remain dirty after sync? Eric Biggers 2020-03-06 0:45 ` [f2fs-dev] " Eric Biggers 2020-03-07 2:00 ` [PATCH] writeback: avoid double-writing the inode on a lazytime expiration Theodore Ts'o 2020-03-07 2:00 ` [f2fs-dev] " Theodore Ts'o 2020-03-11 3:20 ` Eric Biggers 2020-03-11 3:20 ` [f2fs-dev] " Eric Biggers 2020-03-11 12:57 ` Theodore Y. Ts'o 2020-03-11 12:57 ` [f2fs-dev] " Theodore Y. Ts'o 2020-03-12 0:07 ` Dave Chinner 2020-03-12 0:07 ` [f2fs-dev] " Dave Chinner 2020-03-12 14:34 ` Christoph Hellwig 2020-03-12 14:34 ` [f2fs-dev] " Christoph Hellwig 2020-03-12 22:39 ` Dave Chinner 2020-03-12 22:39 ` [f2fs-dev] " Dave Chinner 2020-03-20 2:46 ` Theodore Y. Ts'o 2020-03-20 2:46 ` [f2fs-dev] " Theodore Y. Ts'o 2020-03-20 2:52 ` [PATCH 1/2] " Theodore Ts'o 2020-03-20 2:52 ` [f2fs-dev] " Theodore Ts'o 2020-03-20 2:52 ` Theodore Ts'o [this message] 2020-03-20 2:52 ` [f2fs-dev] [PATCH 2/2] writeback, xfs: call dirty_inode() with I_DIRTY_TIME_EXPIRED when appropriate Theodore Ts'o 2020-03-23 17:58 ` Theodore Y. Ts'o 2020-03-23 17:58 ` [f2fs-dev] " Theodore Y. Ts'o 2020-03-24 8:37 ` Christoph Hellwig 2020-03-24 8:37 ` [f2fs-dev] " Christoph Hellwig 2020-03-24 18:43 ` Theodore Y. Ts'o 2020-03-24 18:43 ` [f2fs-dev] " Theodore Y. Ts'o 2020-03-25 9:20 ` [PATCH 1/2] writeback: avoid double-writing the inode on a lazytime expiration Christoph Hellwig 2020-03-25 9:20 ` [f2fs-dev] " Christoph Hellwig 2020-03-25 15:21 ` Theodore Y. Ts'o 2020-03-25 15:21 ` [f2fs-dev] " Theodore Y. Ts'o 2020-03-25 15:47 ` Darrick J. Wong 2020-03-25 15:47 ` [f2fs-dev] " Darrick J. Wong 2020-03-11 23:54 ` [PATCH] " Dave Chinner 2020-03-11 23:54 ` [f2fs-dev] " Dave Chinner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200320025255.1705972-2-tytso@mit.edu \ --to=tytso@mit.edu \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-xfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.