From: David Disseldorp <ddiss@suse.de> To: target-devel@vger.kernel.org Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, bvanassche@acm.org, David Disseldorp <ddiss@suse.de> Subject: [PATCH v3 4/5] scsi: target: increase XCOPY I/O size Date: Fri, 27 Mar 2020 14:19:53 +0000 [thread overview] Message-ID: <20200327141954.955-5-ddiss@suse.de> (raw) In-Reply-To: <20200327141954.955-1-ddiss@suse.de> The I/O size is already bound by dev_attrib.hw_max_sectors, so increase the hardcoded XCOPY_MAX_SECTORS maximum to improve performance against backstores with high-latency. Signed-off-by: David Disseldorp <ddiss@suse.de> Reviewed-by: Christoph Hellwig <hch@lst.de> --- drivers/target/target_core_xcopy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/target_core_xcopy.h b/drivers/target/target_core_xcopy.h index 9558974185ea..f1aaf7140798 100644 --- a/drivers/target/target_core_xcopy.h +++ b/drivers/target/target_core_xcopy.h @@ -5,7 +5,7 @@ #define XCOPY_TARGET_DESC_LEN 32 #define XCOPY_SEGMENT_DESC_LEN 28 #define XCOPY_NAA_IEEE_REGEX_LEN 16 -#define XCOPY_MAX_SECTORS 1024 +#define XCOPY_MAX_SECTORS 4096 /* * SPC4r37 6.4.6.1 -- 2.16.4
WARNING: multiple messages have this Message-ID (diff)
From: David Disseldorp <ddiss@suse.de> To: target-devel@vger.kernel.org Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, bvanassche@acm.org, David Disseldorp <ddiss@suse.de> Subject: [PATCH v3 4/5] scsi: target: increase XCOPY I/O size Date: Fri, 27 Mar 2020 15:19:53 +0100 [thread overview] Message-ID: <20200327141954.955-5-ddiss@suse.de> (raw) In-Reply-To: <20200327141954.955-1-ddiss@suse.de> The I/O size is already bound by dev_attrib.hw_max_sectors, so increase the hardcoded XCOPY_MAX_SECTORS maximum to improve performance against backstores with high-latency. Signed-off-by: David Disseldorp <ddiss@suse.de> Reviewed-by: Christoph Hellwig <hch@lst.de> --- drivers/target/target_core_xcopy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/target_core_xcopy.h b/drivers/target/target_core_xcopy.h index 9558974185ea..f1aaf7140798 100644 --- a/drivers/target/target_core_xcopy.h +++ b/drivers/target/target_core_xcopy.h @@ -5,7 +5,7 @@ #define XCOPY_TARGET_DESC_LEN 32 #define XCOPY_SEGMENT_DESC_LEN 28 #define XCOPY_NAA_IEEE_REGEX_LEN 16 -#define XCOPY_MAX_SECTORS 1024 +#define XCOPY_MAX_SECTORS 4096 /* * SPC4r37 6.4.6.1 -- 2.16.4
next prev parent reply other threads:[~2020-03-27 14:19 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-27 14:19 [PATCH v3 0/5] scsi: target: XCOPY performance David Disseldorp 2020-03-27 14:19 ` David Disseldorp 2020-03-27 14:19 ` [PATCH v3 1/5] scsi: target: use #def for xcopy descriptor len David Disseldorp 2020-03-27 14:19 ` David Disseldorp 2020-03-27 14:19 ` [PATCH v3 2/5] scsi: target: drop xcopy DISK BLOCK LENGTH debug David Disseldorp 2020-03-27 14:19 ` David Disseldorp 2020-03-27 14:19 ` [PATCH v3 3/5] scsi: target: avoid per-loop XCOPY buffer allocations David Disseldorp 2020-03-27 14:19 ` David Disseldorp 2020-03-27 14:19 ` David Disseldorp [this message] 2020-03-27 14:19 ` [PATCH v3 4/5] scsi: target: increase XCOPY I/O size David Disseldorp 2020-03-27 14:19 ` [PATCH v3 5/5] scsi: target: use the stack for XCOPY passthrough cmds David Disseldorp 2020-03-27 14:19 ` David Disseldorp 2020-03-27 17:49 ` [PATCH v3 0/5] scsi: target: XCOPY performance Martin K. Petersen 2020-03-27 17:49 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200327141954.955-5-ddiss@suse.de \ --to=ddiss@suse.de \ --cc=bvanassche@acm.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=target-devel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.