From: Oleksij Rempel <o.rempel@pengutronix.de> To: Andrew Lunn <andrew@lunn.ch> Cc: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>, linux-kernel@vger.kernel.org, Fabio Estevam <festevam@gmail.com>, linux-imx@nxp.com, kernel@pengutronix.de, David Jander <david@protonic.nl>, Russell King <linux@armlinux.org.uk>, Shawn Guo <shawnguo@kernel.org>, linux-arm-kernel@lists.infradead.org, Heiner Kallweit <hkallweit1@gmail.com> Subject: Re: [PATCH v2] ARM: imx: allow to disable board specific PHY fixups Date: Mon, 30 Mar 2020 07:26:11 +0200 [thread overview] Message-ID: <20200330052611.2bgu7x4nmimf7pru@pengutronix.de> (raw) In-Reply-To: <20200329150854.GA31812@lunn.ch> Hi Andrew, On Sun, Mar 29, 2020 at 05:08:54PM +0200, Andrew Lunn wrote: > On Sun, Mar 29, 2020 at 01:04:57PM +0200, Oleksij Rempel wrote: > > Hi Oleksij > > > +config DEPRECATED_PHY_FIXUPS > > + bool "Enable deprecated PHY fixups" > > + default y > > + ---help--- > > + In the early days it was common practice to configure PHYs by adding a > > + phy_register_fixup*() in the machine code. This practice turned out to > > + be potentially dangerous, because: > > + - it affects all PHYs in the system > > + - these register changes are usually not preserved during PHY reset > > + or suspend/resume cycle. > > + - it complicates debugging, since these configuration changes were not > > + done by the actual PHY driver. > > + This option allows to disable all fixups which are identified as > > + potentially harmful and give the developers a chance to implement the > > + proper configuration via the device tree (e.g.: phy-mode) and/or the > > + related PHY drivers. > > This appears to be an IMX only problem. Everybody else seems to of got > this right. There is no need to bother everybody with this new > option. Please put this in arch/arm/mach-mxs/Kconfig and have IMX in > the name. Actually, all fixups seems to do wring thing: arch/arm/mach-davinci/board-dm644x-evm.c:915: phy_register_fixup_for_uid(LXT971_PHY_ID, LXT971_PHY_MASK, Increased MII drive strength. Should be probably enabled by the PHY driver. arch/arm/mach-imx/mach-imx6q.c:167: phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK, arch/arm/mach-imx/mach-imx6q.c:169: phy_register_fixup_for_uid(PHY_ID_KSZ9031, MICREL_PHY_ID_MASK, arch/arm/mach-imx/mach-imx6q.c:171: phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffef, arch/arm/mach-imx/mach-imx6q.c:173: phy_register_fixup_for_uid(PHY_ID_AR8035, 0xffffffef, arch/arm/mach-imx/mach-imx6sx.c:40: phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffff, arch/arm/mach-imx/mach-imx6ul.c:47: phy_register_fixup_for_uid(PHY_ID_KSZ8081, MICREL_PHY_ID_MASK, arch/arm/mach-imx/mach-imx7d.c:54: phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffff, arch/arm/mach-imx/mach-imx7d.c:56: phy_register_fixup_for_uid(PHY_ID_BCM54220, 0xffffffff, arch/arm/mach-mxs/mach-mxs.c:262: phy_register_fixup_for_uid(PHY_ID_KSZ8051, MICREL_PHY_ID_MASK, Fix in some random manner PHY specific errata, enable clock output and configure the clock skew. arch/arm/mach-orion5x/dns323-setup.c:645: phy_register_fixup_for_uid(MARVELL_PHY_ID_88E1118, Enable LED. Should be done in DT if supported. arch/powerpc/platforms/85xx/mpc85xx_mds.c:305: phy_register_fixup_for_id(phy_id, mpc8568_fixup_125_clock); arch/powerpc/platforms/85xx/mpc85xx_mds.c:306: phy_register_fixup_for_id(phy_id, mpc8568_mds_phy_fixups); arch/powerpc/platforms/85xx/mpc85xx_mds.c:311: phy_register_fixup_for_id(phy_id, mpc8568_mds_phy_fixups); Fix in some random manner PHY specific errata, enable clock output and configure the clock skew. drivers/net/ethernet/dnet.c:818: err = phy_register_fixup_for_uid(0x01410cc0, 0xfffffff0, Enable LED. Should be done in DT if supported. drivers/net/usb/lan78xx.c:2071: ret = phy_register_fixup_for_uid(PHY_KSZ9031RNX, 0xfffffff0, drivers/net/usb/lan78xx.c:2078: ret = phy_register_fixup_for_uid(PHY_LAN8835, 0xfffffff0, enable clock output and configure the clock skew. As we can see, all of used fixups seem to be wrong. For example micrel PHY errata should be fixed in one place for all devices. Not only for some iMX6 SoC. I used this option for iMX, because i can test it. > There is no need to bother everybody with this new > option. Please put this in arch/arm/mach-mxs/Kconfig and have IMX in > the name. A lot of work is needed to fix all of them. I just do not have enough time to do it. > Having said that, i'm not sure this is the best solution. You cannot > build one kernel which runs on all machines. Did you consider some > sort of DT property to disable these fixup? What other ideas did you > have before deciding on this solution? As soon as all PHY driver support all needed bits used in this fixups, we can use drivers on top of fixups. Since changes made by fixups will be overwritten by PHY drivers any way. The Kconfig option is needed only for developers who has enough resource to investigate this issues and mainline needed changes. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <o.rempel@pengutronix.de> To: Andrew Lunn <andrew@lunn.ch> Cc: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>, linux-kernel@vger.kernel.org, Russell King <linux@armlinux.org.uk>, linux-imx@nxp.com, kernel@pengutronix.de, David Jander <david@protonic.nl>, Shawn Guo <shawnguo@kernel.org>, Fabio Estevam <festevam@gmail.com>, linux-arm-kernel@lists.infradead.org, Heiner Kallweit <hkallweit1@gmail.com> Subject: Re: [PATCH v2] ARM: imx: allow to disable board specific PHY fixups Date: Mon, 30 Mar 2020 07:26:11 +0200 [thread overview] Message-ID: <20200330052611.2bgu7x4nmimf7pru@pengutronix.de> (raw) In-Reply-To: <20200329150854.GA31812@lunn.ch> Hi Andrew, On Sun, Mar 29, 2020 at 05:08:54PM +0200, Andrew Lunn wrote: > On Sun, Mar 29, 2020 at 01:04:57PM +0200, Oleksij Rempel wrote: > > Hi Oleksij > > > +config DEPRECATED_PHY_FIXUPS > > + bool "Enable deprecated PHY fixups" > > + default y > > + ---help--- > > + In the early days it was common practice to configure PHYs by adding a > > + phy_register_fixup*() in the machine code. This practice turned out to > > + be potentially dangerous, because: > > + - it affects all PHYs in the system > > + - these register changes are usually not preserved during PHY reset > > + or suspend/resume cycle. > > + - it complicates debugging, since these configuration changes were not > > + done by the actual PHY driver. > > + This option allows to disable all fixups which are identified as > > + potentially harmful and give the developers a chance to implement the > > + proper configuration via the device tree (e.g.: phy-mode) and/or the > > + related PHY drivers. > > This appears to be an IMX only problem. Everybody else seems to of got > this right. There is no need to bother everybody with this new > option. Please put this in arch/arm/mach-mxs/Kconfig and have IMX in > the name. Actually, all fixups seems to do wring thing: arch/arm/mach-davinci/board-dm644x-evm.c:915: phy_register_fixup_for_uid(LXT971_PHY_ID, LXT971_PHY_MASK, Increased MII drive strength. Should be probably enabled by the PHY driver. arch/arm/mach-imx/mach-imx6q.c:167: phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK, arch/arm/mach-imx/mach-imx6q.c:169: phy_register_fixup_for_uid(PHY_ID_KSZ9031, MICREL_PHY_ID_MASK, arch/arm/mach-imx/mach-imx6q.c:171: phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffef, arch/arm/mach-imx/mach-imx6q.c:173: phy_register_fixup_for_uid(PHY_ID_AR8035, 0xffffffef, arch/arm/mach-imx/mach-imx6sx.c:40: phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffff, arch/arm/mach-imx/mach-imx6ul.c:47: phy_register_fixup_for_uid(PHY_ID_KSZ8081, MICREL_PHY_ID_MASK, arch/arm/mach-imx/mach-imx7d.c:54: phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffff, arch/arm/mach-imx/mach-imx7d.c:56: phy_register_fixup_for_uid(PHY_ID_BCM54220, 0xffffffff, arch/arm/mach-mxs/mach-mxs.c:262: phy_register_fixup_for_uid(PHY_ID_KSZ8051, MICREL_PHY_ID_MASK, Fix in some random manner PHY specific errata, enable clock output and configure the clock skew. arch/arm/mach-orion5x/dns323-setup.c:645: phy_register_fixup_for_uid(MARVELL_PHY_ID_88E1118, Enable LED. Should be done in DT if supported. arch/powerpc/platforms/85xx/mpc85xx_mds.c:305: phy_register_fixup_for_id(phy_id, mpc8568_fixup_125_clock); arch/powerpc/platforms/85xx/mpc85xx_mds.c:306: phy_register_fixup_for_id(phy_id, mpc8568_mds_phy_fixups); arch/powerpc/platforms/85xx/mpc85xx_mds.c:311: phy_register_fixup_for_id(phy_id, mpc8568_mds_phy_fixups); Fix in some random manner PHY specific errata, enable clock output and configure the clock skew. drivers/net/ethernet/dnet.c:818: err = phy_register_fixup_for_uid(0x01410cc0, 0xfffffff0, Enable LED. Should be done in DT if supported. drivers/net/usb/lan78xx.c:2071: ret = phy_register_fixup_for_uid(PHY_KSZ9031RNX, 0xfffffff0, drivers/net/usb/lan78xx.c:2078: ret = phy_register_fixup_for_uid(PHY_LAN8835, 0xfffffff0, enable clock output and configure the clock skew. As we can see, all of used fixups seem to be wrong. For example micrel PHY errata should be fixed in one place for all devices. Not only for some iMX6 SoC. I used this option for iMX, because i can test it. > There is no need to bother everybody with this new > option. Please put this in arch/arm/mach-mxs/Kconfig and have IMX in > the name. A lot of work is needed to fix all of them. I just do not have enough time to do it. > Having said that, i'm not sure this is the best solution. You cannot > build one kernel which runs on all machines. Did you consider some > sort of DT property to disable these fixup? What other ideas did you > have before deciding on this solution? As soon as all PHY driver support all needed bits used in this fixups, we can use drivers on top of fixups. Since changes made by fixups will be overwritten by PHY drivers any way. The Kconfig option is needed only for developers who has enough resource to investigate this issues and mainline needed changes. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-30 5:26 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-29 11:04 [PATCH v2] ARM: imx: allow to disable board specific PHY fixups Oleksij Rempel 2020-03-29 11:04 ` Oleksij Rempel 2020-03-29 15:08 ` Andrew Lunn 2020-03-29 15:08 ` Andrew Lunn 2020-03-30 5:26 ` Oleksij Rempel [this message] 2020-03-30 5:26 ` Oleksij Rempel 2020-03-30 17:33 ` Florian Fainelli 2020-03-30 17:33 ` Florian Fainelli 2020-03-30 17:41 ` Russell King - ARM Linux admin 2020-03-30 17:41 ` Russell King - ARM Linux admin 2020-03-31 7:47 ` Marc Kleine-Budde 2020-03-31 7:47 ` Marc Kleine-Budde 2020-03-31 7:54 ` Russell King - ARM Linux admin 2020-03-31 7:54 ` Russell King - ARM Linux admin 2020-03-31 8:00 ` Marc Kleine-Budde 2020-03-31 8:00 ` Marc Kleine-Budde 2020-03-31 8:19 ` Russell King - ARM Linux admin 2020-03-31 8:19 ` Russell King - ARM Linux admin 2020-04-01 6:33 ` Oleksij Rempel 2020-04-01 6:33 ` Oleksij Rempel 2020-04-01 17:10 ` Florian Fainelli 2020-04-01 17:10 ` Florian Fainelli 2020-03-31 8:06 ` Philippe Schenker 2020-03-31 8:06 ` Philippe Schenker 2020-03-31 8:44 ` David Jander 2020-03-31 8:44 ` David Jander 2020-03-31 9:36 ` Russell King - ARM Linux admin 2020-03-31 9:36 ` Russell King - ARM Linux admin 2020-03-31 15:41 ` David Jander 2020-03-31 15:41 ` David Jander 2020-03-31 15:53 ` Russell King - ARM Linux admin 2020-03-31 15:53 ` Russell King - ARM Linux admin 2020-03-31 12:54 ` Andrew Lunn 2020-03-31 12:54 ` Andrew Lunn 2020-03-31 15:15 ` Russell King - ARM Linux admin 2020-03-31 15:15 ` Russell King - ARM Linux admin 2020-03-31 15:40 ` Vladimir Oltean 2020-03-31 15:40 ` Vladimir Oltean 2020-03-31 17:03 ` Russell King - ARM Linux admin 2020-03-31 17:03 ` Russell King - ARM Linux admin 2020-03-31 17:16 ` Oleksij Rempel 2020-03-31 17:16 ` Oleksij Rempel 2020-03-31 17:46 ` Russell King - ARM Linux admin 2020-03-31 17:46 ` Russell King - ARM Linux admin 2020-03-31 13:45 ` Oleksij Rempel 2020-03-31 13:45 ` Oleksij Rempel 2020-03-31 14:08 ` Russell King - ARM Linux admin 2020-03-31 14:08 ` Russell King - ARM Linux admin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200330052611.2bgu7x4nmimf7pru@pengutronix.de \ --to=o.rempel@pengutronix.de \ --cc=andrew@lunn.ch \ --cc=david@protonic.nl \ --cc=f.fainelli@gmail.com \ --cc=festevam@gmail.com \ --cc=hkallweit1@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=netdev@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.