* [PATCH v8] staging: vt6656: add error code handling to unused variable
@ 2020-03-30 23:39 ` John B. Wyatt IV
0 siblings, 0 replies; 6+ messages in thread
From: John B. Wyatt IV @ 2020-03-30 23:39 UTC (permalink / raw)
To: outreachy-kernel, Julia Lawall, Stefano Brivio, Forest Bond,
Greg Kroah-Hartman, Quentin Deslandes, Colin Ian King,
Malcolm Priestley, devel, linux-kernel
Cc: John B. Wyatt IV
Add error code handling to unused 'ret' variable that was never used.
Return an error code from functions called within vnt_radio_power_on.
Issue reported by coccinelle (coccicheck).
Suggested-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
Suggested-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
---
v8: Fix trailing space reported by checkpatch
Fix alignment issue suggested by:
Stefano Brivio <sbrivio@redhat.com>
v7: Move an if check.
Suggested by Stefano Brivio <sbrivio@redhat.com>
v6: Forgot to add all the v5 code to commit.
v5: Remove Suggested-by: Julia Lawall above seperator line.
Remove break; statement in switch block.
break; removal checked by both gcc compile and checkpatch.
Suggested by Stefano Brivio <sbrivio@redhat.com>
v4: Move Suggested-by: Julia Lawall above seperator line.
Add Reviewed-by tag as requested by Quentin Deslandes.
v3: Forgot to add v2 code changes to commit.
v2: Replace goto statements with return.
Remove last if check because it was unneeded.
Suggested-by: Julia Lawall <julia.lawall@inria.fr>
drivers/staging/vt6656/card.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index dc3ab10eb630..1ef1f6b22195 100644
--- a/drivers/staging/vt6656/card.c
+++ b/drivers/staging/vt6656/card.c
@@ -723,9 +723,13 @@ int vnt_radio_power_on(struct vnt_private *priv)
{
int ret = 0;
- vnt_exit_deep_sleep(priv);
+ ret = vnt_exit_deep_sleep(priv);
+ if (ret)
+ return ret;
- vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON);
+ ret = vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON);
+ if (ret)
+ return ret;
switch (priv->rf_type) {
case RF_AL2230:
@@ -734,14 +738,14 @@ int vnt_radio_power_on(struct vnt_private *priv)
case RF_VT3226:
case RF_VT3226D0:
case RF_VT3342A0:
- vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,
- (SOFTPWRCTL_SWPE2 | SOFTPWRCTL_SWPE3));
- break;
+ ret = vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,
+ (SOFTPWRCTL_SWPE2 |
+ SOFTPWRCTL_SWPE3));
+ if (ret)
+ return ret;
}
- vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);
-
- return ret;
+ return vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);
}
void vnt_set_bss_mode(struct vnt_private *priv)
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v8] staging: vt6656: add error code handling to unused variable
@ 2020-03-30 23:39 ` John B. Wyatt IV
0 siblings, 0 replies; 6+ messages in thread
From: John B. Wyatt IV @ 2020-03-30 23:39 UTC (permalink / raw)
To: outreachy-kernel, Julia Lawall, Stefano Brivio, Forest Bond,
Greg Kroah-Hartman, Quentin Deslandes, Colin Ian King,
Malcolm Priestley, devel, linux-kernel
Cc: John B. Wyatt IV
Add error code handling to unused 'ret' variable that was never used.
Return an error code from functions called within vnt_radio_power_on.
Issue reported by coccinelle (coccicheck).
Suggested-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
Suggested-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
---
v8: Fix trailing space reported by checkpatch
Fix alignment issue suggested by:
Stefano Brivio <sbrivio@redhat.com>
v7: Move an if check.
Suggested by Stefano Brivio <sbrivio@redhat.com>
v6: Forgot to add all the v5 code to commit.
v5: Remove Suggested-by: Julia Lawall above seperator line.
Remove break; statement in switch block.
break; removal checked by both gcc compile and checkpatch.
Suggested by Stefano Brivio <sbrivio@redhat.com>
v4: Move Suggested-by: Julia Lawall above seperator line.
Add Reviewed-by tag as requested by Quentin Deslandes.
v3: Forgot to add v2 code changes to commit.
v2: Replace goto statements with return.
Remove last if check because it was unneeded.
Suggested-by: Julia Lawall <julia.lawall@inria.fr>
drivers/staging/vt6656/card.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index dc3ab10eb630..1ef1f6b22195 100644
--- a/drivers/staging/vt6656/card.c
+++ b/drivers/staging/vt6656/card.c
@@ -723,9 +723,13 @@ int vnt_radio_power_on(struct vnt_private *priv)
{
int ret = 0;
- vnt_exit_deep_sleep(priv);
+ ret = vnt_exit_deep_sleep(priv);
+ if (ret)
+ return ret;
- vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON);
+ ret = vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON);
+ if (ret)
+ return ret;
switch (priv->rf_type) {
case RF_AL2230:
@@ -734,14 +738,14 @@ int vnt_radio_power_on(struct vnt_private *priv)
case RF_VT3226:
case RF_VT3226D0:
case RF_VT3342A0:
- vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,
- (SOFTPWRCTL_SWPE2 | SOFTPWRCTL_SWPE3));
- break;
+ ret = vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,
+ (SOFTPWRCTL_SWPE2 |
+ SOFTPWRCTL_SWPE3));
+ if (ret)
+ return ret;
}
- vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);
-
- return ret;
+ return vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);
}
void vnt_set_bss_mode(struct vnt_private *priv)
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v8] staging: vt6656: add error code handling to unused variable
2020-03-30 23:39 ` John B. Wyatt IV
@ 2020-03-31 0:01 ` Stefano Brivio
-1 siblings, 0 replies; 6+ messages in thread
From: Stefano Brivio @ 2020-03-31 0:01 UTC (permalink / raw)
To: John B. Wyatt IV
Cc: outreachy-kernel, Julia Lawall, Forest Bond, Greg Kroah-Hartman,
Quentin Deslandes, Colin Ian King, Malcolm Priestley, devel,
linux-kernel
On Mon, 30 Mar 2020 16:39:00 -0700
"John B. Wyatt IV" <jbwyatt4@gmail.com> wrote:
> Add error code handling to unused 'ret' variable that was never used.
> Return an error code from functions called within vnt_radio_power_on.
>
> Issue reported by coccinelle (coccicheck).
>
> Suggested-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
^ This should be dropped unless Quentin agrees to this version as well
> Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v8] staging: vt6656: add error code handling to unused variable
@ 2020-03-31 0:01 ` Stefano Brivio
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Brivio @ 2020-03-31 0:01 UTC (permalink / raw)
To: John B. Wyatt IV
Cc: devel, Malcolm Priestley, Greg Kroah-Hartman, linux-kernel,
Julia Lawall, outreachy-kernel, Forest Bond, Colin Ian King
On Mon, 30 Mar 2020 16:39:00 -0700
"John B. Wyatt IV" <jbwyatt4@gmail.com> wrote:
> Add error code handling to unused 'ret' variable that was never used.
> Return an error code from functions called within vnt_radio_power_on.
>
> Issue reported by coccinelle (coccicheck).
>
> Suggested-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
^ This should be dropped unless Quentin agrees to this version as well
> Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v8] staging: vt6656: add error code handling to unused variable
2020-03-31 0:01 ` Stefano Brivio
@ 2020-03-31 8:29 ` Quentin Deslandes
-1 siblings, 0 replies; 6+ messages in thread
From: Quentin Deslandes @ 2020-03-31 8:29 UTC (permalink / raw)
To: Stefano Brivio
Cc: John B. Wyatt IV, outreachy-kernel, Julia Lawall, Forest Bond,
Greg Kroah-Hartman, Colin Ian King, Malcolm Priestley, devel,
linux-kernel
On 03/31/20 02:01:03, Stefano Brivio wrote:
> On Mon, 30 Mar 2020 16:39:00 -0700
> "John B. Wyatt IV" <jbwyatt4@gmail.com> wrote:
>
> > Add error code handling to unused 'ret' variable that was never used.
> > Return an error code from functions called within vnt_radio_power_on.
> >
> > Issue reported by coccinelle (coccicheck).
> >
> > Suggested-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
> > Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> > Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
> ^ This should be dropped unless Quentin agrees to this version as well
>
> > Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
>
> --
> Stefano
>
Just reviewed it so John doesn't need to send a v9. Everything seems
good, I'm happy and checkpatch is too.
Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
Thanks,
Quentin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v8] staging: vt6656: add error code handling to unused variable
@ 2020-03-31 8:29 ` Quentin Deslandes
0 siblings, 0 replies; 6+ messages in thread
From: Quentin Deslandes @ 2020-03-31 8:29 UTC (permalink / raw)
To: Stefano Brivio
Cc: devel, John B. Wyatt IV, Malcolm Priestley, Greg Kroah-Hartman,
linux-kernel, Julia Lawall, outreachy-kernel, Forest Bond,
Colin Ian King
On 03/31/20 02:01:03, Stefano Brivio wrote:
> On Mon, 30 Mar 2020 16:39:00 -0700
> "John B. Wyatt IV" <jbwyatt4@gmail.com> wrote:
>
> > Add error code handling to unused 'ret' variable that was never used.
> > Return an error code from functions called within vnt_radio_power_on.
> >
> > Issue reported by coccinelle (coccicheck).
> >
> > Suggested-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
> > Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> > Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
> ^ This should be dropped unless Quentin agrees to this version as well
>
> > Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
>
> --
> Stefano
>
Just reviewed it so John doesn't need to send a v9. Everything seems
good, I'm happy and checkpatch is too.
Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
Thanks,
Quentin
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-31 8:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 23:39 [PATCH v8] staging: vt6656: add error code handling to unused variable John B. Wyatt IV
2020-03-30 23:39 ` John B. Wyatt IV
2020-03-31 0:01 ` Stefano Brivio
2020-03-31 0:01 ` Stefano Brivio
2020-03-31 8:29 ` Quentin Deslandes
2020-03-31 8:29 ` Quentin Deslandes
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.