From: Sudeep Holla <sudeep.holla@arm.com> To: Cristian Marussi <cristian.marussi@arm.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lukasz.luba@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, Sudeep Holla <sudeep.holla@arm.com> Subject: Re: [PATCH v6 01/13] firmware: arm_scmi: Add receive buffer support for notifications Date: Tue, 7 Apr 2020 10:36:29 +0100 [thread overview] Message-ID: <20200407093629.GB28444@bogus> (raw) In-Reply-To: <20200327143438.5382-2-cristian.marussi@arm.com> On Fri, Mar 27, 2020 at 02:34:26PM +0000, Cristian Marussi wrote: > From: Sudeep Holla <sudeep.holla@arm.com> > > With all the plumbing in place, let's just add the separate dedicated > receive buffers to handle notifications that can arrive asynchronously > from the platform firmware to OS. > > Also add one check to see if the platform supports any receive channels > before allocating the receive buffers: since those buffers are optionally > supported though, the whole xfer initialization is also postponed to be > able to check for their existence in advance. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > [Changed parameters in __scmi_xfer_info_init()] > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> [...] > @@ -566,6 +568,16 @@ static int scmi_xfer_info_init(struct scmi_info *sinfo) > return 0; > } > > +static int scmi_xfer_info_init(struct scmi_info *sinfo) > +{ > + int ret = __scmi_xfer_info_init(sinfo, &sinfo->tx_minfo); > + > + if (!ret && idr_find(&sinfo->rx_idr, SCMI_PROTOCOL_BASE)) Theoretically, this could be bit tricky if we need to support platforms without Rx channel for base protocol but may have Rx for some specific protocols. But we have other problems too, so we can address that if required in future. Anyways, the first 4 patches are simple and quite independent from the notification part. I will queue them as is and you can drop if you respin the series. I may need some time to go through the series completely and I am trying to comment as I go through individual patches as I may get answers to my own questions as I review. -- Regards, Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com> To: Cristian Marussi <cristian.marussi@arm.com> Cc: Jonathan.Cameron@Huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Sudeep Holla <sudeep.holla@arm.com>, lukasz.luba@arm.com Subject: Re: [PATCH v6 01/13] firmware: arm_scmi: Add receive buffer support for notifications Date: Tue, 7 Apr 2020 10:36:29 +0100 [thread overview] Message-ID: <20200407093629.GB28444@bogus> (raw) In-Reply-To: <20200327143438.5382-2-cristian.marussi@arm.com> On Fri, Mar 27, 2020 at 02:34:26PM +0000, Cristian Marussi wrote: > From: Sudeep Holla <sudeep.holla@arm.com> > > With all the plumbing in place, let's just add the separate dedicated > receive buffers to handle notifications that can arrive asynchronously > from the platform firmware to OS. > > Also add one check to see if the platform supports any receive channels > before allocating the receive buffers: since those buffers are optionally > supported though, the whole xfer initialization is also postponed to be > able to check for their existence in advance. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > [Changed parameters in __scmi_xfer_info_init()] > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> [...] > @@ -566,6 +568,16 @@ static int scmi_xfer_info_init(struct scmi_info *sinfo) > return 0; > } > > +static int scmi_xfer_info_init(struct scmi_info *sinfo) > +{ > + int ret = __scmi_xfer_info_init(sinfo, &sinfo->tx_minfo); > + > + if (!ret && idr_find(&sinfo->rx_idr, SCMI_PROTOCOL_BASE)) Theoretically, this could be bit tricky if we need to support platforms without Rx channel for base protocol but may have Rx for some specific protocols. But we have other problems too, so we can address that if required in future. Anyways, the first 4 patches are simple and quite independent from the notification part. I will queue them as is and you can drop if you respin the series. I may need some time to go through the series completely and I am trying to comment as I go through individual patches as I may get answers to my own questions as I review. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-07 9:36 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-27 14:34 [PATCH v6 00/13] SCMI Notifications Core Support Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 01/13] firmware: arm_scmi: Add receive buffer support for notifications Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-04-07 9:36 ` Sudeep Holla [this message] 2020-04-07 9:36 ` Sudeep Holla 2020-03-27 14:34 ` [PATCH v6 02/13] firmware: arm_scmi: Update protocol commands and notification list Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 03/13] firmware: arm_scmi: Add notifications support in transport layer Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 04/13] firmware: arm_scmi: Add support for notifications message processing Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 05/13] firmware: arm_scmi: Add notification protocol-registration Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 06/13] firmware: arm_scmi: Add notification callbacks-registration Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 07/13] firmware: arm_scmi: Add notification dispatch and delivery Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 08/13] firmware: arm_scmi: Enable notification core Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 09/13] firmware: arm_scmi: Add Power notifications support Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 10/13] firmware: arm_scmi: Add Perf " Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 11/13] firmware: arm_scmi: Add Sensor " Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 12/13] firmware: arm_scmi: Add Reset " Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi 2020-03-27 14:34 ` [PATCH v6 13/13] firmware: arm_scmi: Add Base " Cristian Marussi 2020-03-27 14:34 ` Cristian Marussi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200407093629.GB28444@bogus \ --to=sudeep.holla@arm.com \ --cc=Jonathan.Cameron@Huawei.com \ --cc=cristian.marussi@arm.com \ --cc=james.quinlan@broadcom.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lukasz.luba@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.