From: Mark Brown <broonie@kernel.org> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, alsa-devel@alsa-project.org, tiwai@suse.de, Daniel Matuschek <daniel@hifiberry.com>, Matthias Reichl <hias@horus.com>, Hui Wang <hui.wang@canonical.com>, linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, linux-clk@vger.kernel.org, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org> Subject: Re: [RFC PATCH 03/16] ASoC: Intel: sof-pcm512x: use gpiod for LED Date: Tue, 14 Apr 2020 18:52:05 +0100 [thread overview] Message-ID: <20200414175205.GL5412@sirena.org.uk> (raw) In-Reply-To: <20200414171752.GC34613@smile.fi.intel.com> [-- Attachment #1: Type: text/plain, Size: 345 bytes --] On Tue, Apr 14, 2020 at 08:17:52PM +0300, Andy Shevchenko wrote: > On Thu, Apr 09, 2020 at 02:58:28PM -0500, Pierre-Louis Bossart wrote: > > + GPIO_LOOKUP("pcm512x-gpio", 3, "PCM512x-GPIO4", GPIO_ACTIVE_HIGH), > It says GPIO 4 and here is number 3. > Does this 4 come from hardware documentation? Yes, the first GPIO in the device is GPIO1. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: alsa-devel@alsa-project.org, Rob Herring <robh+dt@kernel.org>, linux-gpio@vger.kernel.org, tiwai@suse.de, Linus Walleij <linus.walleij@linaro.org>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Daniel Matuschek <daniel@hifiberry.com>, Hui Wang <hui.wang@canonical.com>, Matthias Reichl <hias@horus.com>, Michael Turquette <mturquette@baylibre.com>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org Subject: Re: [RFC PATCH 03/16] ASoC: Intel: sof-pcm512x: use gpiod for LED Date: Tue, 14 Apr 2020 18:52:05 +0100 [thread overview] Message-ID: <20200414175205.GL5412@sirena.org.uk> (raw) In-Reply-To: <20200414171752.GC34613@smile.fi.intel.com> [-- Attachment #1: Type: text/plain, Size: 345 bytes --] On Tue, Apr 14, 2020 at 08:17:52PM +0300, Andy Shevchenko wrote: > On Thu, Apr 09, 2020 at 02:58:28PM -0500, Pierre-Louis Bossart wrote: > > + GPIO_LOOKUP("pcm512x-gpio", 3, "PCM512x-GPIO4", GPIO_ACTIVE_HIGH), > It says GPIO 4 and here is number 3. > Does this 4 come from hardware documentation? Yes, the first GPIO in the device is GPIO1. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-04-14 17:52 UTC|newest] Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-09 19:58 [RFC PATCH 00/16] ASoC/SOF/clk/gpio/dt: add Hifiberry DAC+ PRO support Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-09 19:58 ` [RFC PATCH 01/16] ASoC: pcm512x: expose 6 GPIOs Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-14 17:09 ` Andy Shevchenko 2020-04-14 17:09 ` Andy Shevchenko 2020-04-14 17:52 ` Pierre-Louis Bossart 2020-04-14 17:52 ` Pierre-Louis Bossart 2020-04-15 9:49 ` Andy Shevchenko 2020-04-15 9:49 ` Andy Shevchenko 2020-04-16 11:42 ` Linus Walleij 2020-04-16 11:42 ` Linus Walleij 2020-04-16 14:25 ` Pierre-Louis Bossart 2020-04-16 14:25 ` Pierre-Louis Bossart 2020-04-09 19:58 ` [RFC PATCH 02/16] ASoC: pcm512x: use "sclk" string to retrieve clock Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-14 17:11 ` Andy Shevchenko 2020-04-14 17:11 ` Andy Shevchenko 2020-04-14 17:54 ` Pierre-Louis Bossart 2020-04-14 17:54 ` Pierre-Louis Bossart 2020-04-15 9:52 ` Andy Shevchenko 2020-04-15 9:52 ` Andy Shevchenko 2020-04-15 14:19 ` Pierre-Louis Bossart 2020-04-15 14:19 ` Pierre-Louis Bossart 2020-04-15 15:10 ` Andy Shevchenko 2020-04-15 15:10 ` Andy Shevchenko 2020-04-14 17:45 ` Mark Brown 2020-04-14 17:45 ` Mark Brown 2020-04-14 18:14 ` Pierre-Louis Bossart 2020-04-14 18:14 ` Pierre-Louis Bossart 2020-04-14 18:27 ` Mark Brown 2020-04-14 18:27 ` Mark Brown 2020-04-14 19:15 ` Pierre-Louis Bossart 2020-04-14 19:15 ` Pierre-Louis Bossart 2020-04-14 19:50 ` Mark Brown 2020-04-14 19:50 ` Mark Brown 2020-04-14 20:13 ` Pierre-Louis Bossart 2020-04-14 20:13 ` Pierre-Louis Bossart 2020-04-14 21:02 ` Pierre-Louis Bossart 2020-04-14 21:02 ` Pierre-Louis Bossart 2020-04-15 11:07 ` Mark Brown 2020-04-15 11:07 ` Mark Brown 2020-04-15 11:36 ` Mark Brown 2020-04-15 11:36 ` Mark Brown 2020-04-15 14:44 ` Pierre-Louis Bossart 2020-04-15 14:44 ` Pierre-Louis Bossart 2020-04-15 16:22 ` Mark Brown 2020-04-15 16:22 ` Mark Brown 2020-04-15 17:26 ` Pierre-Louis Bossart 2020-04-15 17:26 ` Pierre-Louis Bossart 2020-04-15 19:50 ` Mark Brown 2020-04-15 19:50 ` Mark Brown 2020-04-15 20:22 ` Pierre-Louis Bossart 2020-04-15 20:22 ` Pierre-Louis Bossart 2020-04-15 20:39 ` Mark Brown 2020-04-15 20:39 ` Mark Brown 2020-04-09 19:58 ` [RFC PATCH 03/16] ASoC: Intel: sof-pcm512x: use gpiod for LED Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-14 17:17 ` Andy Shevchenko 2020-04-14 17:17 ` Andy Shevchenko 2020-04-14 17:52 ` Mark Brown [this message] 2020-04-14 17:52 ` Mark Brown 2020-04-14 17:57 ` Pierre-Louis Bossart 2020-04-14 17:57 ` Pierre-Louis Bossart 2020-04-15 9:51 ` Andy Shevchenko 2020-04-15 9:51 ` Andy Shevchenko 2020-04-09 19:58 ` [RFC PATCH 04/16] ASoC: Intel: sof-pcm512x: detect Hifiberry DAC+ PRO Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-14 17:20 ` Andy Shevchenko 2020-04-14 17:20 ` Andy Shevchenko 2020-04-14 18:02 ` Pierre-Louis Bossart 2020-04-14 18:02 ` Pierre-Louis Bossart 2020-04-15 9:55 ` Andy Shevchenko 2020-04-15 9:55 ` Andy Shevchenko 2020-04-15 14:07 ` Pierre-Louis Bossart 2020-04-15 14:07 ` Pierre-Louis Bossart 2020-04-15 15:05 ` Andy Shevchenko 2020-04-15 15:05 ` Andy Shevchenko 2020-04-09 19:58 ` [RFC PATCH 05/16] ASoC: Intel: sof-pcm512x: reconfigure sclk in hw_params if needed Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-14 17:24 ` Andy Shevchenko 2020-04-14 17:24 ` Andy Shevchenko 2020-04-14 18:06 ` Pierre-Louis Bossart 2020-04-14 18:06 ` Pierre-Louis Bossart 2020-04-09 19:58 ` [RFC PATCH 06/16] ASoC: Intel: sof-pcm512x: select HIFIBERRY_DACPRO clk Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-09 19:58 ` [RFC PATCH 07/16] clk: hifiberry-dacpro: initial import Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-14 17:31 ` Andy Shevchenko 2020-04-14 17:31 ` Andy Shevchenko 2020-04-14 18:09 ` Pierre-Louis Bossart 2020-04-14 18:09 ` Pierre-Louis Bossart 2020-04-15 10:00 ` Andy Shevchenko 2020-04-15 10:00 ` Andy Shevchenko 2020-04-09 19:58 ` [RFC PATCH 08/16] clk: hifiberry-dacpro: update SDPX/copyright Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-09 19:58 ` [RFC PATCH 09/16] clk: hifiberry-dacpro: style cleanups, use devm_ Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-09 19:58 ` [RFC PATCH 10/16] clk: hifiberry-dacpro: add OF dependency Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-09 19:58 ` [RFC PATCH 11/16] clk: hifiberry-dacpro: transition to _hw functions Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-09 19:58 ` [RFC PATCH 12/16] clk: hifiberry-dacpro: add ACPI support Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-22 9:32 ` Stephen Boyd 2020-04-22 9:32 ` Stephen Boyd 2020-04-22 9:47 ` Andy Shevchenko 2020-04-22 9:47 ` Andy Shevchenko 2020-04-22 9:54 ` Pierre-Louis Bossart 2020-04-22 9:54 ` Pierre-Louis Bossart 2020-04-22 20:52 ` Stephen Boyd 2020-04-22 20:52 ` Stephen Boyd 2020-04-22 21:08 ` Pierre-Louis Bossart 2020-04-22 21:08 ` Pierre-Louis Bossart 2020-04-09 19:58 ` [RFC PATCH 13/16] clk: hifiberry-dacpro: add "sclk" lookup Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-22 9:35 ` Stephen Boyd 2020-04-22 9:35 ` Stephen Boyd 2020-04-22 9:51 ` Pierre-Louis Bossart 2020-04-22 9:51 ` Pierre-Louis Bossart 2020-04-22 11:54 ` Andy Shevchenko 2020-04-22 11:54 ` Andy Shevchenko 2020-04-09 19:58 ` [RFC PATCH 14/16] clk: hifiberry-dacpro: toggle GPIOs on prepare/unprepare Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-09 19:58 ` [RFC PATCH 15/16] clk: hifiberry-dacpro: add delay on clock prepare/deprepare Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-09 19:58 ` [RFC PATCH 16/16] ASoC: dt-bindings: add document for Hifiberry DAC+ PRO clock Pierre-Louis Bossart 2020-04-09 19:58 ` Pierre-Louis Bossart 2020-04-14 17:27 ` Andy Shevchenko 2020-04-14 17:27 ` Andy Shevchenko 2020-04-14 18:10 ` Pierre-Louis Bossart 2020-04-14 18:10 ` Pierre-Louis Bossart 2020-04-14 16:50 ` [RFC PATCH 00/16] ASoC/SOF/clk/gpio/dt: add Hifiberry DAC+ PRO support Andy Shevchenko 2020-04-14 16:50 ` Andy Shevchenko 2020-04-14 16:57 ` Pierre-Louis Bossart 2020-04-14 16:57 ` Pierre-Louis Bossart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200414175205.GL5412@sirena.org.uk \ --to=broonie@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=bgolaszewski@baylibre.com \ --cc=daniel@hifiberry.com \ --cc=hias@horus.com \ --cc=hui.wang@canonical.com \ --cc=linus.walleij@linaro.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.