* [PATCH] x86/unwind/orc: make some symbols static
@ 2020-04-13 8:22 Jason Yan
2020-04-14 9:22 ` Miroslav Benes
0 siblings, 1 reply; 3+ messages in thread
From: Jason Yan @ 2020-04-13 8:22 UTC (permalink / raw)
To: tglx, mingo, bp, hpa, x86, peterz, jpoimboe, shile.zhang,
yanaijie, linux-kernel
Cc: Hulk Robot
Fix the following sparse warning:
arch/x86/kernel/unwind_orc.c:19:5: warning: symbol 'cur_orc_ip_table'
was not declared. Should it be static?
arch/x86/kernel/unwind_orc.c:20:18: warning: symbol 'cur_orc_table' was
not declared. Should it be static?
arch/x86/kernel/unwind_orc.c:22:14: warning: symbol 'lookup_num_blocks'
was not declared. Should it be static?
arch/x86/kernel/unwind_orc.c:23:6: warning: symbol 'orc_init' was not
declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
arch/x86/kernel/unwind_orc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
index e9cc182aa97e..0dbabc469ce2 100644
--- a/arch/x86/kernel/unwind_orc.c
+++ b/arch/x86/kernel/unwind_orc.c
@@ -16,11 +16,11 @@ extern struct orc_entry __start_orc_unwind[];
extern struct orc_entry __stop_orc_unwind[];
static DEFINE_MUTEX(sort_mutex);
-int *cur_orc_ip_table = __start_orc_unwind_ip;
-struct orc_entry *cur_orc_table = __start_orc_unwind;
+static int *cur_orc_ip_table = __start_orc_unwind_ip;
+static struct orc_entry *cur_orc_table = __start_orc_unwind;
-unsigned int lookup_num_blocks;
-bool orc_init;
+static unsigned int lookup_num_blocks;
+static bool orc_init;
static inline unsigned long orc_ip(const int *ip)
{
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/unwind/orc: make some symbols static
2020-04-13 8:22 [PATCH] x86/unwind/orc: make some symbols static Jason Yan
@ 2020-04-14 9:22 ` Miroslav Benes
2020-04-14 22:24 ` Josh Poimboeuf
0 siblings, 1 reply; 3+ messages in thread
From: Miroslav Benes @ 2020-04-14 9:22 UTC (permalink / raw)
To: Jason Yan
Cc: tglx, mingo, bp, hpa, x86, peterz, jpoimboe, shile.zhang,
linux-kernel, Hulk Robot
On Mon, 13 Apr 2020, Jason Yan wrote:
> Fix the following sparse warning:
>
> arch/x86/kernel/unwind_orc.c:19:5: warning: symbol 'cur_orc_ip_table'
> was not declared. Should it be static?
> arch/x86/kernel/unwind_orc.c:20:18: warning: symbol 'cur_orc_table' was
> not declared. Should it be static?
> arch/x86/kernel/unwind_orc.c:22:14: warning: symbol 'lookup_num_blocks'
> was not declared. Should it be static?
> arch/x86/kernel/unwind_orc.c:23:6: warning: symbol 'orc_init' was not
> declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> arch/x86/kernel/unwind_orc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
> index e9cc182aa97e..0dbabc469ce2 100644
> --- a/arch/x86/kernel/unwind_orc.c
> +++ b/arch/x86/kernel/unwind_orc.c
> @@ -16,11 +16,11 @@ extern struct orc_entry __start_orc_unwind[];
> extern struct orc_entry __stop_orc_unwind[];
>
> static DEFINE_MUTEX(sort_mutex);
> -int *cur_orc_ip_table = __start_orc_unwind_ip;
> -struct orc_entry *cur_orc_table = __start_orc_unwind;
> +static int *cur_orc_ip_table = __start_orc_unwind_ip;
> +static struct orc_entry *cur_orc_table = __start_orc_unwind;
>
> -unsigned int lookup_num_blocks;
> -bool orc_init;
> +static unsigned int lookup_num_blocks;
> +static bool orc_init;
>
> static inline unsigned long orc_ip(const int *ip)
> {
> --
Thanks for the patch, but Josh already fixed it in
https://lore.kernel.org/lkml/63b5cab2e28b9c08854fc57f5b512a9ccf76ad95.1584033751.git.jpoimboe@redhat.com/
Josh, any plans to add the patch set into the current queue?
Miroslav
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/unwind/orc: make some symbols static
2020-04-14 9:22 ` Miroslav Benes
@ 2020-04-14 22:24 ` Josh Poimboeuf
0 siblings, 0 replies; 3+ messages in thread
From: Josh Poimboeuf @ 2020-04-14 22:24 UTC (permalink / raw)
To: Miroslav Benes
Cc: Jason Yan, tglx, mingo, bp, hpa, x86, peterz, shile.zhang,
linux-kernel, Hulk Robot
On Tue, Apr 14, 2020 at 11:22:50AM +0200, Miroslav Benes wrote:
> On Mon, 13 Apr 2020, Jason Yan wrote:
>
> > Fix the following sparse warning:
> >
> > arch/x86/kernel/unwind_orc.c:19:5: warning: symbol 'cur_orc_ip_table'
> > was not declared. Should it be static?
> > arch/x86/kernel/unwind_orc.c:20:18: warning: symbol 'cur_orc_table' was
> > not declared. Should it be static?
> > arch/x86/kernel/unwind_orc.c:22:14: warning: symbol 'lookup_num_blocks'
> > was not declared. Should it be static?
> > arch/x86/kernel/unwind_orc.c:23:6: warning: symbol 'orc_init' was not
> > declared. Should it be static?
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Jason Yan <yanaijie@huawei.com>
> > ---
> > arch/x86/kernel/unwind_orc.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
> > index e9cc182aa97e..0dbabc469ce2 100644
> > --- a/arch/x86/kernel/unwind_orc.c
> > +++ b/arch/x86/kernel/unwind_orc.c
> > @@ -16,11 +16,11 @@ extern struct orc_entry __start_orc_unwind[];
> > extern struct orc_entry __stop_orc_unwind[];
> >
> > static DEFINE_MUTEX(sort_mutex);
> > -int *cur_orc_ip_table = __start_orc_unwind_ip;
> > -struct orc_entry *cur_orc_table = __start_orc_unwind;
> > +static int *cur_orc_ip_table = __start_orc_unwind_ip;
> > +static struct orc_entry *cur_orc_table = __start_orc_unwind;
> >
> > -unsigned int lookup_num_blocks;
> > -bool orc_init;
> > +static unsigned int lookup_num_blocks;
> > +static bool orc_init;
> >
> > static inline unsigned long orc_ip(const int *ip)
> > {
> > --
>
> Thanks for the patch, but Josh already fixed it in
> https://lore.kernel.org/lkml/63b5cab2e28b9c08854fc57f5b512a9ccf76ad95.1584033751.git.jpoimboe@redhat.com/
>
> Josh, any plans to add the patch set into the current queue?
Yeah, I have a v2 coming one of these days...
--
Josh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-14 22:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 8:22 [PATCH] x86/unwind/orc: make some symbols static Jason Yan
2020-04-14 9:22 ` Miroslav Benes
2020-04-14 22:24 ` Josh Poimboeuf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.