All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Andrei Stefanescu <andrei.stefanescu@microchip.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Brendan Higgins <brendanhiggins@google.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Andreas Kemnade <andreas@kemnade.info>,
	"Angelo G. Del Regno" <kholk11@gmail.com>,
	Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
	linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
	Axel Lin <axel.lin@ingics.com>,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Markus Reichl <m.reichl@fivetechno.de>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Chen-Yu Tsai <wens@csie.org>, Andy Gross <agross@kernel.org>,
	markus.laine@fi.rohmeurope.com,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	devicetree@vger.kernel.org,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	mazziesaccount@gmail.com, linux-arm-msm@vger.kernel.org,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Mark Brown <broonie@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	Support Opensource <support.opensource@diasemi.com>,
	Baolin Wang <baolin.wang@linaro.org>,
	Sangbeom Kim <sbkim73@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pm@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
	Sebastian Reichel <sre@kernel.org>,
	linux-kernel@vger.kernel.org, mikko.mutanen@fi.rohmeurope.com,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v10 11/11] power: supply: KConfig cleanup default n
Date: Wed, 15 Apr 2020 13:10:03 +0300	[thread overview]
Message-ID: <20200415101003.GS34613@smile.fi.intel.com> (raw)
In-Reply-To: <b893d0449886a8ffed00bbcc1fcbe34d83b833d3.1586925868.git.matti.vaittinen@fi.rohmeurope.com>

On Wed, Apr 15, 2020 at 08:24:14AM +0300, Matti Vaittinen wrote:
> The "default n" is not needed. Clean the KConfig by removing
> "default n".
> 

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> 
> This was pointed to me first by Randy Dunlap during v4 review.
> I cleaned the BD99954 back then.
> 
> Also Andy Shevchenko mentioned this to me. So as I was
> changing the file anyways... Please just drop this patch out
> of the series if you're not Ok with this.
> 
>  drivers/power/supply/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index ec028e47c3c2..04821d8c9e43 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -660,7 +660,6 @@ config CHARGER_RT9455
>  config CHARGER_CROS_USBPD
>  	tristate "ChromeOS EC based USBPD charger"
>  	depends on CROS_USBPD_NOTIFY
> -	default n
>  	help
>  	  Say Y here to enable ChromeOS EC based USBPD charger
>  	  driver. This driver gets various bits of information about
> @@ -696,7 +695,6 @@ config CHARGER_BD70528
>  	tristate "ROHM bd70528 charger driver"
>  	depends on MFD_ROHM_BD70528
>  	select LINEAR_RANGES
> -	default n
>  	help
>  	  Say Y here to enable support for getting battery status
>  	  information and altering charger configurations from charger
> -- 
> 2.21.0
> 
> 
> -- 
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
> 
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =] 

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Andrei Stefanescu <andrei.stefanescu@microchip.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Brendan Higgins <brendanhiggins@google.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Andreas Kemnade <andreas@kemnade.info>,
	"Angelo G. Del Regno" <kholk11@gmail.com>,
	Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
	linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
	Axel Lin <axel.lin@ingics.com>,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Markus Reichl <m.reichl@fivetechno.de>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Chen-Yu Tsai <wens@csie.org>, Andy Gross <agross@kernel.org>,
	markus.laine@fi.rohmeurope.com,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	devicetree@vger.kernel.org,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	mazziesaccount@gmail.com, linux-arm-msm@vger.kernel.org,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Mark Brown <broonie@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	Support Opensource <support.opensource@diasemi.com>,
	Baolin Wang <baolin.wang@linaro.org>,
	Sangbeom Kim <sbkim73@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pm@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
	Sebastian Reichel <sre@kernel.org>,
	linux-kernel@vger.kernel.org, mikko.mutanen@fi.rohmeurope.com,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v10 11/11] power: supply: KConfig cleanup default n
Date: Wed, 15 Apr 2020 13:10:03 +0300	[thread overview]
Message-ID: <20200415101003.GS34613@smile.fi.intel.com> (raw)
In-Reply-To: <b893d0449886a8ffed00bbcc1fcbe34d83b833d3.1586925868.git.matti.vaittinen@fi.rohmeurope.com>

On Wed, Apr 15, 2020 at 08:24:14AM +0300, Matti Vaittinen wrote:
> The "default n" is not needed. Clean the KConfig by removing
> "default n".
> 

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> 
> This was pointed to me first by Randy Dunlap during v4 review.
> I cleaned the BD99954 back then.
> 
> Also Andy Shevchenko mentioned this to me. So as I was
> changing the file anyways... Please just drop this patch out
> of the series if you're not Ok with this.
> 
>  drivers/power/supply/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index ec028e47c3c2..04821d8c9e43 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -660,7 +660,6 @@ config CHARGER_RT9455
>  config CHARGER_CROS_USBPD
>  	tristate "ChromeOS EC based USBPD charger"
>  	depends on CROS_USBPD_NOTIFY
> -	default n
>  	help
>  	  Say Y here to enable ChromeOS EC based USBPD charger
>  	  driver. This driver gets various bits of information about
> @@ -696,7 +695,6 @@ config CHARGER_BD70528
>  	tristate "ROHM bd70528 charger driver"
>  	depends on MFD_ROHM_BD70528
>  	select LINEAR_RANGES
> -	default n
>  	help
>  	  Say Y here to enable support for getting battery status
>  	  information and altering charger configurations from charger
> -- 
> 2.21.0
> 
> 
> -- 
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
> 
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =] 

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-04-15 10:11 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15  5:16 [PATCH v10 00/11] Support ROHM BD99954 charger IC Matti Vaittinen
2020-04-29  6:52 ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:16 ` [PATCH " Matti Vaittinen
2020-04-15  5:17 ` [PATCH v10 01/11] lib: add linear ranges helpers Matti Vaittinen
2020-04-29  6:53   ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:17   ` [PATCH " Matti Vaittinen
2020-04-15  5:17 ` [PATCH v10 02/11] lib/test_linear_ranges: add a test for the 'linear_ranges' Matti Vaittinen
2020-04-29  6:54   ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:17   ` [PATCH " Matti Vaittinen
2020-04-15  5:18 ` [PATCH v10 03/11] power: supply: bd70528: rename linear_range to avoid collision Matti Vaittinen
2020-04-29  6:56   ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:18   ` [PATCH " Matti Vaittinen
2020-04-15  5:20 ` [PATCH v10 04/11] regulator: use linear_ranges helper Matti Vaittinen
2020-04-29  6:57   ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:20   ` [PATCH " Matti Vaittinen
2020-04-15  5:21 ` [PATCH v10 05/11] power: supply: bd70528: use linear ranges Matti Vaittinen
2020-04-29  6:59   ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:21   ` [PATCH " Matti Vaittinen
2020-04-15  5:21 ` [PATCH v10 06/11] dt-bindings: battery: add new battery parameters Matti Vaittinen
2020-04-29  7:00   ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:21   ` [PATCH " Matti Vaittinen
2020-04-15  5:22 ` [PATCH v10 07/11] power: supply: add " Matti Vaittinen
2020-04-29  7:01   ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:22   ` [PATCH " Matti Vaittinen
2020-04-15  5:22 ` [PATCH v10 08/11] dt_bindings: ROHM BD99954 Charger Matti Vaittinen
2020-04-29  7:03   ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:22   ` [PATCH " Matti Vaittinen
2020-04-15  5:23 ` [PATCH v10 09/11] power: supply: Support ROHM bd99954 charger Matti Vaittinen
2020-04-29  7:04   ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:23   ` [PATCH " Matti Vaittinen
2020-04-15  5:23 ` [PATCH v10 10/11] power: supply: Fix Kconfig help text indentiation Matti Vaittinen
2020-04-29  7:05   ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:23   ` [PATCH " Matti Vaittinen
2020-04-15  5:24 ` [PATCH v10 11/11] power: supply: KConfig cleanup default n Matti Vaittinen
2020-04-29  7:07   ` [RESEND PATCH " Matti Vaittinen
2020-04-15  5:24   ` [PATCH " Matti Vaittinen
2020-04-15 10:10   ` Andy Shevchenko [this message]
2020-04-15 10:10     ` Andy Shevchenko
2020-05-03 15:29 ` [PATCH v10 00/11] Support ROHM BD99954 charger IC Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200415101003.GS34613@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=agross@kernel.org \
    --cc=andreas@kemnade.info \
    --cc=andrei.stefanescu@microchip.com \
    --cc=axel.lin@ingics.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=baolin.wang@linaro.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=brendanhiggins@google.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregory.clement@bootlin.com \
    --cc=heiko@sntech.de \
    --cc=hsin-hsiung.wang@mediatek.com \
    --cc=kholk11@gmail.com \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.reichl@fivetechno.de \
    --cc=mark.rutland@arm.com \
    --cc=markus.laine@fi.rohmeurope.com \
    --cc=matthias.bgg@gmail.com \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mikko.mutanen@fi.rohmeurope.com \
    --cc=patches@opensource.cirrus.com \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rf@opensource.cirrus.com \
    --cc=robh+dt@kernel.org \
    --cc=sbkim73@samsung.com \
    --cc=sre@kernel.org \
    --cc=support.opensource@diasemi.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    --cc=vkoul@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.