* [PATCH 1/2] drm: panel: Set connector type for LP120UP1
@ 2020-04-16 16:44 ` Enric Balletbo i Serra
0 siblings, 0 replies; 12+ messages in thread
From: Enric Balletbo i Serra @ 2020-04-16 16:44 UTC (permalink / raw)
To: linux-kernel
Cc: drinkcat, David Airlie, dri-devel, Thierry Reding,
laurent.pinchart, hsinyi, matthias.bgg, Collabora Kernel ML, sam
The LP120UP1 is a eDP panel, set the connector type accordingly.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/gpu/drm/panel/panel-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3ad828eaefe1..6253635601bb 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2168,6 +2168,7 @@ static const struct panel_desc lg_lp120up1 = {
.width = 267,
.height = 183,
},
+ .connector_type = DRM_MODE_CONNECTOR_eDP,
};
static const struct drm_display_mode lg_lp129qe_mode = {
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector type
2020-04-16 16:44 ` Enric Balletbo i Serra
@ 2020-04-16 16:44 ` Enric Balletbo i Serra
-1 siblings, 0 replies; 12+ messages in thread
From: Enric Balletbo i Serra @ 2020-04-16 16:44 UTC (permalink / raw)
To: linux-kernel
Cc: Collabora Kernel ML, matthias.bgg, drinkcat, hsinyi, sam,
laurent.pinchart, Andrzej Hajda, Daniel Vetter, David Airlie,
Jernej Skrabec, Jonas Karlman, Laurent Pinchart, Neil Armstrong,
dri-devel
The panel connector type should be set by the panel not the bridge, so
remove the connector_type assignment.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
index 956b76e0a44d..13755d278db6 100644
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
@@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
if (!panel)
return -ENODEV;
- panel->connector_type = DRM_MODE_CONNECTOR_eDP;
-
ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
if (IS_ERR(ps_bridge->panel_bridge))
return PTR_ERR(ps_bridge->panel_bridge);
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector type
@ 2020-04-16 16:44 ` Enric Balletbo i Serra
0 siblings, 0 replies; 12+ messages in thread
From: Enric Balletbo i Serra @ 2020-04-16 16:44 UTC (permalink / raw)
To: linux-kernel
Cc: Jernej Skrabec, drinkcat, Jonas Karlman, David Airlie,
Neil Armstrong, dri-devel, Andrzej Hajda, Laurent Pinchart,
hsinyi, matthias.bgg, Collabora Kernel ML, sam
The panel connector type should be set by the panel not the bridge, so
remove the connector_type assignment.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
index 956b76e0a44d..13755d278db6 100644
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
@@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
if (!panel)
return -ENODEV;
- panel->connector_type = DRM_MODE_CONNECTOR_eDP;
-
ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
if (IS_ERR(ps_bridge->panel_bridge))
return PTR_ERR(ps_bridge->panel_bridge);
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector type
2020-04-16 16:44 ` Enric Balletbo i Serra
@ 2020-04-16 17:04 ` Laurent Pinchart
-1 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2020-04-16 17:04 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Collabora Kernel ML, matthias.bgg, drinkcat,
hsinyi, sam, Andrzej Hajda, Daniel Vetter, David Airlie,
Jernej Skrabec, Jonas Karlman, Neil Armstrong, dri-devel
Hi Enric,
Thank you for the patch.
On Thu, Apr 16, 2020 at 06:44:04PM +0200, Enric Balletbo i Serra wrote:
> The panel connector type should be set by the panel not the bridge, so
> remove the connector_type assignment.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 956b76e0a44d..13755d278db6 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
> if (!panel)
> return -ENODEV;
>
> - panel->connector_type = DRM_MODE_CONNECTOR_eDP;
> -
> ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
> if (IS_ERR(ps_bridge->panel_bridge))
> return PTR_ERR(ps_bridge->panel_bridge);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector type
@ 2020-04-16 17:04 ` Laurent Pinchart
0 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2020-04-16 17:04 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Jernej Skrabec, drinkcat, Jonas Karlman, David Airlie,
Neil Armstrong, linux-kernel, dri-devel, Andrzej Hajda, hsinyi,
matthias.bgg, Collabora Kernel ML, sam
Hi Enric,
Thank you for the patch.
On Thu, Apr 16, 2020 at 06:44:04PM +0200, Enric Balletbo i Serra wrote:
> The panel connector type should be set by the panel not the bridge, so
> remove the connector_type assignment.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 956b76e0a44d..13755d278db6 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
> if (!panel)
> return -ENODEV;
>
> - panel->connector_type = DRM_MODE_CONNECTOR_eDP;
> -
> ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
> if (IS_ERR(ps_bridge->panel_bridge))
> return PTR_ERR(ps_bridge->panel_bridge);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector type
2020-04-16 16:44 ` Enric Balletbo i Serra
@ 2020-04-25 14:48 ` Sam Ravnborg
-1 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2020-04-25 14:48 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Jernej Skrabec, drinkcat, Jonas Karlman,
David Airlie, Neil Armstrong, dri-devel, Andrzej Hajda,
Laurent Pinchart, hsinyi, matthias.bgg, Collabora Kernel ML
On Thu, Apr 16, 2020 at 06:44:04PM +0200, Enric Balletbo i Serra wrote:
> The panel connector type should be set by the panel not the bridge, so
> remove the connector_type assignment.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks, applied to drm-misc-next.
Sam
> ---
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 956b76e0a44d..13755d278db6 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
> if (!panel)
> return -ENODEV;
>
> - panel->connector_type = DRM_MODE_CONNECTOR_eDP;
> -
> ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
> if (IS_ERR(ps_bridge->panel_bridge))
> return PTR_ERR(ps_bridge->panel_bridge);
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector type
@ 2020-04-25 14:48 ` Sam Ravnborg
0 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2020-04-25 14:48 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Jernej Skrabec, drinkcat, Neil Armstrong, David Airlie,
Jonas Karlman, linux-kernel, dri-devel, Andrzej Hajda,
Laurent Pinchart, hsinyi, matthias.bgg, Collabora Kernel ML
On Thu, Apr 16, 2020 at 06:44:04PM +0200, Enric Balletbo i Serra wrote:
> The panel connector type should be set by the panel not the bridge, so
> remove the connector_type assignment.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks, applied to drm-misc-next.
Sam
> ---
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 956b76e0a44d..13755d278db6 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
> if (!panel)
> return -ENODEV;
>
> - panel->connector_type = DRM_MODE_CONNECTOR_eDP;
> -
> ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
> if (IS_ERR(ps_bridge->panel_bridge))
> return PTR_ERR(ps_bridge->panel_bridge);
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] drm: panel: Set connector type for LP120UP1
2020-04-16 16:44 ` Enric Balletbo i Serra
@ 2020-04-16 17:03 ` Laurent Pinchart
-1 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2020-04-16 17:03 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Collabora Kernel ML, matthias.bgg, drinkcat,
hsinyi, sam, Daniel Vetter, David Airlie, Thierry Reding,
dri-devel
Hi Enric,
Thank you for the patch.
On Thu, Apr 16, 2020 at 06:44:03PM +0200, Enric Balletbo i Serra wrote:
> The LP120UP1 is a eDP panel, set the connector type accordingly.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> drivers/gpu/drm/panel/panel-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..6253635601bb 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2168,6 +2168,7 @@ static const struct panel_desc lg_lp120up1 = {
> .width = 267,
> .height = 183,
> },
> + .connector_type = DRM_MODE_CONNECTOR_eDP,
> };
>
> static const struct drm_display_mode lg_lp129qe_mode = {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] drm: panel: Set connector type for LP120UP1
@ 2020-04-16 17:03 ` Laurent Pinchart
0 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2020-04-16 17:03 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: drinkcat, David Airlie, linux-kernel, dri-devel, Thierry Reding,
hsinyi, matthias.bgg, Collabora Kernel ML, sam
Hi Enric,
Thank you for the patch.
On Thu, Apr 16, 2020 at 06:44:03PM +0200, Enric Balletbo i Serra wrote:
> The LP120UP1 is a eDP panel, set the connector type accordingly.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> drivers/gpu/drm/panel/panel-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..6253635601bb 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2168,6 +2168,7 @@ static const struct panel_desc lg_lp120up1 = {
> .width = 267,
> .height = 183,
> },
> + .connector_type = DRM_MODE_CONNECTOR_eDP,
> };
>
> static const struct drm_display_mode lg_lp129qe_mode = {
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] drm: panel: Set connector type for LP120UP1
2020-04-16 16:44 ` Enric Balletbo i Serra
@ 2020-04-25 14:47 ` Sam Ravnborg
-1 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2020-04-25 14:47 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, drinkcat, David Airlie, dri-devel, Thierry Reding,
laurent.pinchart, hsinyi, matthias.bgg, Collabora Kernel ML
On Thu, Apr 16, 2020 at 06:44:03PM +0200, Enric Balletbo i Serra wrote:
> The LP120UP1 is a eDP panel, set the connector type accordingly.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks.
Applied to drm-misc-next.
Sam
> ---
>
> drivers/gpu/drm/panel/panel-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..6253635601bb 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2168,6 +2168,7 @@ static const struct panel_desc lg_lp120up1 = {
> .width = 267,
> .height = 183,
> },
> + .connector_type = DRM_MODE_CONNECTOR_eDP,
> };
>
> static const struct drm_display_mode lg_lp129qe_mode = {
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] drm: panel: Set connector type for LP120UP1
@ 2020-04-25 14:47 ` Sam Ravnborg
0 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2020-04-25 14:47 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: drinkcat, David Airlie, linux-kernel, dri-devel, Thierry Reding,
laurent.pinchart, hsinyi, matthias.bgg, Collabora Kernel ML
On Thu, Apr 16, 2020 at 06:44:03PM +0200, Enric Balletbo i Serra wrote:
> The LP120UP1 is a eDP panel, set the connector type accordingly.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks.
Applied to drm-misc-next.
Sam
> ---
>
> drivers/gpu/drm/panel/panel-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..6253635601bb 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2168,6 +2168,7 @@ static const struct panel_desc lg_lp120up1 = {
> .width = 267,
> .height = 183,
> },
> + .connector_type = DRM_MODE_CONNECTOR_eDP,
> };
>
> static const struct drm_display_mode lg_lp129qe_mode = {
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread