* [PATCH] Remove drm_display_mode.hsync @ 2020-04-27 8:05 ` Michal Orzel 0 siblings, 0 replies; 11+ messages in thread From: Michal Orzel @ 2020-04-27 8:05 UTC (permalink / raw) To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, jani.nikula, joonas.lahtinen, rodrigo.vivi, ville.syrjala, chris, jose.souza Cc: Michal Orzel, dri-devel, linux-kernel, intel-gfx As suggested by the TODO list of DRM subsystem: -remove the member hsync of drm_display_mode -convert code using hsync member to use drm_mode_hsync() Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com> --- drivers/gpu/drm/drm_modes.c | 6 +----- drivers/gpu/drm/i915/display/intel_display.c | 1 - include/drm/drm_modes.h | 10 ---------- 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index d4d6451..0340079 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); * @mode: mode * * Returns: - * @modes's hsync rate in kHz, rounded to the nearest integer. Calculates the - * value first if it is not yet set. + * @modes's hsync rate in kHz, rounded to the nearest integer. */ int drm_mode_hsync(const struct drm_display_mode *mode) { unsigned int calc_val; - if (mode->hsync) - return mode->hsync; - if (mode->htotal <= 0) return 0; diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 3468466..ec7e943 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, mode->clock = pipe_config->hw.adjusted_mode.crtc_clock; - mode->hsync = drm_mode_hsync(mode); mode->vrefresh = drm_mode_vrefresh(mode); drm_mode_set_name(mode); } diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h index 99134d4..7dab7f1 100644 --- a/include/drm/drm_modes.h +++ b/include/drm/drm_modes.h @@ -391,16 +391,6 @@ struct drm_display_mode { int vrefresh; /** - * @hsync: - * - * Horizontal refresh rate, for debug output in human readable form. Not - * used in a functional way. - * - * This value is in kHz. - */ - int hsync; - - /** * @picture_aspect_ratio: * * Field for setting the HDMI picture aspect ratio of a mode. -- 2.7.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH] Remove drm_display_mode.hsync @ 2020-04-27 8:05 ` Michal Orzel 0 siblings, 0 replies; 11+ messages in thread From: Michal Orzel @ 2020-04-27 8:05 UTC (permalink / raw) To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, jani.nikula, joonas.lahtinen, rodrigo.vivi, ville.syrjala, chris, jose.souza Cc: intel-gfx, Michal Orzel, linux-kernel, dri-devel As suggested by the TODO list of DRM subsystem: -remove the member hsync of drm_display_mode -convert code using hsync member to use drm_mode_hsync() Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com> --- drivers/gpu/drm/drm_modes.c | 6 +----- drivers/gpu/drm/i915/display/intel_display.c | 1 - include/drm/drm_modes.h | 10 ---------- 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index d4d6451..0340079 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); * @mode: mode * * Returns: - * @modes's hsync rate in kHz, rounded to the nearest integer. Calculates the - * value first if it is not yet set. + * @modes's hsync rate in kHz, rounded to the nearest integer. */ int drm_mode_hsync(const struct drm_display_mode *mode) { unsigned int calc_val; - if (mode->hsync) - return mode->hsync; - if (mode->htotal <= 0) return 0; diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 3468466..ec7e943 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, mode->clock = pipe_config->hw.adjusted_mode.crtc_clock; - mode->hsync = drm_mode_hsync(mode); mode->vrefresh = drm_mode_vrefresh(mode); drm_mode_set_name(mode); } diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h index 99134d4..7dab7f1 100644 --- a/include/drm/drm_modes.h +++ b/include/drm/drm_modes.h @@ -391,16 +391,6 @@ struct drm_display_mode { int vrefresh; /** - * @hsync: - * - * Horizontal refresh rate, for debug output in human readable form. Not - * used in a functional way. - * - * This value is in kHz. - */ - int hsync; - - /** * @picture_aspect_ratio: * * Field for setting the HDMI picture aspect ratio of a mode. -- 2.7.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] Remove drm_display_mode.hsync @ 2020-04-27 8:05 ` Michal Orzel 0 siblings, 0 replies; 11+ messages in thread From: Michal Orzel @ 2020-04-27 8:05 UTC (permalink / raw) To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, jani.nikula, joonas.lahtinen, rodrigo.vivi, ville.syrjala, chris, jose.souza Cc: intel-gfx, Michal Orzel, linux-kernel, dri-devel As suggested by the TODO list of DRM subsystem: -remove the member hsync of drm_display_mode -convert code using hsync member to use drm_mode_hsync() Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com> --- drivers/gpu/drm/drm_modes.c | 6 +----- drivers/gpu/drm/i915/display/intel_display.c | 1 - include/drm/drm_modes.h | 10 ---------- 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index d4d6451..0340079 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); * @mode: mode * * Returns: - * @modes's hsync rate in kHz, rounded to the nearest integer. Calculates the - * value first if it is not yet set. + * @modes's hsync rate in kHz, rounded to the nearest integer. */ int drm_mode_hsync(const struct drm_display_mode *mode) { unsigned int calc_val; - if (mode->hsync) - return mode->hsync; - if (mode->htotal <= 0) return 0; diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 3468466..ec7e943 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, mode->clock = pipe_config->hw.adjusted_mode.crtc_clock; - mode->hsync = drm_mode_hsync(mode); mode->vrefresh = drm_mode_vrefresh(mode); drm_mode_set_name(mode); } diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h index 99134d4..7dab7f1 100644 --- a/include/drm/drm_modes.h +++ b/include/drm/drm_modes.h @@ -391,16 +391,6 @@ struct drm_display_mode { int vrefresh; /** - * @hsync: - * - * Horizontal refresh rate, for debug output in human readable form. Not - * used in a functional way. - * - * This value is in kHz. - */ - int hsync; - - /** * @picture_aspect_ratio: * * Field for setting the HDMI picture aspect ratio of a mode. -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Remove drm_display_mode.hsync 2020-04-27 8:05 ` Michal Orzel (?) (?) @ 2020-04-27 19:38 ` Patchwork -1 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2020-04-27 19:38 UTC (permalink / raw) To: Michal Orzel; +Cc: intel-gfx == Series Details == Series: Remove drm_display_mode.hsync URL : https://patchwork.freedesktop.org/series/76564/ State : success == Summary == CI Bug Log - changes from CI_DRM_8375 -> Patchwork_17483 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/index.html Changes ------- No changes found Participating hosts (48 -> 44) ------------------------------ Additional (1): fi-kbl-7560u Missing (5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8375 -> Patchwork_17483 CI-20190529: 20190529 CI_DRM_8375: 44f35fc32fe144e5702b0de0218d2966859cc075 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5612: c8dc1fd926a550308b971ca7d83fe0a927a38152 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17483: 72e71054e15a4501b16490f69baa1a44ff4768df @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 72e71054e15a Remove drm_display_mode.hsync == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for Remove drm_display_mode.hsync 2020-04-27 8:05 ` Michal Orzel ` (2 preceding siblings ...) (?) @ 2020-04-28 0:01 ` Patchwork -1 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2020-04-28 0:01 UTC (permalink / raw) To: Michal Orzel; +Cc: intel-gfx == Series Details == Series: Remove drm_display_mode.hsync URL : https://patchwork.freedesktop.org/series/76564/ State : success == Summary == CI Bug Log - changes from CI_DRM_8375_full -> Patchwork_17483_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_17483_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@drm_read@invalid-buffer: - shard-snb: [PASS][1] -> [SKIP][2] ([fdo#109271]) +6 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-snb6/igt@drm_read@invalid-buffer.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-snb2/igt@drm_read@invalid-buffer.html * igt@gem_softpin@noreloc-s3: - shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-kbl4/igt@gem_softpin@noreloc-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-kbl4/igt@gem_softpin@noreloc-s3.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][5] -> [FAIL][6] ([i915#454]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-iclb6/igt@i915_pm_dc@dc6-psr.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-iclb6/igt@i915_pm_dc@dc6-psr.html - shard-skl: [PASS][7] -> [FAIL][8] ([i915#454]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-skl6/igt@i915_pm_dc@dc6-psr.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-skl3/igt@i915_pm_dc@dc6-psr.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-skl: [PASS][9] -> [INCOMPLETE][10] ([i915#151] / [i915#69]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-skl6/igt@i915_pm_rpm@system-suspend-execbuf.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-skl10/igt@i915_pm_rpm@system-suspend-execbuf.html * igt@i915_suspend@sysfs-reader: - shard-apl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-apl7/igt@i915_suspend@sysfs-reader.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-apl6/igt@i915_suspend@sysfs-reader.html * igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen: - shard-apl: [PASS][13] -> [FAIL][14] ([i915#54] / [i915#95]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-apl2/igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-apl8/igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen.html * igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding: - shard-skl: [PASS][15] -> [FAIL][16] ([i915#54]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: - shard-glk: [PASS][17] -> [FAIL][18] ([i915#72]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html * igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled: - shard-glk: [PASS][19] -> [FAIL][20] ([i915#52] / [i915#54]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-glk6/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-glk9/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180] / [i915#93] / [i915#95]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc: - shard-tglb: [PASS][23] -> [SKIP][24] ([i915#668]) +7 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [PASS][25] -> [FAIL][26] ([i915#1188]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [i915#265]) +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109642] / [fdo#111068]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-iclb2/igt@kms_psr2_su@frontbuffer.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-iclb6/igt@kms_psr2_su@frontbuffer.html * igt@kms_setmode@basic: - shard-apl: [PASS][31] -> [FAIL][32] ([i915#31]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-apl4/igt@kms_setmode@basic.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-apl6/igt@kms_setmode@basic.html - shard-kbl: [PASS][33] -> [FAIL][34] ([i915#31]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-kbl2/igt@kms_setmode@basic.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-kbl1/igt@kms_setmode@basic.html #### Possible fixes #### * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding: - shard-kbl: [FAIL][35] ([i915#54] / [i915#93] / [i915#95]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html * igt@kms_cursor_legacy@pipe-b-torture-bo: - shard-tglb: [DMESG-WARN][37] ([i915#128]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-tglb6/igt@kms_cursor_legacy@pipe-b-torture-bo.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-tglb6/igt@kms_cursor_legacy@pipe-b-torture-bo.html * igt@kms_draw_crc@draw-method-rgb565-render-untiled: - shard-glk: [FAIL][39] ([i915#52] / [i915#54]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-glk4/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-glk5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html * {igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2}: - shard-glk: [FAIL][41] ([i915#79]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html * igt@kms_psr@psr2_cursor_plane_onoff: - shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-iclb8/igt@kms_psr@psr2_cursor_plane_onoff.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [DMESG-WARN][45] ([i915#180]) -> [PASS][46] +3 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html - shard-apl: [DMESG-WARN][47] ([i915#180]) -> [PASS][48] +4 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-apl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * {igt@perf@blocking-parameterized}: - shard-kbl: [FAIL][49] ([i915#1542]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-kbl3/igt@perf@blocking-parameterized.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-kbl1/igt@perf@blocking-parameterized.html * {igt@sysfs_heartbeat_interval@mixed@vecs0}: - shard-skl: [FAIL][51] ([i915#1731]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-skl8/igt@sysfs_heartbeat_interval@mixed@vecs0.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-skl10/igt@sysfs_heartbeat_interval@mixed@vecs0.html #### Warnings #### * igt@i915_pm_dc@dc6-psr: - shard-tglb: [SKIP][53] ([i915#468]) -> [FAIL][54] ([i915#454]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-tglb2/igt@i915_pm_dc@dc6-psr.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-tglb6/igt@i915_pm_dc@dc6-psr.html * igt@kms_content_protection@legacy: - shard-apl: [TIMEOUT][55] ([i915#1319]) -> [FAIL][56] ([fdo#110321] / [fdo#110336]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8375/shard-apl3/igt@kms_content_protection@legacy.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/shard-apl3/igt@kms_content_protection@legacy.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321 [fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468 [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8375 -> Patchwork_17483 CI-20190529: 20190529 CI_DRM_8375: 44f35fc32fe144e5702b0de0218d2966859cc075 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5612: c8dc1fd926a550308b971ca7d83fe0a927a38152 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17483: 72e71054e15a4501b16490f69baa1a44ff4768df @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17483/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Remove drm_display_mode.hsync 2020-04-27 8:05 ` Michal Orzel (?) @ 2020-04-28 15:18 ` Daniel Vetter -1 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2020-04-28 15:18 UTC (permalink / raw) To: Michal Orzel Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, jani.nikula, joonas.lahtinen, rodrigo.vivi, ville.syrjala, chris, jose.souza, dri-devel, linux-kernel, intel-gfx On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > As suggested by the TODO list of DRM subsystem: > -remove the member hsync of drm_display_mode > -convert code using hsync member to use drm_mode_hsync() > > Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com> I think Ville has a bunch of patches doing this, we might have some overlap :-/ Adding Ville. Please sync with him and get either of these patches reviewed. Thanks, Daniel > --- > drivers/gpu/drm/drm_modes.c | 6 +----- > drivers/gpu/drm/i915/display/intel_display.c | 1 - > include/drm/drm_modes.h | 10 ---------- > 3 files changed, 1 insertion(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index d4d6451..0340079 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); > * @mode: mode > * > * Returns: > - * @modes's hsync rate in kHz, rounded to the nearest integer. Calculates the > - * value first if it is not yet set. > + * @modes's hsync rate in kHz, rounded to the nearest integer. > */ > int drm_mode_hsync(const struct drm_display_mode *mode) > { > unsigned int calc_val; > > - if (mode->hsync) > - return mode->hsync; > - > if (mode->htotal <= 0) > return 0; > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 3468466..ec7e943 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, > > mode->clock = pipe_config->hw.adjusted_mode.crtc_clock; > > - mode->hsync = drm_mode_hsync(mode); > mode->vrefresh = drm_mode_vrefresh(mode); > drm_mode_set_name(mode); > } > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > index 99134d4..7dab7f1 100644 > --- a/include/drm/drm_modes.h > +++ b/include/drm/drm_modes.h > @@ -391,16 +391,6 @@ struct drm_display_mode { > int vrefresh; > > /** > - * @hsync: > - * > - * Horizontal refresh rate, for debug output in human readable form. Not > - * used in a functional way. > - * > - * This value is in kHz. > - */ > - int hsync; > - > - /** > * @picture_aspect_ratio: > * > * Field for setting the HDMI picture aspect ratio of a mode. > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] Remove drm_display_mode.hsync @ 2020-04-28 15:18 ` Daniel Vetter 0 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2020-04-28 15:18 UTC (permalink / raw) To: Michal Orzel Cc: tzimmermann, airlied, dri-devel, linux-kernel, chris, mripard, intel-gfx On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > As suggested by the TODO list of DRM subsystem: > -remove the member hsync of drm_display_mode > -convert code using hsync member to use drm_mode_hsync() > > Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com> I think Ville has a bunch of patches doing this, we might have some overlap :-/ Adding Ville. Please sync with him and get either of these patches reviewed. Thanks, Daniel > --- > drivers/gpu/drm/drm_modes.c | 6 +----- > drivers/gpu/drm/i915/display/intel_display.c | 1 - > include/drm/drm_modes.h | 10 ---------- > 3 files changed, 1 insertion(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index d4d6451..0340079 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); > * @mode: mode > * > * Returns: > - * @modes's hsync rate in kHz, rounded to the nearest integer. Calculates the > - * value first if it is not yet set. > + * @modes's hsync rate in kHz, rounded to the nearest integer. > */ > int drm_mode_hsync(const struct drm_display_mode *mode) > { > unsigned int calc_val; > > - if (mode->hsync) > - return mode->hsync; > - > if (mode->htotal <= 0) > return 0; > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 3468466..ec7e943 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, > > mode->clock = pipe_config->hw.adjusted_mode.crtc_clock; > > - mode->hsync = drm_mode_hsync(mode); > mode->vrefresh = drm_mode_vrefresh(mode); > drm_mode_set_name(mode); > } > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > index 99134d4..7dab7f1 100644 > --- a/include/drm/drm_modes.h > +++ b/include/drm/drm_modes.h > @@ -391,16 +391,6 @@ struct drm_display_mode { > int vrefresh; > > /** > - * @hsync: > - * > - * Horizontal refresh rate, for debug output in human readable form. Not > - * used in a functional way. > - * > - * This value is in kHz. > - */ > - int hsync; > - > - /** > * @picture_aspect_ratio: > * > * Field for setting the HDMI picture aspect ratio of a mode. > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Remove drm_display_mode.hsync @ 2020-04-28 15:18 ` Daniel Vetter 0 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2020-04-28 15:18 UTC (permalink / raw) To: Michal Orzel Cc: tzimmermann, airlied, dri-devel, linux-kernel, chris, rodrigo.vivi, jose.souza, intel-gfx On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > As suggested by the TODO list of DRM subsystem: > -remove the member hsync of drm_display_mode > -convert code using hsync member to use drm_mode_hsync() > > Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com> I think Ville has a bunch of patches doing this, we might have some overlap :-/ Adding Ville. Please sync with him and get either of these patches reviewed. Thanks, Daniel > --- > drivers/gpu/drm/drm_modes.c | 6 +----- > drivers/gpu/drm/i915/display/intel_display.c | 1 - > include/drm/drm_modes.h | 10 ---------- > 3 files changed, 1 insertion(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index d4d6451..0340079 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); > * @mode: mode > * > * Returns: > - * @modes's hsync rate in kHz, rounded to the nearest integer. Calculates the > - * value first if it is not yet set. > + * @modes's hsync rate in kHz, rounded to the nearest integer. > */ > int drm_mode_hsync(const struct drm_display_mode *mode) > { > unsigned int calc_val; > > - if (mode->hsync) > - return mode->hsync; > - > if (mode->htotal <= 0) > return 0; > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 3468466..ec7e943 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, > > mode->clock = pipe_config->hw.adjusted_mode.crtc_clock; > > - mode->hsync = drm_mode_hsync(mode); > mode->vrefresh = drm_mode_vrefresh(mode); > drm_mode_set_name(mode); > } > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > index 99134d4..7dab7f1 100644 > --- a/include/drm/drm_modes.h > +++ b/include/drm/drm_modes.h > @@ -391,16 +391,6 @@ struct drm_display_mode { > int vrefresh; > > /** > - * @hsync: > - * > - * Horizontal refresh rate, for debug output in human readable form. Not > - * used in a functional way. > - * > - * This value is in kHz. > - */ > - int hsync; > - > - /** > * @picture_aspect_ratio: > * > * Field for setting the HDMI picture aspect ratio of a mode. > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Remove drm_display_mode.hsync 2020-04-28 15:18 ` Daniel Vetter (?) @ 2020-04-28 15:45 ` Ville Syrjälä -1 siblings, 0 replies; 11+ messages in thread From: Ville Syrjälä @ 2020-04-28 15:45 UTC (permalink / raw) To: Michal Orzel, maarten.lankhorst, mripard, tzimmermann, airlied, jani.nikula, joonas.lahtinen, rodrigo.vivi, chris, jose.souza, dri-devel, linux-kernel, intel-gfx On Tue, Apr 28, 2020 at 05:18:13PM +0200, Daniel Vetter wrote: > On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > > As suggested by the TODO list of DRM subsystem: > > -remove the member hsync of drm_display_mode > > -convert code using hsync member to use drm_mode_hsync() > > > > Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com> > > I think Ville has a bunch of patches doing this, we might have some > overlap :-/ Adding Ville. > > Please sync with him and get either of these patches reviewed. Yeah, I have the same thing (+ making the function static). I think my series is sufficiently reviewed to get most of it pushed. Just need to get it past the ci... which apparently means I get to do another rebase. > > Thanks, Daniel > > > --- > > drivers/gpu/drm/drm_modes.c | 6 +----- > > drivers/gpu/drm/i915/display/intel_display.c | 1 - > > include/drm/drm_modes.h | 10 ---------- > > 3 files changed, 1 insertion(+), 16 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index d4d6451..0340079 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); > > * @mode: mode > > * > > * Returns: > > - * @modes's hsync rate in kHz, rounded to the nearest integer. Calculates the > > - * value first if it is not yet set. > > + * @modes's hsync rate in kHz, rounded to the nearest integer. > > */ > > int drm_mode_hsync(const struct drm_display_mode *mode) > > { > > unsigned int calc_val; > > > > - if (mode->hsync) > > - return mode->hsync; > > - > > if (mode->htotal <= 0) > > return 0; > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > > index 3468466..ec7e943 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, > > > > mode->clock = pipe_config->hw.adjusted_mode.crtc_clock; > > > > - mode->hsync = drm_mode_hsync(mode); > > mode->vrefresh = drm_mode_vrefresh(mode); > > drm_mode_set_name(mode); > > } > > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > > index 99134d4..7dab7f1 100644 > > --- a/include/drm/drm_modes.h > > +++ b/include/drm/drm_modes.h > > @@ -391,16 +391,6 @@ struct drm_display_mode { > > int vrefresh; > > > > /** > > - * @hsync: > > - * > > - * Horizontal refresh rate, for debug output in human readable form. Not > > - * used in a functional way. > > - * > > - * This value is in kHz. > > - */ > > - int hsync; > > - > > - /** > > * @picture_aspect_ratio: > > * > > * Field for setting the HDMI picture aspect ratio of a mode. > > -- > > 2.7.4 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] Remove drm_display_mode.hsync @ 2020-04-28 15:45 ` Ville Syrjälä 0 siblings, 0 replies; 11+ messages in thread From: Ville Syrjälä @ 2020-04-28 15:45 UTC (permalink / raw) To: Michal Orzel, maarten.lankhorst, mripard, tzimmermann, airlied, jani.nikula, joonas.lahtinen, rodrigo.vivi, chris, jose.souza, dri-devel, linux-kernel, intel-gfx On Tue, Apr 28, 2020 at 05:18:13PM +0200, Daniel Vetter wrote: > On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > > As suggested by the TODO list of DRM subsystem: > > -remove the member hsync of drm_display_mode > > -convert code using hsync member to use drm_mode_hsync() > > > > Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com> > > I think Ville has a bunch of patches doing this, we might have some > overlap :-/ Adding Ville. > > Please sync with him and get either of these patches reviewed. Yeah, I have the same thing (+ making the function static). I think my series is sufficiently reviewed to get most of it pushed. Just need to get it past the ci... which apparently means I get to do another rebase. > > Thanks, Daniel > > > --- > > drivers/gpu/drm/drm_modes.c | 6 +----- > > drivers/gpu/drm/i915/display/intel_display.c | 1 - > > include/drm/drm_modes.h | 10 ---------- > > 3 files changed, 1 insertion(+), 16 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index d4d6451..0340079 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); > > * @mode: mode > > * > > * Returns: > > - * @modes's hsync rate in kHz, rounded to the nearest integer. Calculates the > > - * value first if it is not yet set. > > + * @modes's hsync rate in kHz, rounded to the nearest integer. > > */ > > int drm_mode_hsync(const struct drm_display_mode *mode) > > { > > unsigned int calc_val; > > > > - if (mode->hsync) > > - return mode->hsync; > > - > > if (mode->htotal <= 0) > > return 0; > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > > index 3468466..ec7e943 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, > > > > mode->clock = pipe_config->hw.adjusted_mode.crtc_clock; > > > > - mode->hsync = drm_mode_hsync(mode); > > mode->vrefresh = drm_mode_vrefresh(mode); > > drm_mode_set_name(mode); > > } > > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > > index 99134d4..7dab7f1 100644 > > --- a/include/drm/drm_modes.h > > +++ b/include/drm/drm_modes.h > > @@ -391,16 +391,6 @@ struct drm_display_mode { > > int vrefresh; > > > > /** > > - * @hsync: > > - * > > - * Horizontal refresh rate, for debug output in human readable form. Not > > - * used in a functional way. > > - * > > - * This value is in kHz. > > - */ > > - int hsync; > > - > > - /** > > * @picture_aspect_ratio: > > * > > * Field for setting the HDMI picture aspect ratio of a mode. > > -- > > 2.7.4 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Remove drm_display_mode.hsync @ 2020-04-28 15:45 ` Ville Syrjälä 0 siblings, 0 replies; 11+ messages in thread From: Ville Syrjälä @ 2020-04-28 15:45 UTC (permalink / raw) To: Michal Orzel, maarten.lankhorst, mripard, tzimmermann, airlied, jani.nikula, joonas.lahtinen, rodrigo.vivi, chris, jose.souza, dri-devel, linux-kernel, intel-gfx On Tue, Apr 28, 2020 at 05:18:13PM +0200, Daniel Vetter wrote: > On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > > As suggested by the TODO list of DRM subsystem: > > -remove the member hsync of drm_display_mode > > -convert code using hsync member to use drm_mode_hsync() > > > > Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com> > > I think Ville has a bunch of patches doing this, we might have some > overlap :-/ Adding Ville. > > Please sync with him and get either of these patches reviewed. Yeah, I have the same thing (+ making the function static). I think my series is sufficiently reviewed to get most of it pushed. Just need to get it past the ci... which apparently means I get to do another rebase. > > Thanks, Daniel > > > --- > > drivers/gpu/drm/drm_modes.c | 6 +----- > > drivers/gpu/drm/i915/display/intel_display.c | 1 - > > include/drm/drm_modes.h | 10 ---------- > > 3 files changed, 1 insertion(+), 16 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index d4d6451..0340079 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -752,16 +752,12 @@ EXPORT_SYMBOL(drm_mode_set_name); > > * @mode: mode > > * > > * Returns: > > - * @modes's hsync rate in kHz, rounded to the nearest integer. Calculates the > > - * value first if it is not yet set. > > + * @modes's hsync rate in kHz, rounded to the nearest integer. > > */ > > int drm_mode_hsync(const struct drm_display_mode *mode) > > { > > unsigned int calc_val; > > > > - if (mode->hsync) > > - return mode->hsync; > > - > > if (mode->htotal <= 0) > > return 0; > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > > index 3468466..ec7e943 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -8891,7 +8891,6 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, > > > > mode->clock = pipe_config->hw.adjusted_mode.crtc_clock; > > > > - mode->hsync = drm_mode_hsync(mode); > > mode->vrefresh = drm_mode_vrefresh(mode); > > drm_mode_set_name(mode); > > } > > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > > index 99134d4..7dab7f1 100644 > > --- a/include/drm/drm_modes.h > > +++ b/include/drm/drm_modes.h > > @@ -391,16 +391,6 @@ struct drm_display_mode { > > int vrefresh; > > > > /** > > - * @hsync: > > - * > > - * Horizontal refresh rate, for debug output in human readable form. Not > > - * used in a functional way. > > - * > > - * This value is in kHz. > > - */ > > - int hsync; > > - > > - /** > > * @picture_aspect_ratio: > > * > > * Field for setting the HDMI picture aspect ratio of a mode. > > -- > > 2.7.4 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-04-28 15:45 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-04-27 8:05 [PATCH] Remove drm_display_mode.hsync Michal Orzel 2020-04-27 8:05 ` [Intel-gfx] " Michal Orzel 2020-04-27 8:05 ` Michal Orzel 2020-04-27 19:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-04-28 0:01 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-04-28 15:18 ` [PATCH] " Daniel Vetter 2020-04-28 15:18 ` [Intel-gfx] " Daniel Vetter 2020-04-28 15:18 ` Daniel Vetter 2020-04-28 15:45 ` Ville Syrjälä 2020-04-28 15:45 ` [Intel-gfx] " Ville Syrjälä 2020-04-28 15:45 ` Ville Syrjälä
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.