From: kbuild test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] PCI: fix platform_get_irq.cocci warnings
Date: Fri, 08 May 2020 07:27:26 +0800 [thread overview]
Message-ID: <20200507232726.GA15331@a836a3f6df01> (raw)
In-Reply-To: <202005080708.oPqRROEz%lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-pci(a)vger.kernel.org
TO: Aman Sharma <amanharitsh123@gmail.com>
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
CC: Andrew Murray <amurray@thegoodpenguin.co.uk>
CC: Thierry Reding <thierry.reding@gmail.com>
CC: Jonathan Hunter <jonathanh@nvidia.com>
CC: Vidya Sagar <vidyas@nvidia.com>
CC: linux-pci(a)vger.kernel.org
CC: linux-tegra(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kbuild test robot <lkp@intel.com>
drivers/pci/controller/dwc/pcie-tegra194.c:2194:2-9: line 2194 is redundant because platform_get_irq() already prints an error
Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Fixes: 198938ec966d ("PCI: Check for platform_get_irq() failure consistently")
CC: Aman Sharma <amanharitsh123@gmail.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc
head: a88f8c176147d9778330082fcc34b7107da756aa
commit: 198938ec966d45c47eb7c1f6d2a4ac82c12bf5ce [2/3] PCI: Check for platform_get_irq() failure consistently
:::::: branch date: 3 hours ago
:::::: commit date: 2 days ago
Please take the patch only if it's a positive warning. Thanks!
pcie-tegra194.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -2191,7 +2191,6 @@ static int tegra_pcie_dw_probe(struct pl
pp->irq = platform_get_irq_byname(pdev, "intr");
if (pp->irq < 0) {
- dev_err(dev, "Failed to get \"intr\" interrupt\n");
return pp->irq;
}
prev parent reply other threads:[~2020-05-07 23:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 23:27 [pci:pci/misc 2/3] drivers/pci/controller/dwc/pcie-tegra194.c:2194:2-9: line 2194 is redundant because platform_get_irq() already prints an error kbuild test robot
2020-05-07 23:27 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507232726.GA15331@a836a3f6df01 \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.