[pci:pci/misc 2/3] drivers/pci/controller/dwc/pcie-tegra194.c:2194:2-9: line 2194 is redundant because platform_get_irq() already prints an error

[pci:pci/misc 2/3] drivers/pci/controller/dwc/pcie-tegra194.c:2194:2-9: line 2194 is redundant because platform_get_irq() already prints an error

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-pci(a)vger.kernel.org
TO: Aman Sharma <amanharitsh123@gmail.com>
CC: Bjorn Helgaas <helgaas@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc
head:   a88f8c176147d9778330082fcc34b7107da756aa
commit: 198938ec966d45c47eb7c1f6d2a4ac82c12bf5ce [2/3] PCI: Check for platform_get_irq() failure consistently
:::::: branch date: 3 hours ago
:::::: commit date: 2 days ago

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/pci/controller/dwc/pcie-tegra194.c:2194:2-9: line 2194 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[PATCH] PCI: fix platform_get_irq.cocci warnings

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-pci(a)vger.kernel.org
TO: Aman Sharma <amanharitsh123@gmail.com>
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
CC: Andrew Murray <amurray@thegoodpenguin.co.uk>
CC: Thierry Reding <thierry.reding@gmail.com>
CC: Jonathan Hunter <jonathanh@nvidia.com>
CC: Vidya Sagar <vidyas@nvidia.com>
CC: linux-pci(a)vger.kernel.org
CC: linux-tegra(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kbuild test robot <lkp@intel.com>

drivers/pci/controller/dwc/pcie-tegra194.c:2194:2-9: line 2194 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: 198938ec966d ("PCI: Check for platform_get_irq() failure consistently")
CC: Aman Sharma <amanharitsh123@gmail.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc
head:   a88f8c176147d9778330082fcc34b7107da756aa
commit: 198938ec966d45c47eb7c1f6d2a4ac82c12bf5ce [2/3] PCI: Check for platform_get_irq() failure consistently
:::::: branch date: 3 hours ago
:::::: commit date: 2 days ago

Please take the patch only if it's a positive warning. Thanks!

 pcie-tegra194.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -2191,7 +2191,6 @@ static int tegra_pcie_dw_probe(struct pl
 
 	pp->irq = platform_get_irq_byname(pdev, "intr");
 	if (pp->irq < 0) {
-		dev_err(dev, "Failed to get \"intr\" interrupt\n");
 		return pp->irq;
 	}