* [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
@ 2020-04-24 15:11 ` Johan Jonker
0 siblings, 0 replies; 8+ messages in thread
From: Johan Jonker @ 2020-04-24 15:11 UTC (permalink / raw)
To: heiko; +Cc: robh+dt, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
The defines RK_GPIO0, RK_GPIO1, RK_GPIO2, RK_GPIO3,
RK_GPIO4 and RK_GPIO6 are no longer used. Mark them as
"deprecated" to prevent that someone start using them again.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
include/dt-bindings/pinctrl/rockchip.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/dt-bindings/pinctrl/rockchip.h b/include/dt-bindings/pinctrl/rockchip.h
index 6d6bac1c2..e379ec110 100644
--- a/include/dt-bindings/pinctrl/rockchip.h
+++ b/include/dt-bindings/pinctrl/rockchip.h
@@ -9,12 +9,12 @@
#ifndef __DT_BINDINGS_ROCKCHIP_PINCTRL_H__
#define __DT_BINDINGS_ROCKCHIP_PINCTRL_H__
-#define RK_GPIO0 0
-#define RK_GPIO1 1
-#define RK_GPIO2 2
-#define RK_GPIO3 3
-#define RK_GPIO4 4
-#define RK_GPIO6 6
+#define RK_GPIO0 0 /* deprecated */
+#define RK_GPIO1 1 /* deprecated */
+#define RK_GPIO2 2 /* deprecated */
+#define RK_GPIO3 3 /* deprecated */
+#define RK_GPIO4 4 /* deprecated */
+#define RK_GPIO6 6 /* deprecated */
#define RK_PA0 0
#define RK_PA1 1
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
@ 2020-04-24 15:11 ` Johan Jonker
0 siblings, 0 replies; 8+ messages in thread
From: Johan Jonker @ 2020-04-24 15:11 UTC (permalink / raw)
To: heiko; +Cc: devicetree, robh+dt, linux-kernel, linux-arm-kernel, linux-rockchip
The defines RK_GPIO0, RK_GPIO1, RK_GPIO2, RK_GPIO3,
RK_GPIO4 and RK_GPIO6 are no longer used. Mark them as
"deprecated" to prevent that someone start using them again.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
include/dt-bindings/pinctrl/rockchip.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/dt-bindings/pinctrl/rockchip.h b/include/dt-bindings/pinctrl/rockchip.h
index 6d6bac1c2..e379ec110 100644
--- a/include/dt-bindings/pinctrl/rockchip.h
+++ b/include/dt-bindings/pinctrl/rockchip.h
@@ -9,12 +9,12 @@
#ifndef __DT_BINDINGS_ROCKCHIP_PINCTRL_H__
#define __DT_BINDINGS_ROCKCHIP_PINCTRL_H__
-#define RK_GPIO0 0
-#define RK_GPIO1 1
-#define RK_GPIO2 2
-#define RK_GPIO3 3
-#define RK_GPIO4 4
-#define RK_GPIO6 6
+#define RK_GPIO0 0 /* deprecated */
+#define RK_GPIO1 1 /* deprecated */
+#define RK_GPIO2 2 /* deprecated */
+#define RK_GPIO3 3 /* deprecated */
+#define RK_GPIO4 4 /* deprecated */
+#define RK_GPIO6 6 /* deprecated */
#define RK_PA0 0
#define RK_PA1 1
--
2.11.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
@ 2020-04-24 15:11 ` Johan Jonker
0 siblings, 0 replies; 8+ messages in thread
From: Johan Jonker @ 2020-04-24 15:11 UTC (permalink / raw)
To: heiko-4mtYJXux2i+zQB+pC5nmwQ
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
The defines RK_GPIO0, RK_GPIO1, RK_GPIO2, RK_GPIO3,
RK_GPIO4 and RK_GPIO6 are no longer used. Mark them as
"deprecated" to prevent that someone start using them again.
Signed-off-by: Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
include/dt-bindings/pinctrl/rockchip.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/dt-bindings/pinctrl/rockchip.h b/include/dt-bindings/pinctrl/rockchip.h
index 6d6bac1c2..e379ec110 100644
--- a/include/dt-bindings/pinctrl/rockchip.h
+++ b/include/dt-bindings/pinctrl/rockchip.h
@@ -9,12 +9,12 @@
#ifndef __DT_BINDINGS_ROCKCHIP_PINCTRL_H__
#define __DT_BINDINGS_ROCKCHIP_PINCTRL_H__
-#define RK_GPIO0 0
-#define RK_GPIO1 1
-#define RK_GPIO2 2
-#define RK_GPIO3 3
-#define RK_GPIO4 4
-#define RK_GPIO6 6
+#define RK_GPIO0 0 /* deprecated */
+#define RK_GPIO1 1 /* deprecated */
+#define RK_GPIO2 2 /* deprecated */
+#define RK_GPIO3 3 /* deprecated */
+#define RK_GPIO4 4 /* deprecated */
+#define RK_GPIO6 6 /* deprecated */
#define RK_PA0 0
#define RK_PA1 1
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
@ 2020-05-11 21:36 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-05-11 21:36 UTC (permalink / raw)
To: Johan Jonker
Cc: heiko, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
On Fri, Apr 24, 2020 at 05:11:05PM +0200, Johan Jonker wrote:
> The defines RK_GPIO0, RK_GPIO1, RK_GPIO2, RK_GPIO3,
> RK_GPIO4 and RK_GPIO6 are no longer used. Mark them as
> "deprecated" to prevent that someone start using them again.
What changed exactly? The binding changed, or just using raw 0-6 instead
of the defines?
If there's not anything using these in tree, just delete them.
It is still used in the binding doc.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
@ 2020-05-11 21:36 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-05-11 21:36 UTC (permalink / raw)
To: Johan Jonker
Cc: devicetree, linux-kernel, heiko, linux-arm-kernel, linux-rockchip
On Fri, Apr 24, 2020 at 05:11:05PM +0200, Johan Jonker wrote:
> The defines RK_GPIO0, RK_GPIO1, RK_GPIO2, RK_GPIO3,
> RK_GPIO4 and RK_GPIO6 are no longer used. Mark them as
> "deprecated" to prevent that someone start using them again.
What changed exactly? The binding changed, or just using raw 0-6 instead
of the defines?
If there's not anything using these in tree, just delete them.
It is still used in the binding doc.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
@ 2020-05-11 21:36 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-05-11 21:36 UTC (permalink / raw)
To: Johan Jonker
Cc: heiko-4mtYJXux2i+zQB+pC5nmwQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Fri, Apr 24, 2020 at 05:11:05PM +0200, Johan Jonker wrote:
> The defines RK_GPIO0, RK_GPIO1, RK_GPIO2, RK_GPIO3,
> RK_GPIO4 and RK_GPIO6 are no longer used. Mark them as
> "deprecated" to prevent that someone start using them again.
What changed exactly? The binding changed, or just using raw 0-6 instead
of the defines?
If there's not anything using these in tree, just delete them.
It is still used in the binding doc.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
2020-05-11 21:36 ` Rob Herring
@ 2020-05-12 1:09 ` Heiko Stübner
-1 siblings, 0 replies; 8+ messages in thread
From: Heiko Stübner @ 2020-05-12 1:09 UTC (permalink / raw)
To: Rob Herring
Cc: Johan Jonker, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Am Montag, 11. Mai 2020, 23:36:05 CEST schrieb Rob Herring:
> On Fri, Apr 24, 2020 at 05:11:05PM +0200, Johan Jonker wrote:
> > The defines RK_GPIO0, RK_GPIO1, RK_GPIO2, RK_GPIO3,
> > RK_GPIO4 and RK_GPIO6 are no longer used. Mark them as
> > "deprecated" to prevent that someone start using them again.
>
> What changed exactly? The binding changed, or just using raw 0-6 instead
> of the defines?
This ... they are just dumb mappings of RK_GPIOx -> x so we switched
over to just using the raw numbers, as the constants do not provide any
additional information.
> If there's not anything using these in tree, just delete them.
Ok, good to know that we can just delete them if noone is using them
anymore.
> It is still used in the binding doc.
I think Johan will provide a v2 with that.
Heiko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
@ 2020-05-12 1:09 ` Heiko Stübner
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Stübner @ 2020-05-12 1:09 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Johan Jonker, linux-kernel, linux-arm-kernel, linux-rockchip
Am Montag, 11. Mai 2020, 23:36:05 CEST schrieb Rob Herring:
> On Fri, Apr 24, 2020 at 05:11:05PM +0200, Johan Jonker wrote:
> > The defines RK_GPIO0, RK_GPIO1, RK_GPIO2, RK_GPIO3,
> > RK_GPIO4 and RK_GPIO6 are no longer used. Mark them as
> > "deprecated" to prevent that someone start using them again.
>
> What changed exactly? The binding changed, or just using raw 0-6 instead
> of the defines?
This ... they are just dumb mappings of RK_GPIOx -> x so we switched
over to just using the raw numbers, as the constants do not provide any
additional information.
> If there's not anything using these in tree, just delete them.
Ok, good to know that we can just delete them if noone is using them
anymore.
> It is still used in the binding doc.
I think Johan will provide a v2 with that.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-05-12 1:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 15:11 [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated Johan Jonker
2020-04-24 15:11 ` Johan Jonker
2020-04-24 15:11 ` Johan Jonker
2020-05-11 21:36 ` Rob Herring
2020-05-11 21:36 ` Rob Herring
2020-05-11 21:36 ` Rob Herring
2020-05-12 1:09 ` Heiko Stübner
2020-05-12 1:09 ` Heiko Stübner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.