[PATCH] nvmet: mark nvmet_ana_state static

[PATCH] nvmet: mark nvmet_ana_state static

[Christoph Hellwig]

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/nvme/target/configfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index 19bd5e1c681ce..24eb4cf53b4f5 100644
--- a/drivers/nvme/target/configfs.c
+++ b/drivers/nvme/target/configfs.c
@@ -1146,7 +1146,7 @@ static const struct config_item_type nvmet_referrals_type = {
 	.ct_group_ops	= &nvmet_referral_group_ops,
 };
 
-struct nvmet_type_name_map nvmet_ana_state[] = {
+static struct nvmet_type_name_map nvmet_ana_state[] = {
 	{ NVME_ANA_OPTIMIZED,		"optimized" },
 	{ NVME_ANA_NONOPTIMIZED,	"non-optimized" },
 	{ NVME_ANA_INACCESSIBLE,	"inaccessible" },
-- 
2.26.2


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH] nvmet: mark nvmet_ana_state static

[Max Gurtovoy]

On 5/12/2020 7:19 PM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   drivers/nvme/target/configfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
> index 19bd5e1c681ce..24eb4cf53b4f5 100644
> --- a/drivers/nvme/target/configfs.c
> +++ b/drivers/nvme/target/configfs.c
> @@ -1146,7 +1146,7 @@ static const struct config_item_type nvmet_referrals_type = {
>   	.ct_group_ops	= &nvmet_referral_group_ops,
>   };
>   
> -struct nvmet_type_name_map nvmet_ana_state[] = {
> +static struct nvmet_type_name_map nvmet_ana_state[] = {
>   	{ NVME_ANA_OPTIMIZED,		"optimized" },
>   	{ NVME_ANA_NONOPTIMIZED,	"non-optimized" },
>   	{ NVME_ANA_INACCESSIBLE,	"inaccessible" },


Looks good,

Reviewed-by: Max Gurtovoy <maxg@mellanox.com>



_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH] nvmet: mark nvmet_ana_state static

[Chaitanya Kulkarni]

> On 5/12/2020 7:19 PM, Christoph Hellwig wrote:
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> ---
>>    drivers/nvme/target/configfs.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
>> index 19bd5e1c681ce..24eb4cf53b4f5 100644
>> --- a/drivers/nvme/target/configfs.c
>> +++ b/drivers/nvme/target/configfs.c
>> @@ -1146,7 +1146,7 @@ static const struct config_item_type nvmet_referrals_type = {
>>    	.ct_group_ops	= &nvmet_referral_group_ops,
>>    };
>>    
>> -struct nvmet_type_name_map nvmet_ana_state[] = {
>> +static struct nvmet_type_name_map nvmet_ana_state[] = {
>>    	{ NVME_ANA_OPTIMIZED,		"optimized" },
>>    	{ NVME_ANA_NONOPTIMIZED,	"non-optimized" },
>>    	{ NVME_ANA_INACCESSIBLE,	"inaccessible" },
> 
> 

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme