* [PATCH] nvmet: mark nvmet_ana_state static
@ 2020-05-12 16:19 Christoph Hellwig
2020-05-12 16:24 ` Max Gurtovoy
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2020-05-12 16:19 UTC (permalink / raw)
To: linux-nvme
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/nvme/target/configfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index 19bd5e1c681ce..24eb4cf53b4f5 100644
--- a/drivers/nvme/target/configfs.c
+++ b/drivers/nvme/target/configfs.c
@@ -1146,7 +1146,7 @@ static const struct config_item_type nvmet_referrals_type = {
.ct_group_ops = &nvmet_referral_group_ops,
};
-struct nvmet_type_name_map nvmet_ana_state[] = {
+static struct nvmet_type_name_map nvmet_ana_state[] = {
{ NVME_ANA_OPTIMIZED, "optimized" },
{ NVME_ANA_NONOPTIMIZED, "non-optimized" },
{ NVME_ANA_INACCESSIBLE, "inaccessible" },
--
2.26.2
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmet: mark nvmet_ana_state static
2020-05-12 16:19 [PATCH] nvmet: mark nvmet_ana_state static Christoph Hellwig
@ 2020-05-12 16:24 ` Max Gurtovoy
2020-05-13 8:16 ` Chaitanya Kulkarni
0 siblings, 1 reply; 3+ messages in thread
From: Max Gurtovoy @ 2020-05-12 16:24 UTC (permalink / raw)
To: Christoph Hellwig, linux-nvme
On 5/12/2020 7:19 PM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/nvme/target/configfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
> index 19bd5e1c681ce..24eb4cf53b4f5 100644
> --- a/drivers/nvme/target/configfs.c
> +++ b/drivers/nvme/target/configfs.c
> @@ -1146,7 +1146,7 @@ static const struct config_item_type nvmet_referrals_type = {
> .ct_group_ops = &nvmet_referral_group_ops,
> };
>
> -struct nvmet_type_name_map nvmet_ana_state[] = {
> +static struct nvmet_type_name_map nvmet_ana_state[] = {
> { NVME_ANA_OPTIMIZED, "optimized" },
> { NVME_ANA_NONOPTIMIZED, "non-optimized" },
> { NVME_ANA_INACCESSIBLE, "inaccessible" },
Looks good,
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmet: mark nvmet_ana_state static
2020-05-12 16:24 ` Max Gurtovoy
@ 2020-05-13 8:16 ` Chaitanya Kulkarni
0 siblings, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2020-05-13 8:16 UTC (permalink / raw)
To: Christoph Hellwig, linux-nvme
> On 5/12/2020 7:19 PM, Christoph Hellwig wrote:
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> ---
>> drivers/nvme/target/configfs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
>> index 19bd5e1c681ce..24eb4cf53b4f5 100644
>> --- a/drivers/nvme/target/configfs.c
>> +++ b/drivers/nvme/target/configfs.c
>> @@ -1146,7 +1146,7 @@ static const struct config_item_type nvmet_referrals_type = {
>> .ct_group_ops = &nvmet_referral_group_ops,
>> };
>>
>> -struct nvmet_type_name_map nvmet_ana_state[] = {
>> +static struct nvmet_type_name_map nvmet_ana_state[] = {
>> { NVME_ANA_OPTIMIZED, "optimized" },
>> { NVME_ANA_NONOPTIMIZED, "non-optimized" },
>> { NVME_ANA_INACCESSIBLE, "inaccessible" },
>
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-13 8:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 16:19 [PATCH] nvmet: mark nvmet_ana_state static Christoph Hellwig
2020-05-12 16:24 ` Max Gurtovoy
2020-05-13 8:16 ` Chaitanya Kulkarni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.