From: Tony Lindgren <email@example.com> To: Greg Kroah-Hartman <firstname.lastname@example.org>, Johan Hovold <email@example.com>, Rob Herring <firstname.lastname@example.org> Cc: Alan Cox <email@example.com>, Lee Jones <firstname.lastname@example.org>, Jiri Slaby <email@example.com>, Merlijn Wajer <firstname.lastname@example.org>, Pavel Machek <email@example.com>, Peter Hurley <firstname.lastname@example.org>, Sebastian Reichel <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4 Date: Tue, 12 May 2020 14:47:07 -0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) Hi all, Here's the updated set of these patches fixed up for Johan's and Pavel's earlier comments. This series does the following: 1. Adds functions to n_gsm.c for serdev-ngsm.c driver to use 2. Adds a generic serdev-ngsm.c driver that brings up the TS 27.010 TTY ports configured in devicetree with help of n_gsm.c 3. Allows the use of standard Linux device drivers for dedicated TS 27.010 channels for devices like GNSS and ALSA found on some modems for example 4. Adds a gnss-motmdm consumer driver for the GNSS device found on the Motorola Mapphone MDM6600 modem on devices like droid4 I've placed the serdev-ngsm.c under drivers/tty/serdev as it still seems to make most sense with no better places available. It's no longer an MFD driver as it really does not need to care what channel specific consumer drivers might be configured for the generic driver. Now serdev-ngsm just uses of_platform_populate() to probe whatever child nodes it might find. I'm not attached having the driver in drivers/tty/serdev. I just don't have any better locations in mind. So using Johan's earlier i2c example, the drivers/tty/serdev/serdev-ngsm.c driver is now a generic protocol and bus driver, so it's getting closer to the the drivers/i2c/busses analogy maybe :) Please do suggest better locations other than MFD and misc if you have better ideas. Now without the chardev support, the /dev/gsmtty* using apps need to use "U1234AT+CFUN?" format for the packets. The advantage is less kernel code, and we keep the existing /dev/gsmtty* interface. If we still really need the custom chardev support, that can now be added as needed with the channel specific consumer driver(s), but looks like this won't be needed based on Pavel's ofono work. Regards, Tony Changes since v7 (was accidentally posted as v6 again): - Updated gsm_serdev_register_tty_port() and gsd_dlci_data() to use receive_buf() to have the dlci handling follow the same path as for gsm_serdev_register_dlci() - Updated for Pavel's comments and acks, did not keep the ack for n_gsm.c as that has changed - Moved the GNSS driver binding to serdev-ngsm.yaml as suggested by Rob - Folded in a a fix from kbuild test robot <email@example.com> to make motmdm_gnss_send_command() static Changes since v6: - Based on comments from Johan, moved back to using the existing TS 27.010 TTYs created by n_gsm.c instaed of adding custom chardev support to deal with the Motorola custom protocol - Based on comments from Johan, made the serdev-ngsm driver generic with just minimal quirk handling for the Motorola modem - Dropped the Motorola custom protocol on top of TS 27.010 handling from serdev-ngsm.c as this can now be easily handled by the channel specific drivers as needed - Added few more helpers to n_gsm.c for serdev-ngsm.c to use - Added the channel specific GNSS driver for the Motorola modem Changes since v5: - Cosmetic fixes for issues noted by Pavel Changes since v4: - Use drivers/tty/serdev/protocol directory for the driver instead of drivers/mfd as discussed on the lists for v3 set of patches - Fix remove to call kfree only after removing device from the list Changes since v3: - Update list of folks in Cc, looks like I sent v3 only to Lee and lkml - Init privdata before motmdm_register_dlci calls gsm_serdev_register_dlci - Update binding based on Rob's comments for license and "allOf" Changes since v2: - Drop useless send_command indirection, use static motmdm_send_command Changes since v1: - Simplified usage and got rid of few pointless inline functions - Added consumer MFD driver, devicetree binding, and dts changes Tony Lindgren (6): tty: n_gsm: Add support for serdev drivers dt-bindings: serdev: ngsm: Add binding for serdev-ngsm dt-bindings: serdev: ngsm: Add binding for GNSS child node serdev: ngsm: Add generic serdev-ngsm driver gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem ARM: dts: omap4-droid4: Configure modem for serdev-ngsm .../bindings/serdev/serdev-ngsm.yaml | 73 +++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + .../boot/dts/motorola-mapphone-common.dtsi | 14 + drivers/gnss/Kconfig | 8 + drivers/gnss/Makefile | 3 + drivers/gnss/motmdm.c | 419 ++++++++++++++++ drivers/tty/n_gsm.c | 435 +++++++++++++++++ drivers/tty/serdev/Kconfig | 10 + drivers/tty/serdev/Makefile | 1 + drivers/tty/serdev/serdev-ngsm.c | 449 ++++++++++++++++++ include/linux/serdev-gsm.h | 165 +++++++ 11 files changed, 1579 insertions(+) create mode 100644 Documentation/devicetree/bindings/serdev/serdev-ngsm.yaml create mode 100644 drivers/gnss/motmdm.c create mode 100644 drivers/tty/serdev/serdev-ngsm.c create mode 100644 include/linux/serdev-gsm.h -- 2.26.2
next reply other threads:[~2020-05-12 21:47 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-12 21:47 Tony Lindgren [this message] 2020-05-12 21:47 ` [PATCH 1/6] tty: n_gsm: Add support for serdev drivers Tony Lindgren 2020-05-13 19:24 ` Pavel Machek 2020-05-28 9:31 ` Johan Hovold 2020-11-29 20:51 ` Pavel Machek 2020-05-12 21:47 ` [PATCH 2/6] dt-bindings: serdev: ngsm: Add binding for serdev-ngsm Tony Lindgren 2020-05-28 9:38 ` Johan Hovold 2020-05-12 21:47 ` [PATCH 3/6] dt-bindings: serdev: ngsm: Add binding for GNSS child node Tony Lindgren 2020-05-13 19:26 ` Pavel Machek 2020-05-27 19:28 ` Rob Herring 2020-05-28 9:51 ` Johan Hovold 2021-03-05 10:46 ` Pavel Machek 2021-03-05 10:52 ` Johan Hovold 2021-03-24 1:09 ` Pavel Machek 2021-04-01 9:43 ` Johan Hovold 2020-05-12 21:47 ` [PATCH 4/6] serdev: ngsm: Add generic serdev-ngsm driver Tony Lindgren 2020-05-28 12:43 ` Johan Hovold 2020-05-12 21:47 ` [PATCH 5/6] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem Tony Lindgren 2020-05-28 13:06 ` Johan Hovold 2020-05-28 23:38 ` Tony Lindgren 2020-05-12 21:47 ` [PATCH 6/6] ARM: dts: omap4-droid4: Configure modem for serdev-ngsm Tony Lindgren 2020-05-13 19:27 ` Pavel Machek 2020-05-13 19:09 ` [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4 Pavel Machek 2020-05-14 17:31 ` Tony Lindgren 2020-05-22 9:17 ` Greg Kroah-Hartman 2020-05-25 7:44 ` Johan Hovold 2020-05-28 8:39 ` Johan Hovold 2020-05-28 12:57 ` Pavel Machek 2020-07-26 8:25 ` Pavel Machek 2020-07-28 8:36 ` Tony Lindgren 2020-12-16 22:56 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.