From: Johan Hovold <email@example.com> To: Greg Kroah-Hartman <firstname.lastname@example.org> Cc: Tony Lindgren <email@example.com>, Johan Hovold <firstname.lastname@example.org>, Rob Herring <email@example.com>, Alan Cox <firstname.lastname@example.org>, Lee Jones <email@example.com>, Jiri Slaby <firstname.lastname@example.org>, Merlijn Wajer <email@example.com>, Pavel Machek <firstname.lastname@example.org>, Peter Hurley <email@example.com>, Sebastian Reichel <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4 Date: Mon, 25 May 2020 09:44:24 +0200 [thread overview] Message-ID: <20200525074424.GA5276@localhost> (raw) In-Reply-To: <20200522091731.GA1203588@kroah.com> On Fri, May 22, 2020 at 11:17:31AM +0200, Greg Kroah-Hartman wrote: > On Tue, May 12, 2020 at 02:47:07PM -0700, Tony Lindgren wrote: > > Hi all, > > > > Here's the updated set of these patches fixed up for Johan's and > > Pavel's earlier comments. > > > > This series does the following: > > > > 1. Adds functions to n_gsm.c for serdev-ngsm.c driver to use > > > > 2. Adds a generic serdev-ngsm.c driver that brings up the TS 27.010 > > TTY ports configured in devicetree with help of n_gsm.c > > > > 3. Allows the use of standard Linux device drivers for dedicated > > TS 27.010 channels for devices like GNSS and ALSA found on some > > modems for example > > > > 4. Adds a gnss-motmdm consumer driver for the GNSS device found on > > the Motorola Mapphone MDM6600 modem on devices like droid4 > > > > I've placed the serdev-ngsm.c under drivers/tty/serdev as it still > > seems to make most sense with no better places available. It's no > > longer an MFD driver as it really does not need to care what channel > > specific consumer drivers might be configured for the generic driver. > > Now serdev-ngsm just uses of_platform_populate() to probe whatever > > child nodes it might find. > > > > I'm not attached having the driver in drivers/tty/serdev. I just > > don't have any better locations in mind. So using Johan's earlier > > i2c example, the drivers/tty/serdev/serdev-ngsm.c driver is now a > > generic protocol and bus driver, so it's getting closer to the > > the drivers/i2c/busses analogy maybe :) Please do suggest better > > locations other than MFD and misc if you have better ideas. > > > > Now without the chardev support, the /dev/gsmtty* using apps need > > to use "U1234AT+CFUN?" format for the packets. The advantage is > > less kernel code, and we keep the existing /dev/gsmtty* interface. > > > > If we still really need the custom chardev support, that can now > > be added as needed with the channel specific consumer driver(s), > > but looks like this won't be needed based on Pavel's ofono work. > > Johan and Rob, any objection/review of this series? Yeah, sorry I haven't had time to review this yet. I should be able to look at it today. Johan
next prev parent reply other threads:[~2020-05-25 7:44 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-12 21:47 Tony Lindgren 2020-05-12 21:47 ` [PATCH 1/6] tty: n_gsm: Add support for serdev drivers Tony Lindgren 2020-05-13 19:24 ` Pavel Machek 2020-05-28 9:31 ` Johan Hovold 2020-11-29 20:51 ` Pavel Machek 2020-05-12 21:47 ` [PATCH 2/6] dt-bindings: serdev: ngsm: Add binding for serdev-ngsm Tony Lindgren 2020-05-28 9:38 ` Johan Hovold 2020-05-12 21:47 ` [PATCH 3/6] dt-bindings: serdev: ngsm: Add binding for GNSS child node Tony Lindgren 2020-05-13 19:26 ` Pavel Machek 2020-05-27 19:28 ` Rob Herring 2020-05-28 9:51 ` Johan Hovold 2021-03-05 10:46 ` Pavel Machek 2021-03-05 10:52 ` Johan Hovold 2021-03-24 1:09 ` Pavel Machek 2021-04-01 9:43 ` Johan Hovold 2020-05-12 21:47 ` [PATCH 4/6] serdev: ngsm: Add generic serdev-ngsm driver Tony Lindgren 2020-05-28 12:43 ` Johan Hovold 2020-05-12 21:47 ` [PATCH 5/6] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem Tony Lindgren 2020-05-28 13:06 ` Johan Hovold 2020-05-28 23:38 ` Tony Lindgren 2020-05-12 21:47 ` [PATCH 6/6] ARM: dts: omap4-droid4: Configure modem for serdev-ngsm Tony Lindgren 2020-05-13 19:27 ` Pavel Machek 2020-05-13 19:09 ` [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4 Pavel Machek 2020-05-14 17:31 ` Tony Lindgren 2020-05-22 9:17 ` Greg Kroah-Hartman 2020-05-25 7:44 ` Johan Hovold [this message] 2020-05-28 8:39 ` Johan Hovold 2020-05-28 12:57 ` Pavel Machek 2020-07-26 8:25 ` Pavel Machek 2020-07-28 8:36 ` Tony Lindgren 2020-12-16 22:56 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200525074424.GA5276@localhost \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.