From: Tony Lindgren <email@example.com> To: Johan Hovold <firstname.lastname@example.org> Cc: Greg Kroah-Hartman <email@example.com>, Rob Herring <firstname.lastname@example.org>, Lee Jones <email@example.com>, Jiri Slaby <firstname.lastname@example.org>, Merlijn Wajer <email@example.com>, Pavel Machek <firstname.lastname@example.org>, Peter Hurley <email@example.com>, Sebastian Reichel <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH 5/6] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem Date: Thu, 28 May 2020 16:38:18 -0700 [thread overview] Message-ID: <20200528233818.GR37466@atomide.com> (raw) In-Reply-To: <20200528130653.GG10358@localhost> Hi, * Johan Hovold <email@example.com> [200528 13:07]: > On Tue, May 12, 2020 at 02:47:12PM -0700, Tony Lindgren wrote: > > +/* > > + * Motorola MDM GNSS device communicates over a dedicated TS 27.010 channel > > + * using custom data packets. The packets look like AT commands embedded into > > + * a Motorola invented packet using format like "U1234AT+MPDSTART=0,1,100,0". > > + * But it's not an AT compatible serial interface, it's a packet interface > > + * using AT like commands. > > + */ > > So this shouldn't depend on TS 27.010 and instead be a generic gnss > serial driver. Hmm not sure if it makes sense to try to represent packet data as a virtual serial port :) But sure let's at least investigate it. > What does the interface look like over the corresponding USB port? > AT-commands without the U1234 prefix? I don't know if it's using the same commands as the ttyUSB* GNSS device seems disabled. From what I understand, gobi2000 has just $gps_start and $gps_stop commands for the ttyUSB* GNSS device. Those don't exist here. Also the command style seems to follow the modem firmware for various other devices on the modem. > No module parameters please. Either pick a good default or we need to > come up with a generic (sysfs) interface for polled drivers like this > one. OK yeah this could be a generic sysfs option. > How does your "aggressive pm" gsmmux implementation work with the gps if > there are no other clients keeping the modem awake? It seems the modem > would be suspended after 600 milliseconds after being woken up every 10 > seconds or so by the polling gnss driver? Well we still have /dev/gnss open, so GNSS stays active and won't get disabled until the device is closed. The shared GPIOs with the USB PHY are used to signal port traffic. > What happens to the satellite lock in between? Does the request block > until the gps has an updated position? It seems to regain the lock in about one or two seconds, so it's some kind of modem PM state for allowing the SoC to idle it seems. Regards, Tony
next prev parent reply other threads:[~2020-05-28 23:38 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-12 21:47 [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4 Tony Lindgren 2020-05-12 21:47 ` [PATCH 1/6] tty: n_gsm: Add support for serdev drivers Tony Lindgren 2020-05-13 19:24 ` Pavel Machek 2020-05-28 9:31 ` Johan Hovold 2020-11-29 20:51 ` Pavel Machek 2020-05-12 21:47 ` [PATCH 2/6] dt-bindings: serdev: ngsm: Add binding for serdev-ngsm Tony Lindgren 2020-05-28 9:38 ` Johan Hovold 2020-05-12 21:47 ` [PATCH 3/6] dt-bindings: serdev: ngsm: Add binding for GNSS child node Tony Lindgren 2020-05-13 19:26 ` Pavel Machek 2020-05-27 19:28 ` Rob Herring 2020-05-28 9:51 ` Johan Hovold 2021-03-05 10:46 ` Pavel Machek 2021-03-05 10:52 ` Johan Hovold 2021-03-24 1:09 ` Pavel Machek 2021-04-01 9:43 ` Johan Hovold 2020-05-12 21:47 ` [PATCH 4/6] serdev: ngsm: Add generic serdev-ngsm driver Tony Lindgren 2020-05-28 12:43 ` Johan Hovold 2020-05-12 21:47 ` [PATCH 5/6] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem Tony Lindgren 2020-05-28 13:06 ` Johan Hovold 2020-05-28 23:38 ` Tony Lindgren [this message] 2020-05-12 21:47 ` [PATCH 6/6] ARM: dts: omap4-droid4: Configure modem for serdev-ngsm Tony Lindgren 2020-05-13 19:27 ` Pavel Machek 2020-05-13 19:09 ` [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4 Pavel Machek 2020-05-14 17:31 ` Tony Lindgren 2020-05-22 9:17 ` Greg Kroah-Hartman 2020-05-25 7:44 ` Johan Hovold 2020-05-28 8:39 ` Johan Hovold 2020-05-28 12:57 ` Pavel Machek 2020-07-26 8:25 ` Pavel Machek 2020-07-28 8:36 ` Tony Lindgren 2020-12-16 22:56 ` Pavel Machek -- strict thread matches above, loose matches on Subject: below -- 2020-04-30 17:46 [PATCHv6 " Tony Lindgren 2020-04-30 17:46 ` [PATCH 5/6] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem Tony Lindgren 2020-05-01 20:51 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200528233818.GR37466@atomide.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 5/6] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.