From: Matthias Kaehlcke <mka@chromium.org> To: Sharat Masetty <smasetty@codeaurora.org> Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, dri-devel@freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, jcrouse@codeaurora.org, georgi.djakov@linaro.org Subject: Re: [PATCH 2/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp Date: Thu, 14 May 2020 16:45:06 -0700 [thread overview] Message-ID: <20200514234506.GS4525@google.com> (raw) In-Reply-To: <1589453659-27581-3-git-send-email-smasetty@codeaurora.org> On Thu, May 14, 2020 at 04:24:15PM +0530, Sharat Masetty wrote: > Subject: arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp nit: s/opp/OPPs/ > > Add opp-peak-kBps bindings to the GPU opp table, listing the peak > GPU -> DDR bandwidth requirement for each opp level. This will be > used to scale the DDR bandwidth along with the GPU frequency dynamically. > > Signed-off-by: Sharat Masetty <smasetty@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 0ce9921..89f7767 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1392,36 +1392,43 @@ > opp-800000000 { > opp-hz = /bits/ 64 <800000000>; > opp-level = <RPMH_REGULATOR_LEVEL_TURBO>; > + opp-peak-kBps = <8532000>; > }; > > opp-650000000 { > opp-hz = /bits/ 64 <650000000>; > opp-level = <RPMH_REGULATOR_LEVEL_NOM_L1>; > + opp-peak-kBps = <7216000>; > }; > > opp-565000000 { > opp-hz = /bits/ 64 <565000000>; > opp-level = <RPMH_REGULATOR_LEVEL_NOM>; > + opp-peak-kBps = <5412000>; > }; > > opp-430000000 { > opp-hz = /bits/ 64 <430000000>; > opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>; > + opp-peak-kBps = <5412000>; I suppose it's intentional that the bandwidth is the same as for opp-565000000, just want to mention it for if it's a C&P error. > }; > > opp-355000000 { > opp-hz = /bits/ 64 <355000000>; > opp-level = <RPMH_REGULATOR_LEVEL_SVS>; > + opp-peak-kBps = <3072000>; > }; > > opp-267000000 { > opp-hz = /bits/ 64 <267000000>; > opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>; > + opp-peak-kBps = <3072000>; > }; ditto > opp-180000000 { > opp-hz = /bits/ 64 <180000000>; > opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>; > + opp-peak-kBps = <1804000>; > }; > }; > }; assuming the repeated bandwidths are indeed intentional: Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org> To: Sharat Masetty <smasetty@codeaurora.org> Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@freedesktop.org, freedreno@lists.freedesktop.org, georgi.djakov@linaro.org Subject: Re: [PATCH 2/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp Date: Thu, 14 May 2020 16:45:06 -0700 [thread overview] Message-ID: <20200514234506.GS4525@google.com> (raw) In-Reply-To: <1589453659-27581-3-git-send-email-smasetty@codeaurora.org> On Thu, May 14, 2020 at 04:24:15PM +0530, Sharat Masetty wrote: > Subject: arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp nit: s/opp/OPPs/ > > Add opp-peak-kBps bindings to the GPU opp table, listing the peak > GPU -> DDR bandwidth requirement for each opp level. This will be > used to scale the DDR bandwidth along with the GPU frequency dynamically. > > Signed-off-by: Sharat Masetty <smasetty@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 0ce9921..89f7767 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1392,36 +1392,43 @@ > opp-800000000 { > opp-hz = /bits/ 64 <800000000>; > opp-level = <RPMH_REGULATOR_LEVEL_TURBO>; > + opp-peak-kBps = <8532000>; > }; > > opp-650000000 { > opp-hz = /bits/ 64 <650000000>; > opp-level = <RPMH_REGULATOR_LEVEL_NOM_L1>; > + opp-peak-kBps = <7216000>; > }; > > opp-565000000 { > opp-hz = /bits/ 64 <565000000>; > opp-level = <RPMH_REGULATOR_LEVEL_NOM>; > + opp-peak-kBps = <5412000>; > }; > > opp-430000000 { > opp-hz = /bits/ 64 <430000000>; > opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>; > + opp-peak-kBps = <5412000>; I suppose it's intentional that the bandwidth is the same as for opp-565000000, just want to mention it for if it's a C&P error. > }; > > opp-355000000 { > opp-hz = /bits/ 64 <355000000>; > opp-level = <RPMH_REGULATOR_LEVEL_SVS>; > + opp-peak-kBps = <3072000>; > }; > > opp-267000000 { > opp-hz = /bits/ 64 <267000000>; > opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>; > + opp-peak-kBps = <3072000>; > }; ditto > opp-180000000 { > opp-hz = /bits/ 64 <180000000>; > opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>; > + opp-peak-kBps = <1804000>; > }; > }; > }; assuming the repeated bandwidths are indeed intentional: Reviewed-by: Matthias Kaehlcke <mka@chromium.org> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-14 23:45 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-14 10:54 [PATCH 0/6] Add support for GPU DDR BW scaling Sharat Masetty 2020-05-14 10:54 ` Sharat Masetty 2020-05-14 10:54 ` [PATCH 1/6] arm64: dts: qcom: sc7180: Add interconnect bindings for GPU Sharat Masetty 2020-05-14 10:54 ` Sharat Masetty 2020-05-14 23:37 ` Matthias Kaehlcke 2020-05-14 23:37 ` Matthias Kaehlcke 2020-05-14 10:54 ` [PATCH 2/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp Sharat Masetty 2020-05-14 10:54 ` Sharat Masetty 2020-05-14 23:45 ` Matthias Kaehlcke [this message] 2020-05-14 23:45 ` Matthias Kaehlcke 2020-05-14 10:54 ` [PATCH 3/6] OPP: Add and export helper to set bandwidth Sharat Masetty 2020-05-14 10:54 ` Sharat Masetty 2020-05-15 0:32 ` Matthias Kaehlcke 2020-05-15 0:32 ` Matthias Kaehlcke 2020-05-14 10:54 ` [PATCH 4/6] drm: msm: a6xx: send opp instead of a frequency Sharat Masetty 2020-05-14 10:54 ` Sharat Masetty 2020-05-15 0:39 ` Matthias Kaehlcke 2020-05-15 0:39 ` Matthias Kaehlcke 2020-05-15 0:58 ` Matthias Kaehlcke 2020-05-15 0:58 ` Matthias Kaehlcke 2020-05-14 10:54 ` [PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth Sharat Masetty 2020-05-14 10:54 ` Sharat Masetty 2020-05-15 1:05 ` Matthias Kaehlcke 2020-05-15 1:05 ` Matthias Kaehlcke 2020-05-18 14:23 ` Jordan Crouse 2020-05-18 14:23 ` Jordan Crouse 2020-05-18 16:25 ` [Freedreno] " Rob Clark 2020-05-18 16:25 ` Rob Clark 2020-05-27 8:47 ` Sharat Masetty 2020-05-27 8:47 ` Sharat Masetty 2020-05-27 15:38 ` Rob Clark 2020-05-27 15:38 ` Rob Clark 2020-05-27 17:31 ` Saravana Kannan 2020-05-27 17:31 ` Saravana Kannan 2020-05-27 20:41 ` Sibi Sankar 2020-05-27 20:41 ` Sibi Sankar 2020-05-27 20:51 ` Jordan Crouse 2020-05-27 20:51 ` Jordan Crouse 2020-05-28 11:02 ` Sharat Masetty 2020-05-28 11:02 ` Sharat Masetty 2020-05-14 10:54 ` [PATCH 6/6] dt-bindings: drm/msm/gpu: Document gpu opp table Sharat Masetty 2020-05-14 10:54 ` Sharat Masetty 2020-05-28 15:14 ` Rob Herring 2020-05-28 15:14 ` Rob Herring 2020-05-14 23:56 ` [PATCH 0/6] Add support for GPU DDR BW scaling Matthias Kaehlcke 2020-05-14 23:56 ` Matthias Kaehlcke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200514234506.GS4525@google.com \ --to=mka@chromium.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=georgi.djakov@linaro.org \ --cc=jcrouse@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=smasetty@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.