From: Sudeep Holla <sudeep.holla@arm.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Steven Price <steven.price@arm.com>, harb@amperecomputing.com, Will Deacon <will@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v4 7/7] firmware: smccc: Add ARCH_SOC_ID support Date: Mon, 18 May 2020 12:55:46 +0100 [thread overview] Message-ID: <20200518115546.GB16262@bogus> (raw) In-Reply-To: <CAK8P3a20R+H6m5GZj2_0w3s-xF+J_qSVrQH8EjyQXe6+9WTYxw@mail.gmail.com> On Mon, May 18, 2020 at 11:30:21AM +0200, Arnd Bergmann wrote: > On Mon, May 18, 2020 at 11:12 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > > +static ssize_t > > +jep106_cont_bank_code_show(struct device *dev, struct device_attribute *attr, > > + char *buf) > > +{ > > + return sprintf(buf, "0x%02x\n", JEP106_BANK_CONT_CODE(soc_id_version)); > > +} > > + > > +static DEVICE_ATTR_RO(jep106_cont_bank_code); > > + > > +static ssize_t > > +jep106_identification_code_show(struct device *dev, > > + struct device_attribute *attr, char *buf) > > +{ > > + return sprintf(buf, "0x%02x\n", JEP106_ID_CODE(soc_id_version)); > > +} > > I think we should try hard to avoid nonstandard attributes for the soc device. > I agree with that in general but this is bit different for below mentioned reason. > Did you run into a problem with finding one of the existing attributes > that can be used to hold the fields? > Not really! The 2 JEP106 codes can be used to derive the manufacturer which could match one of the existing attributes. However doing so might require importing the huge JEP106 list as it needs to be maintained and updated in the kernel. Also that approach will have the compatibility issue and that is the reason for introducing these attributes representing raw values for userspace. -- Regards, Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Steven Price <steven.price@arm.com>, harb@amperecomputing.com, Will Deacon <will@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v4 7/7] firmware: smccc: Add ARCH_SOC_ID support Date: Mon, 18 May 2020 12:55:46 +0100 [thread overview] Message-ID: <20200518115546.GB16262@bogus> (raw) In-Reply-To: <CAK8P3a20R+H6m5GZj2_0w3s-xF+J_qSVrQH8EjyQXe6+9WTYxw@mail.gmail.com> On Mon, May 18, 2020 at 11:30:21AM +0200, Arnd Bergmann wrote: > On Mon, May 18, 2020 at 11:12 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > > +static ssize_t > > +jep106_cont_bank_code_show(struct device *dev, struct device_attribute *attr, > > + char *buf) > > +{ > > + return sprintf(buf, "0x%02x\n", JEP106_BANK_CONT_CODE(soc_id_version)); > > +} > > + > > +static DEVICE_ATTR_RO(jep106_cont_bank_code); > > + > > +static ssize_t > > +jep106_identification_code_show(struct device *dev, > > + struct device_attribute *attr, char *buf) > > +{ > > + return sprintf(buf, "0x%02x\n", JEP106_ID_CODE(soc_id_version)); > > +} > > I think we should try hard to avoid nonstandard attributes for the soc device. > I agree with that in general but this is bit different for below mentioned reason. > Did you run into a problem with finding one of the existing attributes > that can be used to hold the fields? > Not really! The 2 JEP106 codes can be used to derive the manufacturer which could match one of the existing attributes. However doing so might require importing the huge JEP106 list as it needs to be maintained and updated in the kernel. Also that approach will have the compatibility issue and that is the reason for introducing these attributes representing raw values for userspace. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-18 11:55 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-18 9:12 [PATCH v4 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support Sudeep Holla 2020-05-18 9:12 ` Sudeep Holla 2020-05-18 9:12 ` [PATCH v4 1/7] firmware: smccc: Add HAVE_ARM_SMCCC_DISCOVERY to identify SMCCC v1.1 and above Sudeep Holla 2020-05-18 9:12 ` Sudeep Holla 2020-05-18 9:12 ` [PATCH v4 2/7] firmware: smccc: Update link to latest SMCCC specification Sudeep Holla 2020-05-18 9:12 ` Sudeep Holla 2020-05-18 9:12 ` [PATCH v4 3/7] firmware: smccc: Add the definition for SMCCCv1.2 version/error codes Sudeep Holla 2020-05-18 9:12 ` Sudeep Holla 2020-05-18 9:12 ` [PATCH v4 4/7] firmware: smccc: Drop smccc_version enum and use ARM_SMCCC_VERSION_1_x instead Sudeep Holla 2020-05-18 9:12 ` Sudeep Holla 2020-05-18 9:12 ` [PATCH v4 5/7] firmware: smccc: Refactor SMCCC specific bits into separate file Sudeep Holla 2020-05-18 9:12 ` Sudeep Holla 2020-05-19 12:00 ` kbuild test robot 2020-05-20 10:29 ` kbuild test robot 2020-05-18 9:12 ` [PATCH v4 6/7] firmware: smccc: Add function to fetch SMCCC version Sudeep Holla 2020-05-18 9:12 ` Sudeep Holla 2020-05-18 9:12 ` [PATCH v4 7/7] firmware: smccc: Add ARCH_SOC_ID support Sudeep Holla 2020-05-18 9:12 ` Sudeep Holla 2020-05-18 9:30 ` Arnd Bergmann 2020-05-18 9:30 ` Arnd Bergmann 2020-05-18 11:55 ` Sudeep Holla [this message] 2020-05-18 11:55 ` Sudeep Holla 2020-05-20 21:51 ` Arnd Bergmann 2020-05-20 21:51 ` Arnd Bergmann 2020-05-21 7:07 ` Sudeep Holla 2020-05-21 7:07 ` Sudeep Holla 2020-05-20 21:29 ` [PATCH v4 0/7] firmware: smccc: Add basic SMCCC v1.2 + " Will Deacon 2020-05-20 21:29 ` Will Deacon 2020-05-20 21:54 ` Arnd Bergmann 2020-05-20 21:54 ` Arnd Bergmann 2020-05-21 7:07 ` Sudeep Holla 2020-05-21 7:07 ` Sudeep Holla 2020-05-21 7:34 ` Arnd Bergmann 2020-05-21 7:34 ` Arnd Bergmann 2020-05-21 7:57 ` Will Deacon 2020-05-21 7:57 ` Will Deacon 2020-05-21 8:10 ` Sudeep Holla 2020-05-21 8:10 ` Sudeep Holla 2020-05-21 9:06 ` Arnd Bergmann 2020-05-21 9:06 ` Arnd Bergmann 2020-05-21 9:15 ` Sudeep Holla 2020-05-21 9:15 ` Sudeep Holla 2020-05-21 9:17 ` Will Deacon 2020-05-21 9:17 ` Will Deacon 2020-05-21 9:26 ` Sudeep Holla 2020-05-21 9:26 ` Sudeep Holla 2020-05-21 10:14 ` Will Deacon 2020-05-21 10:14 ` Will Deacon 2020-05-21 10:24 ` Sudeep Holla 2020-05-21 10:24 ` Sudeep Holla 2020-05-21 9:30 ` Arnd Bergmann 2020-05-21 9:30 ` Arnd Bergmann 2020-05-21 10:14 ` Russell King - ARM Linux admin 2020-05-21 10:14 ` Russell King - ARM Linux admin 2020-05-21 10:31 ` Arnd Bergmann 2020-05-21 10:31 ` Arnd Bergmann 2020-05-21 11:46 ` Russell King - ARM Linux admin 2020-05-21 11:46 ` Russell King - ARM Linux admin 2020-05-21 8:05 ` Sudeep Holla 2020-05-21 8:05 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200518115546.GB16262@bogus \ --to=sudeep.holla@arm.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=harb@amperecomputing.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=steven.price@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.