From: Will Deacon <will@kernel.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Steven Price <steven.price@arm.com>,
harb@amperecomputing.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support
Date: Thu, 21 May 2020 11:14:38 +0100 [thread overview]
Message-ID: <20200521101437.GB5360@willie-the-truck> (raw)
In-Reply-To: <20200521092627.GB6425@bogus>
On Thu, May 21, 2020 at 10:26:27AM +0100, Sudeep Holla wrote:
> On Thu, May 21, 2020 at 10:17:39AM +0100, Will Deacon wrote:
> > On Thu, May 21, 2020 at 11:06:23AM +0200, Arnd Bergmann wrote:
> > > On Thu, May 21, 2020 at 10:11 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
> > > > /me confused. Do you need the fix for this warning or you are happy to ignore?
> > >
> > > I want a fix for that, as I hope we can eventually turn this warning on by
> > > default and stop playing whack-a-mole when they come up. Most of these
> > > warnings are harmless, but occasionally the prototypes don't match exactly
> > > and cause real bugs depending on the configuration, and ensuring both
> > > sides include a common header file is an easy way to make it work
> > > more reliably.
> > >
> > > Note that the warning should come up for either W=1 or C=1, and I also
> > > think that
> > > new code should generally be written sparse-clean and have no warnings with
> > > 'make C=1' as a rule.
> >
> > Fair enough. Is anybody working on a tree-wide sweep for this, like we've
> > done for other things such as zero-length arrays? If so, I can start
> > enforcing this in the arch code as well (I haven't been so far, even though
> > I do run sparse on every commit).
> >
> > Anyway, I've dropped the last patch from the branch, and we can put a fix
> > for the missing prototype on top.
> >
>
> Thanks Will, sorry for the trouble. Though I can send the fix for the
> missing prototype right away, I would like to get my clang setup working
> as an opportunity. clang-8 that I have is failing vanilla v5.7-rc6
> when expanding arm_smccc_1_1_*
No trouble at all, really. I also saw this from Nathan the other day, which
may help you get up and running with clang:
https://lore.kernel.org/r/20200520024736.GA854786@ubuntu-s3-xlarge-x86
(but I haven't tried it myself, as I'm just using the Android binary)
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Steven Price <steven.price@arm.com>,
harb@amperecomputing.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support
Date: Thu, 21 May 2020 11:14:38 +0100 [thread overview]
Message-ID: <20200521101437.GB5360@willie-the-truck> (raw)
In-Reply-To: <20200521092627.GB6425@bogus>
On Thu, May 21, 2020 at 10:26:27AM +0100, Sudeep Holla wrote:
> On Thu, May 21, 2020 at 10:17:39AM +0100, Will Deacon wrote:
> > On Thu, May 21, 2020 at 11:06:23AM +0200, Arnd Bergmann wrote:
> > > On Thu, May 21, 2020 at 10:11 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
> > > > /me confused. Do you need the fix for this warning or you are happy to ignore?
> > >
> > > I want a fix for that, as I hope we can eventually turn this warning on by
> > > default and stop playing whack-a-mole when they come up. Most of these
> > > warnings are harmless, but occasionally the prototypes don't match exactly
> > > and cause real bugs depending on the configuration, and ensuring both
> > > sides include a common header file is an easy way to make it work
> > > more reliably.
> > >
> > > Note that the warning should come up for either W=1 or C=1, and I also
> > > think that
> > > new code should generally be written sparse-clean and have no warnings with
> > > 'make C=1' as a rule.
> >
> > Fair enough. Is anybody working on a tree-wide sweep for this, like we've
> > done for other things such as zero-length arrays? If so, I can start
> > enforcing this in the arch code as well (I haven't been so far, even though
> > I do run sparse on every commit).
> >
> > Anyway, I've dropped the last patch from the branch, and we can put a fix
> > for the missing prototype on top.
> >
>
> Thanks Will, sorry for the trouble. Though I can send the fix for the
> missing prototype right away, I would like to get my clang setup working
> as an opportunity. clang-8 that I have is failing vanilla v5.7-rc6
> when expanding arm_smccc_1_1_*
No trouble at all, really. I also saw this from Nathan the other day, which
may help you get up and running with clang:
https://lore.kernel.org/r/20200520024736.GA854786@ubuntu-s3-xlarge-x86
(but I haven't tried it myself, as I'm just using the Android binary)
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-21 10:14 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 9:12 [PATCH v4 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support Sudeep Holla
2020-05-18 9:12 ` Sudeep Holla
2020-05-18 9:12 ` [PATCH v4 1/7] firmware: smccc: Add HAVE_ARM_SMCCC_DISCOVERY to identify SMCCC v1.1 and above Sudeep Holla
2020-05-18 9:12 ` Sudeep Holla
2020-05-18 9:12 ` [PATCH v4 2/7] firmware: smccc: Update link to latest SMCCC specification Sudeep Holla
2020-05-18 9:12 ` Sudeep Holla
2020-05-18 9:12 ` [PATCH v4 3/7] firmware: smccc: Add the definition for SMCCCv1.2 version/error codes Sudeep Holla
2020-05-18 9:12 ` Sudeep Holla
2020-05-18 9:12 ` [PATCH v4 4/7] firmware: smccc: Drop smccc_version enum and use ARM_SMCCC_VERSION_1_x instead Sudeep Holla
2020-05-18 9:12 ` Sudeep Holla
2020-05-18 9:12 ` [PATCH v4 5/7] firmware: smccc: Refactor SMCCC specific bits into separate file Sudeep Holla
2020-05-18 9:12 ` Sudeep Holla
2020-05-19 12:00 ` kbuild test robot
2020-05-20 10:29 ` kbuild test robot
2020-05-18 9:12 ` [PATCH v4 6/7] firmware: smccc: Add function to fetch SMCCC version Sudeep Holla
2020-05-18 9:12 ` Sudeep Holla
2020-05-18 9:12 ` [PATCH v4 7/7] firmware: smccc: Add ARCH_SOC_ID support Sudeep Holla
2020-05-18 9:12 ` Sudeep Holla
2020-05-18 9:30 ` Arnd Bergmann
2020-05-18 9:30 ` Arnd Bergmann
2020-05-18 11:55 ` Sudeep Holla
2020-05-18 11:55 ` Sudeep Holla
2020-05-20 21:51 ` Arnd Bergmann
2020-05-20 21:51 ` Arnd Bergmann
2020-05-21 7:07 ` Sudeep Holla
2020-05-21 7:07 ` Sudeep Holla
2020-05-20 21:29 ` [PATCH v4 0/7] firmware: smccc: Add basic SMCCC v1.2 + " Will Deacon
2020-05-20 21:29 ` Will Deacon
2020-05-20 21:54 ` Arnd Bergmann
2020-05-20 21:54 ` Arnd Bergmann
2020-05-21 7:07 ` Sudeep Holla
2020-05-21 7:07 ` Sudeep Holla
2020-05-21 7:34 ` Arnd Bergmann
2020-05-21 7:34 ` Arnd Bergmann
2020-05-21 7:57 ` Will Deacon
2020-05-21 7:57 ` Will Deacon
2020-05-21 8:10 ` Sudeep Holla
2020-05-21 8:10 ` Sudeep Holla
2020-05-21 9:06 ` Arnd Bergmann
2020-05-21 9:06 ` Arnd Bergmann
2020-05-21 9:15 ` Sudeep Holla
2020-05-21 9:15 ` Sudeep Holla
2020-05-21 9:17 ` Will Deacon
2020-05-21 9:17 ` Will Deacon
2020-05-21 9:26 ` Sudeep Holla
2020-05-21 9:26 ` Sudeep Holla
2020-05-21 10:14 ` Will Deacon [this message]
2020-05-21 10:14 ` Will Deacon
2020-05-21 10:24 ` Sudeep Holla
2020-05-21 10:24 ` Sudeep Holla
2020-05-21 9:30 ` Arnd Bergmann
2020-05-21 9:30 ` Arnd Bergmann
2020-05-21 10:14 ` Russell King - ARM Linux admin
2020-05-21 10:14 ` Russell King - ARM Linux admin
2020-05-21 10:31 ` Arnd Bergmann
2020-05-21 10:31 ` Arnd Bergmann
2020-05-21 11:46 ` Russell King - ARM Linux admin
2020-05-21 11:46 ` Russell King - ARM Linux admin
2020-05-21 8:05 ` Sudeep Holla
2020-05-21 8:05 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521101437.GB5360@willie-the-truck \
--to=will@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=harb@amperecomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.