All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramalingam C <ramalingam.c@intel.com>
To: Sean Paul <sean@poorly.run>
Cc: intel-gfx@lists.freedesktop.org, seanpaul@chromium.org,
	dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com
Subject: Re: [PATCH] drm/i915/hdcp: Add additional R0' wait
Date: Wed, 20 May 2020 12:16:02 +0530	[thread overview]
Message-ID: <20200520064602.GA20133@intel.com> (raw)
In-Reply-To: <20200519221621.19931-1-sean@poorly.run>

On 2020-05-19 at 18:16:21 -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> We're seeing some R0' mismatches in the field, particularly with
I think you want to say Vprime verification? delay is added in between
the retry for vprime verfication.

-Ram
> repeaters. I'm guessing the (already lenient) 300ms wait time isn't
> enough for some setups. So add an additional wait when R0' is
> mismatched.
> 
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
>  drivers/gpu/drm/i915/display/intel_hdcp.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index 2cbc4619b4ce..924a717a4fa4 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -592,6 +592,9 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>  						  bstatus);
>  		if (!ret)
>  			break;
> +
> +		/* Maybe the sink is lazy, give it some more time */
> +		usleep_range(10000, 50000);
>  	}
>  
>  	if (i == tries) {
> -- 
> Sean Paul, Software Engineer, Google / Chromium OS
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Ramalingam C <ramalingam.c@intel.com>
To: Sean Paul <sean@poorly.run>
Cc: intel-gfx@lists.freedesktop.org, seanpaul@chromium.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Add additional R0' wait
Date: Wed, 20 May 2020 12:16:02 +0530	[thread overview]
Message-ID: <20200520064602.GA20133@intel.com> (raw)
In-Reply-To: <20200519221621.19931-1-sean@poorly.run>

On 2020-05-19 at 18:16:21 -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> We're seeing some R0' mismatches in the field, particularly with
I think you want to say Vprime verification? delay is added in between
the retry for vprime verfication.

-Ram
> repeaters. I'm guessing the (already lenient) 300ms wait time isn't
> enough for some setups. So add an additional wait when R0' is
> mismatched.
> 
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
>  drivers/gpu/drm/i915/display/intel_hdcp.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index 2cbc4619b4ce..924a717a4fa4 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -592,6 +592,9 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>  						  bstatus);
>  		if (!ret)
>  			break;
> +
> +		/* Maybe the sink is lazy, give it some more time */
> +		usleep_range(10000, 50000);
>  	}
>  
>  	if (i == tries) {
> -- 
> Sean Paul, Software Engineer, Google / Chromium OS
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-05-20  6:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 22:16 [PATCH] drm/i915/hdcp: Add additional R0' wait Sean Paul
2020-05-19 22:16 ` [Intel-gfx] " Sean Paul
2020-05-20  0:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-20  6:46 ` Ramalingam C [this message]
2020-05-20  6:46   ` [Intel-gfx] [PATCH] " Ramalingam C
2020-05-20 13:08   ` [PATCH v2] " Sean Paul
2020-05-20 13:08     ` [Intel-gfx] " Sean Paul
2020-05-20 19:50     ` Sean Paul
2020-05-20 19:50       ` [Intel-gfx] " Sean Paul
2020-05-21  5:12       ` Ramalingam C
2020-05-21  5:12         ` [Intel-gfx] " Ramalingam C
2020-05-20 13:16 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2020-05-20 14:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Add additional R0' wait (rev2) Patchwork
2020-05-21  5:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200520064602.GA20133@intel.com \
    --to=ramalingam.c@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=sean@poorly.run \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.