From: Will Deacon <will@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
john.garry@huawei.com, mark.rutland@arm.com, shawnguo@kernel.org,
linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace
Date: Wed, 20 May 2020 08:33:04 +0100 [thread overview]
Message-ID: <20200520073304.GA23534@willie-the-truck> (raw)
In-Reply-To: <20200519185125.GB453195@bogus>
On Tue, May 19, 2020 at 12:51:25PM -0600, Rob Herring wrote:
> On Tue, May 12, 2020 at 03:31:13PM +0800, Joakim Zhang wrote:
> > +static ssize_t ddr_perf_identifier_show(struct device *dev,
> > + struct device_attribute *attr,
> > + char *page)
> > +{
> > + struct ddr_pmu *pmu = dev_get_drvdata(dev);
> > +
> > + return sprintf(page, "%s\n", pmu->devtype_data->identifier);
>
> Why do we need yet another way to identify the SoC from userspace?
I also really dislike this. What's the preferred way to identify the SoC
from userspace? It's needed so that the perf userspace tool can describe
perf events that are supported for the PMU, as this isn't probe-able
directly from the hardware. We have the same issue with the SMMUv3 PMCG [1],
and so we need to solve the problem for both DT and ACPI.
Will
[1] https://lore.kernel.org/r/1587120634-19666-1-git-send-email-john.garry@huawei.com
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
john.garry@huawei.com, Joakim Zhang <qiangqing.zhang@nxp.com>,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace
Date: Wed, 20 May 2020 08:33:04 +0100 [thread overview]
Message-ID: <20200520073304.GA23534@willie-the-truck> (raw)
In-Reply-To: <20200519185125.GB453195@bogus>
On Tue, May 19, 2020 at 12:51:25PM -0600, Rob Herring wrote:
> On Tue, May 12, 2020 at 03:31:13PM +0800, Joakim Zhang wrote:
> > +static ssize_t ddr_perf_identifier_show(struct device *dev,
> > + struct device_attribute *attr,
> > + char *page)
> > +{
> > + struct ddr_pmu *pmu = dev_get_drvdata(dev);
> > +
> > + return sprintf(page, "%s\n", pmu->devtype_data->identifier);
>
> Why do we need yet another way to identify the SoC from userspace?
I also really dislike this. What's the preferred way to identify the SoC
from userspace? It's needed so that the perf userspace tool can describe
perf events that are supported for the PMU, as this isn't probe-able
directly from the hardware. We have the same issue with the SMMUv3 PMCG [1],
and so we need to solve the problem for both DT and ACPI.
Will
[1] https://lore.kernel.org/r/1587120634-19666-1-git-send-email-john.garry@huawei.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-20 7:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 7:31 [PATCH V1 RESEND 0/3] perf/imx_ddr: Add system PMU support Joakim Zhang
2020-05-12 7:31 ` Joakim Zhang
2020-05-12 7:31 ` [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace Joakim Zhang
2020-05-12 7:31 ` Joakim Zhang
2020-05-19 18:51 ` Rob Herring
2020-05-19 18:51 ` Rob Herring
2020-05-20 2:56 ` Joakim Zhang
2020-05-20 2:56 ` Joakim Zhang
2020-05-20 15:10 ` Rob Herring
2020-05-20 15:10 ` Rob Herring
2020-05-20 7:33 ` Will Deacon [this message]
2020-05-20 7:33 ` Will Deacon
2020-05-20 15:23 ` Rob Herring
2020-05-20 15:23 ` Rob Herring
2020-05-21 13:04 ` Will Deacon
2020-05-21 13:04 ` Will Deacon
2020-05-21 14:00 ` John Garry
2020-05-21 14:00 ` John Garry
2020-05-27 14:34 ` John Garry
2020-05-27 14:34 ` John Garry
2020-05-28 1:35 ` Shaokun Zhang
2020-05-28 1:35 ` Shaokun Zhang
2020-05-21 13:26 ` Mark Rutland
2020-05-21 13:26 ` Mark Rutland
2020-05-21 14:16 ` John Garry
2020-05-21 14:16 ` John Garry
2020-05-12 7:31 ` [PATCH V1 RESEND 2/3] bindings/perf/imx-ddr: update compatible string Joakim Zhang
2020-05-12 7:31 ` Joakim Zhang
2020-05-19 18:47 ` Rob Herring
2020-05-19 18:47 ` Rob Herring
2020-07-15 11:03 ` John Garry
2020-07-15 11:03 ` John Garry
2020-07-20 8:57 ` Joakim Zhang
2020-07-20 8:57 ` Joakim Zhang
2020-05-12 7:31 ` [PATCH V1 RESEND 3/3] arch: arm64: imx8mq/m/n: remove unused " Joakim Zhang
2020-05-12 7:31 ` Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520073304.GA23534@willie-the-truck \
--to=will@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=qiangqing.zhang@nxp.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.