From: Joakim Zhang <qiangqing.zhang@nxp.com> To: John Garry <john.garry@huawei.com>, "will@kernel.org" <will@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org> Cc: dl-linux-imx <linux-imx@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH V1 RESEND 2/3] bindings/perf/imx-ddr: update compatible string Date: Mon, 20 Jul 2020 08:57:48 +0000 [thread overview] Message-ID: <DB8PR04MB679528762BB39926FBCDE36EE67B0@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1f530ea9-c294-64ec-fd10-54129e0b4845@huawei.com> > -----Original Message----- > From: John Garry <john.garry@huawei.com> > Sent: 2020年7月15日 19:04 > To: Joakim Zhang <qiangqing.zhang@nxp.com>; will@kernel.org; > mark.rutland@arm.com; robh+dt@kernel.org; shawnguo@kernel.org > Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH V1 RESEND 2/3] bindings/perf/imx-ddr: update compatible > string > > On 12/05/2020 08:31, Joakim Zhang wrote: > > Update compatible string according to driver change.` > > > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > > --- > > Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > index 7822a806ea0a..b27a1d4fec78 100644 > > --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > @@ -4,7 +4,9 @@ Required properties: > > > > Hi Joakim, > > > - compatible: should be one of: > > "fsl,imx8-ddr-pmu" > > - "fsl,imx8m-ddr-pmu" > > + "fsl,imx8mq-ddr-pmu" > > + "fsl,imx8mm-ddr-pmu" > > I noticed that some of the compat strings being added are used in imx dtsi files > today: > > john@localhost:~/linux> git grep "fsl,imx8mm-ddr-pmu" > arch/arm64/boot/dts/freescale/imx8mm.dtsi: compatible = > "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu"; > > Any specific reason why they are not described in the dt bindings already? > > I don't follow dt so much anymore, so don't know the policies. Hi John, What I did is not standard, any compat string in dts file should be described in the dt bindings. I will keep in mind. Best Regards, Joakim Zhang > > + "fsl,imx8mn-ddr-pmu" > > Thanks, > John
WARNING: multiple messages have this Message-ID (diff)
From: Joakim Zhang <qiangqing.zhang@nxp.com> To: John Garry <john.garry@huawei.com>, "will@kernel.org" <will@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH V1 RESEND 2/3] bindings/perf/imx-ddr: update compatible string Date: Mon, 20 Jul 2020 08:57:48 +0000 [thread overview] Message-ID: <DB8PR04MB679528762BB39926FBCDE36EE67B0@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1f530ea9-c294-64ec-fd10-54129e0b4845@huawei.com> > -----Original Message----- > From: John Garry <john.garry@huawei.com> > Sent: 2020年7月15日 19:04 > To: Joakim Zhang <qiangqing.zhang@nxp.com>; will@kernel.org; > mark.rutland@arm.com; robh+dt@kernel.org; shawnguo@kernel.org > Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH V1 RESEND 2/3] bindings/perf/imx-ddr: update compatible > string > > On 12/05/2020 08:31, Joakim Zhang wrote: > > Update compatible string according to driver change.` > > > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > > --- > > Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > index 7822a806ea0a..b27a1d4fec78 100644 > > --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > @@ -4,7 +4,9 @@ Required properties: > > > > Hi Joakim, > > > - compatible: should be one of: > > "fsl,imx8-ddr-pmu" > > - "fsl,imx8m-ddr-pmu" > > + "fsl,imx8mq-ddr-pmu" > > + "fsl,imx8mm-ddr-pmu" > > I noticed that some of the compat strings being added are used in imx dtsi files > today: > > john@localhost:~/linux> git grep "fsl,imx8mm-ddr-pmu" > arch/arm64/boot/dts/freescale/imx8mm.dtsi: compatible = > "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu"; > > Any specific reason why they are not described in the dt bindings already? > > I don't follow dt so much anymore, so don't know the policies. Hi John, What I did is not standard, any compat string in dts file should be described in the dt bindings. I will keep in mind. Best Regards, Joakim Zhang > > + "fsl,imx8mn-ddr-pmu" > > Thanks, > John _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-20 8:57 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-12 7:31 [PATCH V1 RESEND 0/3] perf/imx_ddr: Add system PMU support Joakim Zhang 2020-05-12 7:31 ` Joakim Zhang 2020-05-12 7:31 ` [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace Joakim Zhang 2020-05-12 7:31 ` Joakim Zhang 2020-05-19 18:51 ` Rob Herring 2020-05-19 18:51 ` Rob Herring 2020-05-20 2:56 ` Joakim Zhang 2020-05-20 2:56 ` Joakim Zhang 2020-05-20 15:10 ` Rob Herring 2020-05-20 15:10 ` Rob Herring 2020-05-20 7:33 ` Will Deacon 2020-05-20 7:33 ` Will Deacon 2020-05-20 15:23 ` Rob Herring 2020-05-20 15:23 ` Rob Herring 2020-05-21 13:04 ` Will Deacon 2020-05-21 13:04 ` Will Deacon 2020-05-21 14:00 ` John Garry 2020-05-21 14:00 ` John Garry 2020-05-27 14:34 ` John Garry 2020-05-27 14:34 ` John Garry 2020-05-28 1:35 ` Shaokun Zhang 2020-05-28 1:35 ` Shaokun Zhang 2020-05-21 13:26 ` Mark Rutland 2020-05-21 13:26 ` Mark Rutland 2020-05-21 14:16 ` John Garry 2020-05-21 14:16 ` John Garry 2020-05-12 7:31 ` [PATCH V1 RESEND 2/3] bindings/perf/imx-ddr: update compatible string Joakim Zhang 2020-05-12 7:31 ` Joakim Zhang 2020-05-19 18:47 ` Rob Herring 2020-05-19 18:47 ` Rob Herring 2020-07-15 11:03 ` John Garry 2020-07-15 11:03 ` John Garry 2020-07-20 8:57 ` Joakim Zhang [this message] 2020-07-20 8:57 ` Joakim Zhang 2020-05-12 7:31 ` [PATCH V1 RESEND 3/3] arch: arm64: imx8mq/m/n: remove unused " Joakim Zhang 2020-05-12 7:31 ` Joakim Zhang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DB8PR04MB679528762BB39926FBCDE36EE67B0@DB8PR04MB6795.eurprd04.prod.outlook.com \ --to=qiangqing.zhang@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=john.garry@huawei.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.