From: Mark Brown <broonie@kernel.org>
To: dillon.minfei@gmail.com
Cc: robh+dt@kernel.org, p.zabel@pengutronix.de,
mcoquelin.stm32@gmail.com, devicetree@vger.kernel.org,
alexandre.torgue@st.com, thierry.reding@gmail.com,
sam@ravnborg.org, airlied@linux.ie, daniel@ffwll.ch,
mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
Date: Fri, 22 May 2020 12:36:34 +0100 [thread overview]
Message-ID: <20200522113634.GE5801@sirena.org.uk> (raw)
In-Reply-To: <1589800165-3271-4-git-send-email-dillon.minfei@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
On Mon, May 18, 2020 at 07:09:20PM +0800, dillon.minfei@gmail.com wrote:
> 2, use stm32 spi's "In full-duplex (BIDIMODE=0 and RXONLY=0)", as tx_buf is
> null, we must add dummy data sent out before read data.
> so, add stm32f4_spi_tx_dummy() to handle this situation.
There are flags SPI_CONTROLLER_MUST_TX and SPI_CONTROLLER_MUST_RX flags
that the driver can set if it needs to, no need to open code this in the
driver.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: dillon.minfei@gmail.com
Cc: devicetree@vger.kernel.org, p.zabel@pengutronix.de,
airlied@linux.ie, mturquette@baylibre.com,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-spi@vger.kernel.org,
sboyd@kernel.org, robh+dt@kernel.org, thierry.reding@gmail.com,
mcoquelin.stm32@gmail.com, daniel@ffwll.ch, sam@ravnborg.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, alexandre.torgue@st.com
Subject: Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
Date: Fri, 22 May 2020 12:36:34 +0100 [thread overview]
Message-ID: <20200522113634.GE5801@sirena.org.uk> (raw)
In-Reply-To: <1589800165-3271-4-git-send-email-dillon.minfei@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 423 bytes --]
On Mon, May 18, 2020 at 07:09:20PM +0800, dillon.minfei@gmail.com wrote:
> 2, use stm32 spi's "In full-duplex (BIDIMODE=0 and RXONLY=0)", as tx_buf is
> null, we must add dummy data sent out before read data.
> so, add stm32f4_spi_tx_dummy() to handle this situation.
There are flags SPI_CONTROLLER_MUST_TX and SPI_CONTROLLER_MUST_RX flags
that the driver can set if it needs to, no need to open code this in the
driver.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: dillon.minfei@gmail.com
Cc: devicetree@vger.kernel.org, airlied@linux.ie,
mturquette@baylibre.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-spi@vger.kernel.org, sboyd@kernel.org, robh+dt@kernel.org,
thierry.reding@gmail.com, mcoquelin.stm32@gmail.com,
sam@ravnborg.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, alexandre.torgue@st.com
Subject: Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
Date: Fri, 22 May 2020 12:36:34 +0100 [thread overview]
Message-ID: <20200522113634.GE5801@sirena.org.uk> (raw)
In-Reply-To: <1589800165-3271-4-git-send-email-dillon.minfei@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 423 bytes --]
On Mon, May 18, 2020 at 07:09:20PM +0800, dillon.minfei@gmail.com wrote:
> 2, use stm32 spi's "In full-duplex (BIDIMODE=0 and RXONLY=0)", as tx_buf is
> null, we must add dummy data sent out before read data.
> so, add stm32f4_spi_tx_dummy() to handle this situation.
There are flags SPI_CONTROLLER_MUST_TX and SPI_CONTROLLER_MUST_RX flags
that the driver can set if it needs to, no need to open code this in the
driver.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-22 11:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 11:09 [PATCH v4 0/8] Enable ili9341 and l3gd20 on stm32f429-disco dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 1/8] ARM: dts: stm32: Add dma config for spi5 dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 2/8] ARM: dts: stm32: enable l3gd20 on stm32429-disco board dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4 dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-22 11:36 ` Mark Brown [this message]
2020-05-22 11:36 ` Mark Brown
2020-05-22 11:36 ` Mark Brown
2020-05-22 14:57 ` dillon min
2020-05-22 14:57 ` dillon min
2020-05-22 14:57 ` dillon min
2020-05-22 15:59 ` dillon min
2020-05-22 15:59 ` dillon min
2020-05-22 15:59 ` dillon min
2020-05-22 16:29 ` Mark Brown
2020-05-22 16:29 ` Mark Brown
2020-05-22 16:29 ` Mark Brown
2020-05-23 1:35 ` dillon min
2020-05-23 1:35 ` dillon min
2020-05-23 1:35 ` dillon min
2020-05-25 11:43 ` Mark Brown
2020-05-25 11:43 ` Mark Brown
2020-05-25 11:43 ` Mark Brown
2020-05-18 11:09 ` [PATCH v4 4/8] ARM: dts: stm32: Add pin map for ltdc on stm32f429-disco board dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 5/8] dt-bindings: display: panel: Add ilitek ili9341 panel bindings dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-28 20:49 ` Rob Herring
2020-05-28 20:49 ` Rob Herring
2020-05-28 20:49 ` Rob Herring
2020-05-18 11:09 ` [PATCH v4 6/8] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 7/8] clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 8/8] drm/panel: Add ilitek ili9341 panel driver dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522113634.GE5801@sirena.org.uk \
--to=broonie@kernel.org \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.