From: Mark Brown <broonie@kernel.org>
To: dillon min <dillon.minfei@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
p.zabel@pengutronix.de,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Alexandre Torgue <alexandre.torgue@st.com>,
thierry.reding@gmail.com, Sam Ravnborg <sam@ravnborg.org>,
Dave Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
Date: Fri, 22 May 2020 17:29:01 +0100 [thread overview]
Message-ID: <20200522162901.GP5801@sirena.org.uk> (raw)
In-Reply-To: <CAL9mu0JZ4Qy+m2oF9TSTRqA_mM0J89huCt3t_Gs7qHa=3LxhBw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
On Fri, May 22, 2020 at 11:59:25PM +0800, dillon min wrote:
> but, after spi-core create a dummy tx_buf or rx_buf, then i can't get
> the correct spi_3wire direction.
> actually, this dummy tx_buf is useless for SPI_3WIRE. it's has meaning
> for SPI_SIMPLE_RX mode,
> simulate SPI_FULL_DUMPLEX
Oh, that's annoying. I think the fix here is in the core, it should
ignore MUST_TX and MUST_RX in 3WIRE mode since they clearly make no
sense there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: dillon min <dillon.minfei@gmail.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
p.zabel@pengutronix.de, Dave Airlie <airlied@linux.ie>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk <linux-clk@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
linux-spi@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
thierry.reding@gmail.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Sam Ravnborg <sam@ravnborg.org>,
linux-stm32@st-md-mailman.stormreply.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
Date: Fri, 22 May 2020 17:29:01 +0100 [thread overview]
Message-ID: <20200522162901.GP5801@sirena.org.uk> (raw)
In-Reply-To: <CAL9mu0JZ4Qy+m2oF9TSTRqA_mM0J89huCt3t_Gs7qHa=3LxhBw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 446 bytes --]
On Fri, May 22, 2020 at 11:59:25PM +0800, dillon min wrote:
> but, after spi-core create a dummy tx_buf or rx_buf, then i can't get
> the correct spi_3wire direction.
> actually, this dummy tx_buf is useless for SPI_3WIRE. it's has meaning
> for SPI_SIMPLE_RX mode,
> simulate SPI_FULL_DUMPLEX
Oh, that's annoying. I think the fix here is in the core, it should
ignore MUST_TX and MUST_RX in 3WIRE mode since they clearly make no
sense there.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: dillon min <dillon.minfei@gmail.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Dave Airlie <airlied@linux.ie>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk <linux-clk@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
linux-spi@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
thierry.reding@gmail.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
linux-stm32@st-md-mailman.stormreply.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4
Date: Fri, 22 May 2020 17:29:01 +0100 [thread overview]
Message-ID: <20200522162901.GP5801@sirena.org.uk> (raw)
In-Reply-To: <CAL9mu0JZ4Qy+m2oF9TSTRqA_mM0J89huCt3t_Gs7qHa=3LxhBw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 446 bytes --]
On Fri, May 22, 2020 at 11:59:25PM +0800, dillon min wrote:
> but, after spi-core create a dummy tx_buf or rx_buf, then i can't get
> the correct spi_3wire direction.
> actually, this dummy tx_buf is useless for SPI_3WIRE. it's has meaning
> for SPI_SIMPLE_RX mode,
> simulate SPI_FULL_DUMPLEX
Oh, that's annoying. I think the fix here is in the core, it should
ignore MUST_TX and MUST_RX in 3WIRE mode since they clearly make no
sense there.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-22 16:29 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 11:09 [PATCH v4 0/8] Enable ili9341 and l3gd20 on stm32f429-disco dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 1/8] ARM: dts: stm32: Add dma config for spi5 dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 2/8] ARM: dts: stm32: enable l3gd20 on stm32429-disco board dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4 dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-22 11:36 ` Mark Brown
2020-05-22 11:36 ` Mark Brown
2020-05-22 11:36 ` Mark Brown
2020-05-22 14:57 ` dillon min
2020-05-22 14:57 ` dillon min
2020-05-22 14:57 ` dillon min
2020-05-22 15:59 ` dillon min
2020-05-22 15:59 ` dillon min
2020-05-22 15:59 ` dillon min
2020-05-22 16:29 ` Mark Brown [this message]
2020-05-22 16:29 ` Mark Brown
2020-05-22 16:29 ` Mark Brown
2020-05-23 1:35 ` dillon min
2020-05-23 1:35 ` dillon min
2020-05-23 1:35 ` dillon min
2020-05-25 11:43 ` Mark Brown
2020-05-25 11:43 ` Mark Brown
2020-05-25 11:43 ` Mark Brown
2020-05-18 11:09 ` [PATCH v4 4/8] ARM: dts: stm32: Add pin map for ltdc on stm32f429-disco board dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 5/8] dt-bindings: display: panel: Add ilitek ili9341 panel bindings dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-28 20:49 ` Rob Herring
2020-05-28 20:49 ` Rob Herring
2020-05-28 20:49 ` Rob Herring
2020-05-18 11:09 ` [PATCH v4 6/8] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 7/8] clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` [PATCH v4 8/8] drm/panel: Add ilitek ili9341 panel driver dillon.minfei
2020-05-18 11:09 ` dillon.minfei
2020-05-18 11:09 ` dillon.minfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522162901.GP5801@sirena.org.uk \
--to=broonie@kernel.org \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.