From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Joe Perches <joe@perches.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
MugilRaj <dmugil2000@gmail.com>,
devel@driverdev.osuosl.org, Kirk Reiser <kirk@reisers.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org,
Chris Brannon <chris@the-brannons.com>
Subject: Re: [PATCH] taging: speakup: remove volatile
Date: Fri, 22 May 2020 19:25:31 +0200 [thread overview]
Message-ID: <20200522172531.va2hi6jqog3a6473@function> (raw)
In-Reply-To: <162676bb69044efadd31daa9ea49fc6fb9664297.camel@perches.com>
Joe Perches, le ven. 22 mai 2020 10:22:03 -0700, a ecrit:
> > Put another way: I don't think putting any hint here would help, on the
> > contrary, somebody has to really look at what protection is needed,
> > without getting influenced by rules-of-thumb.
>
> checkpatch newbies/robots will submit this change again otherwise.
Ah, ok, right.
I don't think removing volatiles is a thing for newbies,
> Comment wording can always be improved.
I'd then suggest
/* TODO: determine what proper synchronization "volatile" should be
* replaced with. */
Samuel
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, Kirk Reiser <kirk@reisers.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org,
MugilRaj <dmugil2000@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Chris Brannon <chris@the-brannons.com>
Subject: Re: [PATCH] taging: speakup: remove volatile
Date: Fri, 22 May 2020 19:25:31 +0200 [thread overview]
Message-ID: <20200522172531.va2hi6jqog3a6473@function> (raw)
In-Reply-To: <162676bb69044efadd31daa9ea49fc6fb9664297.camel@perches.com>
Joe Perches, le ven. 22 mai 2020 10:22:03 -0700, a ecrit:
> > Put another way: I don't think putting any hint here would help, on the
> > contrary, somebody has to really look at what protection is needed,
> > without getting influenced by rules-of-thumb.
>
> checkpatch newbies/robots will submit this change again otherwise.
Ah, ok, right.
I don't think removing volatiles is a thing for newbies,
> Comment wording can always be improved.
I'd then suggest
/* TODO: determine what proper synchronization "volatile" should be
* replaced with. */
Samuel
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-22 17:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 9:16 [PATCH] taging: speakup: remove volatile MugilRaj
2020-05-22 9:16 ` MugilRaj
2020-05-22 9:21 ` Samuel Thibault
2020-05-22 9:21 ` Samuel Thibault
2020-05-22 9:37 ` Greg Kroah-Hartman
2020-05-22 9:37 ` Greg Kroah-Hartman
2020-05-22 10:34 ` Dan Carpenter
2020-05-22 10:34 ` Dan Carpenter
2020-05-22 16:36 ` Joe Perches
2020-05-22 16:36 ` Joe Perches
2020-05-22 17:13 ` Samuel Thibault
2020-05-22 17:13 ` Samuel Thibault
2020-05-22 17:22 ` Joe Perches
2020-05-22 17:22 ` Joe Perches
2020-05-22 17:25 ` Samuel Thibault [this message]
2020-05-22 17:25 ` Samuel Thibault
2020-05-22 17:50 ` Dan Carpenter
2020-05-22 17:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522172531.va2hi6jqog3a6473@function \
--to=samuel.thibault@ens-lyon.org \
--cc=chris@the-brannons.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmugil2000@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.