From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> To: Gaurav Pathak <gauravpathak129@gmail.com> Cc: abbotti@mev.co.uk, gregkh@linuxfoundation.org, hsweeten@visionengravers.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c. Date: Sun, 24 May 2020 14:10:44 +0200 [thread overview] Message-ID: <20200524121044.fzpm6hkqrrpa2yhc@ltop.local> (raw) In-Reply-To: <20200524113613.GA19734@xebrium.com> Hi, On Sun, May 24, 2020 at 05:06:18PM +0530, Gaurav Pathak wrote: > Silence following sparse warning: > drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_interrupt’: > drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] > int data; > ^~~~ > drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_attach’: > drivers/staging/comedi/drivers/dt2814.c:232:6: warning: variable ‘i’ set but not used [-Wunused-but-set-variable] > int i; > ^ These warnings are not from sparse but simply from the compiler. > static irqreturn_t dt2814_interrupt(int irq, void *d) > { > - int lo, hi; > struct comedi_device *dev = d; > struct dt2814_private *devpriv = dev->private; > struct comedi_subdevice *s = dev->read_subdev; > - int data; > > if (!dev->attached) { > dev_err(dev->class_dev, "spurious interrupt\n"); > return IRQ_HANDLED; > } > > - hi = inb(dev->iobase + DT2814_DATA); > - lo = inb(dev->iobase + DT2814_DATA); > - > - data = (hi << 4) | (lo >> 4); OK, 'data' is unused but are these 2 'inb(dev->iobase + DT2814_DATA)' needed or not? I would guess that they're needed but I don't know this hardware. > @@ -241,8 +233,6 @@ static int dt2814_attach(struct comedi_device *dev, struct comedi_devconfig *it) > dev_err(dev->class_dev, "reset error (fatal)\n"); > return -EIO; > } > - i = inb(dev->iobase + DT2814_DATA); > - i = inb(dev->iobase + DT2814_DATA); Same here. -- Luc
WARNING: multiple messages have this Message-ID (diff)
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> To: Gaurav Pathak <gauravpathak129@gmail.com> Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, abbotti@mev.co.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c. Date: Sun, 24 May 2020 14:10:44 +0200 [thread overview] Message-ID: <20200524121044.fzpm6hkqrrpa2yhc@ltop.local> (raw) In-Reply-To: <20200524113613.GA19734@xebrium.com> Hi, On Sun, May 24, 2020 at 05:06:18PM +0530, Gaurav Pathak wrote: > Silence following sparse warning: > drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_interrupt’: > drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] > int data; > ^~~~ > drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_attach’: > drivers/staging/comedi/drivers/dt2814.c:232:6: warning: variable ‘i’ set but not used [-Wunused-but-set-variable] > int i; > ^ These warnings are not from sparse but simply from the compiler. > static irqreturn_t dt2814_interrupt(int irq, void *d) > { > - int lo, hi; > struct comedi_device *dev = d; > struct dt2814_private *devpriv = dev->private; > struct comedi_subdevice *s = dev->read_subdev; > - int data; > > if (!dev->attached) { > dev_err(dev->class_dev, "spurious interrupt\n"); > return IRQ_HANDLED; > } > > - hi = inb(dev->iobase + DT2814_DATA); > - lo = inb(dev->iobase + DT2814_DATA); > - > - data = (hi << 4) | (lo >> 4); OK, 'data' is unused but are these 2 'inb(dev->iobase + DT2814_DATA)' needed or not? I would guess that they're needed but I don't know this hardware. > @@ -241,8 +233,6 @@ static int dt2814_attach(struct comedi_device *dev, struct comedi_devconfig *it) > dev_err(dev->class_dev, "reset error (fatal)\n"); > return -EIO; > } > - i = inb(dev->iobase + DT2814_DATA); > - i = inb(dev->iobase + DT2814_DATA); Same here. -- Luc _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-24 12:10 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-24 11:36 [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c Gaurav Pathak 2020-05-24 11:36 ` Gaurav Pathak 2020-05-24 12:10 ` Luc Van Oostenryck [this message] 2020-05-24 12:10 ` Luc Van Oostenryck 2020-05-24 12:49 ` GAURAV PATHAK 2020-05-24 12:49 ` GAURAV PATHAK 2020-05-24 13:58 ` Luc Van Oostenryck 2020-05-24 13:58 ` Luc Van Oostenryck 2020-05-24 13:32 ` GAURAV PATHAK 2020-05-24 13:32 ` GAURAV PATHAK 2020-05-24 14:08 ` Luc Van Oostenryck 2020-05-24 14:08 ` Luc Van Oostenryck 2020-05-26 14:13 ` Dan Carpenter 2020-05-26 14:13 ` Dan Carpenter 2020-05-26 14:54 ` GAURAV PATHAK 2020-05-26 14:54 ` GAURAV PATHAK 2020-05-26 15:09 ` Dan Carpenter 2020-05-26 15:09 ` Dan Carpenter 2020-05-26 15:50 ` [PATCH v2] Staging: comedi: dt2814: remove unused assignments gaurav 2020-05-26 15:50 ` gaurav 2020-05-26 18:21 ` Dan Carpenter 2020-05-26 18:21 ` Dan Carpenter 2020-05-26 18:51 ` [PATCH v3] " Gaurav Pathak 2020-05-26 18:51 ` Gaurav Pathak 2020-05-26 20:24 ` Dan Carpenter 2020-05-26 20:24 ` Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200524121044.fzpm6hkqrrpa2yhc@ltop.local \ --to=luc.vanoostenryck@gmail.com \ --cc=abbotti@mev.co.uk \ --cc=devel@driverdev.osuosl.org \ --cc=gauravpathak129@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=hsweeten@visionengravers.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.