All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: GAURAV PATHAK <gauravpathak129@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
Date: Tue, 26 May 2020 18:09:54 +0300	[thread overview]
Message-ID: <20200526150954.GA30374@kadam> (raw)
In-Reply-To: <20200526145448.GA5197@xebrium.com>

On Tue, May 26, 2020 at 08:24:50PM +0530, GAURAV PATHAK wrote:
> On Tue, May 26, 2020 at 05:13:46PM +0300, Dan Carpenter wrote:
> > Your subject doesn't use the correct patch prefix please use.
> > 
> > [PATCH] Staging: comedi: dt2814: remove unused assignments
> > 
> > Please resend a v2.
> > 
> > Correct the references to Sparse as well like Luc said.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Hello Dan,
> Thank you for reviewing and suggesting changes. I have modified the
> patch and attached it with the e-mail to keep this thread conversation.
> I hope I have made the changes correctly.
> 

No, this isn't how to send a v2 patch.

https://www.google.com/search?client=firefox-b-d&q=how+to+send+a+v2+patch

Put [PATCH v2] in the subject.  Don't send patches as attachments.
Put a comment after the --- cut off line:

Signed-off...
---
v2: Update subject and commit message.

If you want to reply to the thread, that's good.  Use --in-reply-to=<Message-id>
But don't worry about it too much.  Greg applies or deletes patches as
soon as he sees them so either way he's not going to have the original
thread in his inbox.

regards,
dan carpenter



WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: GAURAV PATHAK <gauravpathak129@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
Date: Tue, 26 May 2020 18:09:54 +0300	[thread overview]
Message-ID: <20200526150954.GA30374@kadam> (raw)
In-Reply-To: <20200526145448.GA5197@xebrium.com>

On Tue, May 26, 2020 at 08:24:50PM +0530, GAURAV PATHAK wrote:
> On Tue, May 26, 2020 at 05:13:46PM +0300, Dan Carpenter wrote:
> > Your subject doesn't use the correct patch prefix please use.
> > 
> > [PATCH] Staging: comedi: dt2814: remove unused assignments
> > 
> > Please resend a v2.
> > 
> > Correct the references to Sparse as well like Luc said.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Hello Dan,
> Thank you for reviewing and suggesting changes. I have modified the
> patch and attached it with the e-mail to keep this thread conversation.
> I hope I have made the changes correctly.
> 

No, this isn't how to send a v2 patch.

https://www.google.com/search?client=firefox-b-d&q=how+to+send+a+v2+patch

Put [PATCH v2] in the subject.  Don't send patches as attachments.
Put a comment after the --- cut off line:

Signed-off...
---
v2: Update subject and commit message.

If you want to reply to the thread, that's good.  Use --in-reply-to=<Message-id>
But don't worry about it too much.  Greg applies or deletes patches as
soon as he sees them so either way he's not going to have the original
thread in his inbox.

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2020-05-26 15:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-24 11:36 [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c Gaurav Pathak
2020-05-24 11:36 ` Gaurav Pathak
2020-05-24 12:10 ` Luc Van Oostenryck
2020-05-24 12:10   ` Luc Van Oostenryck
2020-05-24 12:49   ` GAURAV PATHAK
2020-05-24 12:49     ` GAURAV PATHAK
2020-05-24 13:58     ` Luc Van Oostenryck
2020-05-24 13:58       ` Luc Van Oostenryck
2020-05-24 13:32   ` GAURAV PATHAK
2020-05-24 13:32     ` GAURAV PATHAK
2020-05-24 14:08     ` Luc Van Oostenryck
2020-05-24 14:08       ` Luc Van Oostenryck
2020-05-26 14:13 ` Dan Carpenter
2020-05-26 14:13   ` Dan Carpenter
2020-05-26 14:54   ` GAURAV PATHAK
2020-05-26 14:54     ` GAURAV PATHAK
2020-05-26 15:09     ` Dan Carpenter [this message]
2020-05-26 15:09       ` Dan Carpenter
2020-05-26 15:50       ` [PATCH v2] Staging: comedi: dt2814: remove unused assignments gaurav
2020-05-26 15:50         ` gaurav
2020-05-26 18:21         ` Dan Carpenter
2020-05-26 18:21           ` Dan Carpenter
2020-05-26 18:51           ` [PATCH v3] " Gaurav Pathak
2020-05-26 18:51             ` Gaurav Pathak
2020-05-26 20:24             ` Dan Carpenter
2020-05-26 20:24               ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200526150954.GA30374@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gauravpathak129@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.