From: Nathan Chancellor <natechancellor@gmail.com> To: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: [PATCH 0/7] media: atomisp: Address several clang warnings Date: Wed, 27 May 2020 00:11:43 -0700 [thread overview] Message-ID: <20200527071150.3381228-1-natechancellor@gmail.com> (raw) Hi all, This series aims to clean up the code while addressing the majority of clang warnings in this driver, some found by the 0day bot and others found by me. There are several enum conversion warnings that happen, which I do not really know how to solve without understanding how exactly this driver works. I would appreciate some guidance or a solution. Below are the warnings, sorry for not wrapping them but they would be hard to read otherwise. ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:49:65: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] { V4L2_MBUS_FMT_CUSTOM_NV21, 12, 12, CSS_FRAME_FORMAT_NV21, 0, CSS_FRAME_FORMAT_NV21 }, ~ ^~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat.h:101:32: note: expanded from macro 'CSS_FRAME_FORMAT_NV21' #define CSS_FRAME_FORMAT_NV21 CSS_ID(CSS_FRAME_FORMAT_NV21) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' #define CSS_ID(val) (IA_ ## val) ^~~~~~~~~~ <scratch space>:69:1: note: expanded from here IA_CSS_FRAME_FORMAT_NV21 ^~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:49:39: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] { V4L2_MBUS_FMT_CUSTOM_NV21, 12, 12, CSS_FRAME_FORMAT_NV21, 0, CSS_FRAME_FORMAT_NV21 }, ~ ^~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat.h:101:32: note: expanded from macro 'CSS_FRAME_FORMAT_NV21' #define CSS_FRAME_FORMAT_NV21 CSS_ID(CSS_FRAME_FORMAT_NV21) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' #define CSS_ID(val) (IA_ ## val) ^~~~~~~~~~ <scratch space>:68:1: note: expanded from here IA_CSS_FRAME_FORMAT_NV21 ^~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:48:65: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] { V4L2_MBUS_FMT_CUSTOM_NV12, 12, 12, CSS_FRAME_FORMAT_NV12, 0, CSS_FRAME_FORMAT_NV12 }, ~ ^~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat.h:99:32: note: expanded from macro 'CSS_FRAME_FORMAT_NV12' #define CSS_FRAME_FORMAT_NV12 CSS_ID(CSS_FRAME_FORMAT_NV12) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' #define CSS_ID(val) (IA_ ## val) ^~~~~~~~~~ <scratch space>:67:1: note: expanded from here IA_CSS_FRAME_FORMAT_NV12 ^~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:48:39: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] { V4L2_MBUS_FMT_CUSTOM_NV12, 12, 12, CSS_FRAME_FORMAT_NV12, 0, CSS_FRAME_FORMAT_NV12 }, ~ ^~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat.h:99:32: note: expanded from macro 'CSS_FRAME_FORMAT_NV12' #define CSS_FRAME_FORMAT_NV12 CSS_ID(CSS_FRAME_FORMAT_NV12) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' #define CSS_ID(val) (IA_ ## val) ^~~~~~~~~~ <scratch space>:66:1: note: expanded from here IA_CSS_FRAME_FORMAT_NV12 ^~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:47:34: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] { MEDIA_BUS_FMT_JPEG_1X8, 8, 8, CSS_FRAME_FORMAT_BINARY_8, 0, ATOMISP_INPUT_FORMAT_BINARY_8 }, ~ ^~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat.h:118:35: note: expanded from macro 'CSS_FRAME_FORMAT_BINARY_8' #define CSS_FRAME_FORMAT_BINARY_8 CSS_ID(CSS_FRAME_FORMAT_BINARY_8) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' #define CSS_ID(val) (IA_ ## val) ^~~~~~~~~~ <scratch space>:65:1: note: expanded from here IA_CSS_FRAME_FORMAT_BINARY_8 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ 5 warnings generated. Please let me know if there are any comments, cheers! Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com> To: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: devel@driverdev.osuosl.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org Subject: [PATCH 0/7] media: atomisp: Address several clang warnings Date: Wed, 27 May 2020 00:11:43 -0700 [thread overview] Message-ID: <20200527071150.3381228-1-natechancellor@gmail.com> (raw) Hi all, This series aims to clean up the code while addressing the majority of clang warnings in this driver, some found by the 0day bot and others found by me. There are several enum conversion warnings that happen, which I do not really know how to solve without understanding how exactly this driver works. I would appreciate some guidance or a solution. Below are the warnings, sorry for not wrapping them but they would be hard to read otherwise. ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:49:65: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] { V4L2_MBUS_FMT_CUSTOM_NV21, 12, 12, CSS_FRAME_FORMAT_NV21, 0, CSS_FRAME_FORMAT_NV21 }, ~ ^~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat.h:101:32: note: expanded from macro 'CSS_FRAME_FORMAT_NV21' #define CSS_FRAME_FORMAT_NV21 CSS_ID(CSS_FRAME_FORMAT_NV21) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' #define CSS_ID(val) (IA_ ## val) ^~~~~~~~~~ <scratch space>:69:1: note: expanded from here IA_CSS_FRAME_FORMAT_NV21 ^~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:49:39: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] { V4L2_MBUS_FMT_CUSTOM_NV21, 12, 12, CSS_FRAME_FORMAT_NV21, 0, CSS_FRAME_FORMAT_NV21 }, ~ ^~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat.h:101:32: note: expanded from macro 'CSS_FRAME_FORMAT_NV21' #define CSS_FRAME_FORMAT_NV21 CSS_ID(CSS_FRAME_FORMAT_NV21) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' #define CSS_ID(val) (IA_ ## val) ^~~~~~~~~~ <scratch space>:68:1: note: expanded from here IA_CSS_FRAME_FORMAT_NV21 ^~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:48:65: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] { V4L2_MBUS_FMT_CUSTOM_NV12, 12, 12, CSS_FRAME_FORMAT_NV12, 0, CSS_FRAME_FORMAT_NV12 }, ~ ^~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat.h:99:32: note: expanded from macro 'CSS_FRAME_FORMAT_NV12' #define CSS_FRAME_FORMAT_NV12 CSS_ID(CSS_FRAME_FORMAT_NV12) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' #define CSS_ID(val) (IA_ ## val) ^~~~~~~~~~ <scratch space>:67:1: note: expanded from here IA_CSS_FRAME_FORMAT_NV12 ^~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:48:39: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] { V4L2_MBUS_FMT_CUSTOM_NV12, 12, 12, CSS_FRAME_FORMAT_NV12, 0, CSS_FRAME_FORMAT_NV12 }, ~ ^~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat.h:99:32: note: expanded from macro 'CSS_FRAME_FORMAT_NV12' #define CSS_FRAME_FORMAT_NV12 CSS_ID(CSS_FRAME_FORMAT_NV12) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' #define CSS_ID(val) (IA_ ## val) ^~~~~~~~~~ <scratch space>:66:1: note: expanded from here IA_CSS_FRAME_FORMAT_NV12 ^~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:47:34: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] { MEDIA_BUS_FMT_JPEG_1X8, 8, 8, CSS_FRAME_FORMAT_BINARY_8, 0, ATOMISP_INPUT_FORMAT_BINARY_8 }, ~ ^~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat.h:118:35: note: expanded from macro 'CSS_FRAME_FORMAT_BINARY_8' #define CSS_FRAME_FORMAT_BINARY_8 CSS_ID(CSS_FRAME_FORMAT_BINARY_8) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' #define CSS_ID(val) (IA_ ## val) ^~~~~~~~~~ <scratch space>:65:1: note: expanded from here IA_CSS_FRAME_FORMAT_BINARY_8 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ 5 warnings generated. Please let me know if there are any comments, cheers! Nathan _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next reply other threads:[~2020-05-27 7:12 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-27 7:11 Nathan Chancellor [this message] 2020-05-27 7:11 ` [PATCH 0/7] media: atomisp: Address several clang warnings Nathan Chancellor 2020-05-27 7:11 ` [PATCH 1/7] media: atomisp: Clean up if block in sh_css_sp_init_stage Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` [PATCH 2/7] media: atomisp: Remove second increment of count in atomisp_subdev_probe Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` [PATCH 3/7] media: atomisp: Add stub for atomisp_mrfld_power Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` [PATCH 4/7] media: atomisp: Remove unnecessary NULL checks in ia_css_pipe_load_extension Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` [PATCH 5/7] media: atomisp: Remove unnecessary NULL check in atomisp_param Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` [PATCH 6/7] media: atomisp: Avoid overflow in compute_blending Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` [PATCH 7/7] media: atomisp: Remove binary_supports_input_format Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 8:45 ` [PATCH 0/7] media: atomisp: Address several clang warnings Mauro Carvalho Chehab 2020-05-27 8:45 ` Mauro Carvalho Chehab 2020-05-27 16:45 ` Nathan Chancellor 2020-05-27 16:45 ` Nathan Chancellor 2020-05-27 17:20 ` Mauro Carvalho Chehab 2020-05-27 17:20 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200527071150.3381228-1-natechancellor@gmail.com \ --to=natechancellor@gmail.com \ --cc=clang-built-linux@googlegroups.com \ --cc=devel@driverdev.osuosl.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=sakari.ailus@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.