From: Nathan Chancellor <natechancellor@gmail.com> To: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor <natechancellor@gmail.com> Subject: [PATCH 3/7] media: atomisp: Add stub for atomisp_mrfld_power Date: Wed, 27 May 2020 00:11:46 -0700 [thread overview] Message-ID: <20200527071150.3381228-4-natechancellor@gmail.com> (raw) In-Reply-To: <20200527071150.3381228-1-natechancellor@gmail.com> Clang warns: ../drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: warning: unused function 'atomisp_mrfld_power' [-Wunused-function] static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) ^ Use an '#if 0' preprocessor define to hide the broken code, leaving the FIXME comment intact, and creating an atomisp_mrfld_power stub function that just returns 0. Fixes: 95d1f398c4dc ("media: atomisp: keep the ISP powered on when setting it") Link: https://github.com/ClangBuiltLinux/linux/issues/1036 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c index c42999a55303..41aa6018d254 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -736,6 +736,8 @@ static int atomisp_mrfld_pre_power_down(struct atomisp_device *isp) * WA for DDR DVFS enable/disable * By default, ISP will force DDR DVFS 1600MHz before disable DVFS */ +/* FIXME: at least with ISP2401, the code below causes the driver to break */ +#if 0 static void punit_ddr_dvfs_enable(bool enable) { int door_bell = 1 << 8; @@ -820,20 +822,23 @@ static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) dev_err(isp->dev, "IUNIT power-%s timeout.\n", enable ? "on" : "off"); return -EBUSY; } +#else +static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) +{ + return 0; +} +#endif /* Workaround for pmu_nc_set_power_state not ready in MRFLD */ int atomisp_mrfld_power_down(struct atomisp_device *isp) { - return 0; -// FIXME: at least with ISP2401, the code below causes the driver to break -// return atomisp_mrfld_power(isp, false); + return atomisp_mrfld_power(isp, false); } /* Workaround for pmu_nc_set_power_state not ready in MRFLD */ int atomisp_mrfld_power_up(struct atomisp_device *isp) { return 0; -// FIXME: at least with ISP2401, the code below causes the driver to break // return atomisp_mrfld_power(isp, true); } -- 2.27.0.rc0
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com> To: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Sakari Ailus <sakari.ailus@linux.intel.com>, Nathan Chancellor <natechancellor@gmail.com>, linux-media@vger.kernel.org Subject: [PATCH 3/7] media: atomisp: Add stub for atomisp_mrfld_power Date: Wed, 27 May 2020 00:11:46 -0700 [thread overview] Message-ID: <20200527071150.3381228-4-natechancellor@gmail.com> (raw) In-Reply-To: <20200527071150.3381228-1-natechancellor@gmail.com> Clang warns: ../drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: warning: unused function 'atomisp_mrfld_power' [-Wunused-function] static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) ^ Use an '#if 0' preprocessor define to hide the broken code, leaving the FIXME comment intact, and creating an atomisp_mrfld_power stub function that just returns 0. Fixes: 95d1f398c4dc ("media: atomisp: keep the ISP powered on when setting it") Link: https://github.com/ClangBuiltLinux/linux/issues/1036 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c index c42999a55303..41aa6018d254 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -736,6 +736,8 @@ static int atomisp_mrfld_pre_power_down(struct atomisp_device *isp) * WA for DDR DVFS enable/disable * By default, ISP will force DDR DVFS 1600MHz before disable DVFS */ +/* FIXME: at least with ISP2401, the code below causes the driver to break */ +#if 0 static void punit_ddr_dvfs_enable(bool enable) { int door_bell = 1 << 8; @@ -820,20 +822,23 @@ static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) dev_err(isp->dev, "IUNIT power-%s timeout.\n", enable ? "on" : "off"); return -EBUSY; } +#else +static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) +{ + return 0; +} +#endif /* Workaround for pmu_nc_set_power_state not ready in MRFLD */ int atomisp_mrfld_power_down(struct atomisp_device *isp) { - return 0; -// FIXME: at least with ISP2401, the code below causes the driver to break -// return atomisp_mrfld_power(isp, false); + return atomisp_mrfld_power(isp, false); } /* Workaround for pmu_nc_set_power_state not ready in MRFLD */ int atomisp_mrfld_power_up(struct atomisp_device *isp) { return 0; -// FIXME: at least with ISP2401, the code below causes the driver to break // return atomisp_mrfld_power(isp, true); } -- 2.27.0.rc0 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-27 7:12 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-27 7:11 [PATCH 0/7] media: atomisp: Address several clang warnings Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` [PATCH 1/7] media: atomisp: Clean up if block in sh_css_sp_init_stage Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` [PATCH 2/7] media: atomisp: Remove second increment of count in atomisp_subdev_probe Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor [this message] 2020-05-27 7:11 ` [PATCH 3/7] media: atomisp: Add stub for atomisp_mrfld_power Nathan Chancellor 2020-05-27 7:11 ` [PATCH 4/7] media: atomisp: Remove unnecessary NULL checks in ia_css_pipe_load_extension Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` [PATCH 5/7] media: atomisp: Remove unnecessary NULL check in atomisp_param Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` [PATCH 6/7] media: atomisp: Avoid overflow in compute_blending Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 7:11 ` [PATCH 7/7] media: atomisp: Remove binary_supports_input_format Nathan Chancellor 2020-05-27 7:11 ` Nathan Chancellor 2020-05-27 8:45 ` [PATCH 0/7] media: atomisp: Address several clang warnings Mauro Carvalho Chehab 2020-05-27 8:45 ` Mauro Carvalho Chehab 2020-05-27 16:45 ` Nathan Chancellor 2020-05-27 16:45 ` Nathan Chancellor 2020-05-27 17:20 ` Mauro Carvalho Chehab 2020-05-27 17:20 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200527071150.3381228-4-natechancellor@gmail.com \ --to=natechancellor@gmail.com \ --cc=clang-built-linux@googlegroups.com \ --cc=devel@driverdev.osuosl.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=sakari.ailus@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.