All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Daniel Axtens <dja@axtens.net>
Cc: kbuild test robot <lkp@intel.com>,
	kbuild-all@lists.01.org, Johannes Weiner <hannes@cmpxchg.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [hnaz-linux-mm:master 169/698] include/linux/string.h:307:9: note: in expansion of macro '__underlying_strncpy'
Date: Tue, 2 Jun 2020 12:16:20 -0700	[thread overview]
Message-ID: <20200602121620.257a40752a9ce475d8a2c6c8@linux-foundation.org> (raw)
In-Reply-To: <87r1uyyptc.fsf@dja-thinkpad.axtens.net>

On Tue, 02 Jun 2020 15:55:27 +1000 Daniel Axtens <dja@axtens.net> wrote:

> Huh, turns out that we do actually see a similar set of warnings before
> and after this patch, they're just different warnings as a consequence
> of my patch.

Ah.
 
> Given that these warnings only show up at W=1, is there any point in
> further supressing them?

I guess not.

So what should we do?  Go over the various sites and use memcpy(), each
with a suitably apologetic code comment explaining the reason?


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: kbuild-all@lists.01.org
Subject: Re: [hnaz-linux-mm:master 169/698] include/linux/string.h:307:9: note: in expansion of macro '__underlying_strncpy'
Date: Tue, 02 Jun 2020 12:16:20 -0700	[thread overview]
Message-ID: <20200602121620.257a40752a9ce475d8a2c6c8@linux-foundation.org> (raw)
In-Reply-To: <87r1uyyptc.fsf@dja-thinkpad.axtens.net>

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

On Tue, 02 Jun 2020 15:55:27 +1000 Daniel Axtens <dja@axtens.net> wrote:

> Huh, turns out that we do actually see a similar set of warnings before
> and after this patch, they're just different warnings as a consequence
> of my patch.

Ah.
 
> Given that these warnings only show up at W=1, is there any point in
> further supressing them?

I guess not.

So what should we do?  Go over the various sites and use memcpy(), each
with a suitably apologetic code comment explaining the reason?

  reply	other threads:[~2020-06-02 19:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-30 10:07 [hnaz-linux-mm:master 169/698] include/linux/string.h:307:9: note: in expansion of macro '__underlying_strncpy' kbuild test robot
2020-05-30 10:07 ` kbuild test robot
2020-06-02  1:04 ` Andrew Morton
2020-06-02  1:04   ` Andrew Morton
2020-06-02  3:26   ` Daniel Axtens
2020-06-02  3:26     ` Daniel Axtens
2020-06-02  3:53     ` Daniel Axtens
2020-06-02  3:53       ` Daniel Axtens
2020-06-02  5:55       ` Daniel Axtens
2020-06-02  5:55         ` Daniel Axtens
2020-06-02 19:16         ` Andrew Morton [this message]
2020-06-02 19:16           ` Andrew Morton
2020-06-05 10:35           ` Daniel Axtens
2020-06-05 10:35             ` Daniel Axtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200602121620.257a40752a9ce475d8a2c6c8@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dja@axtens.net \
    --cc=dvyukov@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.