From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
linux-gpio@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] pinctrl: baytrail: Fix pin being driven low for a while on gpiod_get(..., GPIOD_OUT_HIGH)
Date: Fri, 5 Jun 2020 21:45:41 +0300 [thread overview]
Message-ID: <20200605184541.GU2428291@smile.fi.intel.com> (raw)
In-Reply-To: <1cf9b188-1e59-b321-6909-bf6afa93685d@redhat.com>
On Fri, Jun 05, 2020 at 07:31:35PM +0200, Hans de Goede wrote:
> On 6/5/20 7:09 PM, Andy Shevchenko wrote:
> > On Fri, Jun 05, 2020 at 04:33:47PM +0200, Hans de Goede wrote:
> > > On 6/2/20 5:23 PM, Andy Shevchenko wrote:
> > > > On Tue, Jun 02, 2020 at 02:21:30PM +0200, Hans de Goede wrote:
...
> > > Sure, not sure if that is worth respinning the patch for though,
> > > either way let me know.
> >
> > I think makes sense to respin. We still have time.
>
> I wasn't talking about timing, more just that it creates extra
> work (for me) and if that was just for the capital 'B' thingie it
> would not be worth the extra work IMHO, but since we need a v2 for
> the fixes tag anyways I'll fix this as well.
I got your point, no problem, I would fix myself, if it is only the comment
to address.
...
> > Btw, can we for sake of consistency update direction_input() as well?
>
> Sure, the change for that will be quite small, so shall I out it
> in this patch, or do you want a second patch for that?
I think we can do in one.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] pinctrl: baytrail: Fix pin being driven low for a while on gpiod_get(..., GPIOD_OUT_HIGH)
Date: Fri, 5 Jun 2020 21:45:41 +0300 [thread overview]
Message-ID: <20200605184541.GU2428291@smile.fi.intel.com> (raw)
In-Reply-To: <1cf9b188-1e59-b321-6909-bf6afa93685d@redhat.com>
On Fri, Jun 05, 2020 at 07:31:35PM +0200, Hans de Goede wrote:
> On 6/5/20 7:09 PM, Andy Shevchenko wrote:
> > On Fri, Jun 05, 2020 at 04:33:47PM +0200, Hans de Goede wrote:
> > > On 6/2/20 5:23 PM, Andy Shevchenko wrote:
> > > > On Tue, Jun 02, 2020 at 02:21:30PM +0200, Hans de Goede wrote:
...
> > > Sure, not sure if that is worth respinning the patch for though,
> > > either way let me know.
> >
> > I think makes sense to respin. We still have time.
>
> I wasn't talking about timing, more just that it creates extra
> work (for me) and if that was just for the capital 'B' thingie it
> would not be worth the extra work IMHO, but since we need a v2 for
> the fixes tag anyways I'll fix this as well.
I got your point, no problem, I would fix myself, if it is only the comment
to address.
...
> > Btw, can we for sake of consistency update direction_input() as well?
>
> Sure, the change for that will be quite small, so shall I out it
> in this patch, or do you want a second patch for that?
I think we can do in one.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-06-05 18:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 12:21 [PATCH] pinctrl: baytrail: Fix pin being driven low for a while on gpiod_get(..., GPIOD_OUT_HIGH) Hans de Goede
2020-06-02 12:21 ` [Intel-gfx] " Hans de Goede
2020-06-02 13:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2020-06-02 15:23 ` [PATCH] " Andy Shevchenko
2020-06-02 15:23 ` [Intel-gfx] " Andy Shevchenko
2020-06-02 15:25 ` Andy Shevchenko
2020-06-02 15:25 ` [Intel-gfx] " Andy Shevchenko
2020-06-05 14:33 ` Hans de Goede
2020-06-05 14:33 ` [Intel-gfx] " Hans de Goede
2020-06-05 17:09 ` Andy Shevchenko
2020-06-05 17:09 ` [Intel-gfx] " Andy Shevchenko
2020-06-05 17:31 ` Hans de Goede
2020-06-05 17:31 ` [Intel-gfx] " Hans de Goede
2020-06-05 18:45 ` Andy Shevchenko [this message]
2020-06-05 18:45 ` Andy Shevchenko
2020-06-05 14:10 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605184541.GU2428291@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.